Move Animation APIs from Accompanist back into Jetpack Navigation [197140101]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 18, 2021 08:31PM

As of compose 1.0.1 many of the Compose Animation APIs are still @Experimental.

Because of AndroidX internal restrictions, modules cannot depend on experimental APIs from other modules.

In the interest of providing a solution for Navigation with custom Compose Animations as soon as possible, we opted to provide a new module in Accompanist Navigation. Once all the required animation APIs become stable, which is planned as part of Compose 1.1.0, we will move the implementation back into the Jetpack Navigation library from Accompanist Navigation Animation.

For more details, see the Animations in Navigation Compose blog post.

Comments

ti...@gmail.com <ti...@gmail.com> #2Feb 12, 2022 08:03PM

The removal of the nested graphs and using popUpTo the given fragment appears to prevent the crash from happening in 1.0.0-alpha11.

il...@google.com <il...@google.com> #3Feb 14, 2022 05:19PM

Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev

commit 63bc1ff1fe7c348138295ee7efb8cdc2999622c0
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:18:53 2019

Update prebuilts for Navigation 1.0.0-beta01

Include fix for

b/123803044

Test: ./gradlew bOS
Change-Id: Icb2a50975541a7bd3327054c72a591c7689c9741

M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.sha1

https://android-review.googlesource.com/892878

https://goto.google.com/android-sha1/63bc1ff1fe7c348138295ee7efb8cdc2999622c0

ti...@gmail.com <ti...@gmail.com> #4Aug 2, 2022 04:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019

Return true when popping from FragmentNavigator

Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().

This ensures that the FragmentManager state and the
NavController states don't get out of sync.

Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/892996

https://goto.google.com/android-sha1/c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec

ru...@gmail.com <ru...@gmail.com> #5Jan 25, 2023 06:32AM

This is actually an issue where the NavController's back stack state is going out of sync with the FragmentManager / FragmentNavigator's state. This has been fixed and will be available in the next release.

k8...@gmail.com <k8...@gmail.com> #6Mar 21, 2023 02:11PM

Nice job! A quick response!

il...@google.com <il...@google.com> #7Mar 21, 2023 04:16PM

I still get this error using the lastest 1.0.0 release :

implementation 'android.arch.navigation:navigation-fragment-ktx:1.0.0'
implementation "android.arch.navigation:navigation-ui-ktx:1.0.0"

I'm using nested graphs.

jb...@google.com <jb...@google.com> May 8, 2023 06:11PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #8May 11, 2023 04:32PM

Re #7 - please file a new bug with a sample app that reproduces your issue.

ap...@google.com <ap...@google.com> #9May 11, 2023 04:32PM

Done.

https://issuetracker.google.com/131733658

ap...@google.com <ap...@google.com> #10May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023

Migrate accompanist NavGraphBuilder into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt

https://android-review.googlesource.com/2584842

ap...@google.com <ap...@google.com> #11May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 895c4bb35ee11fe1c54f538699a845ddfaf7e2eb
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 13:14:10 2023

Migrate accompanist ComposeNavigator into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "ComposeNavigator now supports Destinations with Animations."
Change-Id: Ie33b4c2da53ff6c89494332a06be8123be67e879

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt

https://android-review.googlesource.com/2584841

ap...@google.com <ap...@google.com> #12May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 169254301b8aad0454c253a65abff7bf174ba164
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 11:11:42 2023

Bump compose version in navigation-compose

Bump from 1.0.1 to ToT project dependency. Project dependency because compose is currently in alpha.

Test: n/a
Bug: 197140101
Relnote: "navigation-compose has bumped compose dependency to use latest compose dependency"
Change-Id: Ide442548636637c2b75d46ef99c9913b0ebb60b8

M navigation/navigation-compose/build.gradle

https://android-review.googlesource.com/2584840

il...@google.com <il...@google.com> #13May 11, 2023 11:12PM

Marked as fixed.

Now that AnimatedContent is stable, we were able to move the code from Accompanist Navigation Animation back into Navigation Compose itself.

This means all of the support for setting custom transitions that existed in AnimatedNavHost is directly supported in NavHost.

This is available in snapshot builds right now and will be released as part of Navigation 2.7.0-alpha01. Note that as part of this, Navigation Compose now depends on Compose 1.5.

We'll be publishing a deprecation guide once Navigation 2.7.0-alpha01 is released, but it'll be essentially the inverse of the migration guide with no other API changes required if you're already using the latest Accompanist alpha (0.31.2-alpha).