Move Animation APIs from Accompanist back into Jetpack Navigation [197140101]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 18, 2021 08:31PM

As of compose 1.0.1 many of the Compose Animation APIs are still @Experimental.

Because of AndroidX internal restrictions, modules cannot depend on experimental APIs from other modules.

In the interest of providing a solution for Navigation with custom Compose Animations as soon as possible, we opted to provide a new module in Accompanist Navigation. Once all the required animation APIs become stable, which is planned as part of Compose 1.1.0, we will move the implementation back into the Jetpack Navigation library from Accompanist Navigation Animation.

For more details, see the Animations in Navigation Compose blog post.

Comments

ti...@gmail.com <ti...@gmail.com> #2Feb 12, 2022 08:03PM

yeah, looks like a bug.

il...@google.com <il...@google.com> #3Feb 14, 2022 05:19PM

I look closer and now I'm not sure what is the best behavior. Currently keys() does what javadoc says "all keys contained in this SavedStateHandle". Technically, before first onSaveInstanceState keys corresponding to SavedStateProviders aren't in the SavedStateHandle. However I can see, that SavedStateProvide is kinda promise that value will be in the SavedStateHandle in future.

I think we can do smth like:

fun keys() = mRegular.keySet() + mSavedStateProviders.keySet()

Ian, what do you think?

ti...@gmail.com <ti...@gmail.com> #4Aug 2, 2022 04:09PM

Yes, I think having keys() return the combined set as recommended in comment#3 makes a lot of sense and ensures that the set of keys is the same both before and after the state is actually saved.

ru...@gmail.com <ru...@gmail.com> #5Jan 25, 2023 06:32AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit da54c9d83ca533316fa95591a59b33eb2903a1e6
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Dec 04 16:39:50 2020

SavedStateHandle#keys() now returns keys of Providers and LiveData-s

Fixes: 174713653
Test: improved SavedStateHandleTest#testKeySet
Change-Id: Ib586038aabe6601cd95e0d74af67f031439cf6ee

M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandle.java

https://android-review.googlesource.com/1517919

k8...@gmail.com <k8...@gmail.com> #6Mar 21, 2023 02:11PM

seriously no update on what is stable?

il...@google.com <il...@google.com> #7Mar 21, 2023 04:16PM

AnimatedContent is, as of today, still experimental and still cannot be used in androidx.navigation.

As soon as it is stable, we can kick off this work.

jb...@google.com <jb...@google.com> May 8, 2023 06:11PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #8May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit a3386225c952c42b7c687771ea31642d76f4df66
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 11:26:59 2023

Add Preview support in animated NavHost

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Change-Id: I7b017913d96e31785f16eb66534321d05f29b53d

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2584844

ap...@google.com <ap...@google.com> #9May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 256f919c6b8d579bc55e19d829aed438422f463b
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 10:48:32 2023

Migrate accompanist NavHost and NavController into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavHost and NavController now supports navigating in compose with Animations."
Change-Id: Ica95e794ef1794df4d1bdb38719b55624f832868

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2584843

ap...@google.com <ap...@google.com> #10May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023

Migrate accompanist NavGraphBuilder into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt

https://android-review.googlesource.com/2584842

ap...@google.com <ap...@google.com> #11May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 895c4bb35ee11fe1c54f538699a845ddfaf7e2eb
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 13:14:10 2023

Migrate accompanist ComposeNavigator into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "ComposeNavigator now supports Destinations with Animations."
Change-Id: Ie33b4c2da53ff6c89494332a06be8123be67e879

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt

https://android-review.googlesource.com/2584841

ap...@google.com <ap...@google.com> #12May 11, 2023 04:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 169254301b8aad0454c253a65abff7bf174ba164
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 11:11:42 2023

Bump compose version in navigation-compose

Bump from 1.0.1 to ToT project dependency. Project dependency because compose is currently in alpha.

Test: n/a
Bug: 197140101
Relnote: "navigation-compose has bumped compose dependency to use latest compose dependency"
Change-Id: Ide442548636637c2b75d46ef99c9913b0ebb60b8

M navigation/navigation-compose/build.gradle

https://android-review.googlesource.com/2584840

il...@google.com <il...@google.com> #13May 11, 2023 11:12PM

Marked as fixed.

Now that AnimatedContent is stable, we were able to move the code from Accompanist Navigation Animation back into Navigation Compose itself.

This means all of the support for setting custom transitions that existed in AnimatedNavHost is directly supported in NavHost.

This is available in snapshot builds right now and will be released as part of Navigation 2.7.0-alpha01. Note that as part of this, Navigation Compose now depends on Compose 1.5.

We'll be publishing a deprecation guide once Navigation 2.7.0-alpha01 is released, but it'll be essentially the inverse of the migration guide with no other API changes required if you're already using the latest Accompanist alpha (0.31.2-alpha).