IssueTracker

This doesn't seem desirable as it likely diverges the command line and within-studio builds

I do not think we add them. I cannot see them being passed to Gradle.

Am I looking at the right thing?

cmw: Thoughts?

I am going to downgrade the priority a bit. Let me know if it is something we need to fix quickly.

Relevant issues: http://b/264933295

There is a fix in the Gradle TAPI (https://github.com/gradle/gradle/commit/731d68fda4807f08cd10dcffa18db0947165ad22) and Studio is already on that version. We should investigate if Studio can use this API when launching the Gradle daemon.

This issue was already addressed in the platform by the following commit which will be present on studio after merging the 233.6745, and is invoking the new exposed TAPI API method, as pointed out on comment #8. I validated those changes on my end but also created a integration test on the platform side to add coverage.

Regarding comment #6, to be able to check which system properties end up being present into Gradle build the best way I found is to create a task that prints them, using the same approach for the integration test. Here are the differences:

• Before:

{idea.active=true, java.specification.version=17, kotlinx.coroutines.debug=off, sun.jnu.encoding=UTF-8, java.class.path=/Users/vmadalin/Desktop/MyApplication3/.gradle/wrapper/dists/gradle-8.2-bin/bbg7u40eoinfdyxsxr3z4i7ta/gradle-8.2/lib/gradle-launcher-8.2.jar, java.vm.vendor=JetBrains s.r.o., sun.arch.data.model=64, idea.vendor.name=JetBrains, user.variant=, java.vendor.url=https://openjdk.java.net/, user.timezone=Europe/London, idea.no.launcher=false, swing.bufferPerWindow=true, java.vm.specification.version=17, os.name=Mac OS X, apple.laf.useScreenMenuBar=true, user.country=001, sun.java.launcher=SUN_STANDARD, idea.initially.ask.config=true, sun.boot.library.path=/Users/vmadalin/Develop/studio-main/prebuilts/studio/jdk/jdk17/mac-arm64/Contents/Home/lib, sun.java.command=org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.2, http.nonProxyHosts=local|*.local|169.254/16|*.169.254/16, jdk.debug=release, sun.cpu.endian=little, user.home=/Users/vmadalin, user.language=en, idea.config.path=../config/idea, java.specification.vendor=Oracle Corporation, idea.cycle.buffer.size=1024, java.version.date=2023-08-24, java.home=/Users/vmadalin/Develop/studio-main/prebuilts/studio/jdk/jdk17/mac-arm64/Contents/Home, io.netty.allocator.numHeapArenas=1, file.separator=/, java.vm.compressedOopsMode=Zero based, line.separator=
, java.vm.specification.vendor=Oracle Corporation, java.specification.name=Java Platform API Specification, jdk.attach.allowAttachSelf=, intellij.debug.agent=true, idea.is.internal=true, jbr.virtualization.information=No virtualization detected, io.netty.allocator.numDirectArenas=1, idea.max.intellisense.filesize=2500, sun.management.compiler=HotSpot 64-Bit Tiered Compilers, ftp.nonProxyHosts=local|*.local|169.254/16|*.169.254/16, fus.internal.test.mode=true, java.runtime.version=17.0.9+0-17.0.9b1000.46-11084592, user.name=vmadalin, javax.swing.rebaseCssSizeMap=true, io.netty.allocator.useCacheForAllThreads=false, path.separator=:, os.version=14.1.1, java.runtime.name=OpenJDK Runtime Environment, io.netty.allocator.cacheTrimIntervalMillis=600000, jdk.module.illegalAccess.silent=true, file.encoding=UTF-8, jnidispatch.path=/Users/vmadalin/Library/Caches/JNA/temp/jna12105942759451179043.tmp, idea.popup.weight=heavy, java.vm.name=OpenJDK 64-Bit Server VM, jna.platform.library.path=/usr/lib:/usr/lib, java.vendor.version=JBR-17.0.8.1+7-1000.32-jcef, jna.loaded=true, idea.debug.mode=true, java.vendor.url.bug=https://bugreport.java.com/bugreport/, java.io.tmpdir=/var/folders/cr/qt756jc149zbg6q6wrlmj8s400zw33/T/, idea.version=2023.2.5, java.version=17.0.9, jboss.modules.system.pkgs=com.intellij.rt, java.util.concurrent.ForkJoinPool.common.threadFactory=com.intellij.concurrency.IdeaForkJoinWorkerThreadFactory, user.dir=/Users/vmadalin/IdeaProjects/untitled4, os.arch=aarch64, java.vm.specification.name=Java Virtual Machine Specification, idea.jre.check=true, idea.system.path=../system/idea, io.netty.serviceThreadPrefix=Netty , idea.dynamic.classpath=false, native.encoding=US-ASCII, java.library.path=/Users/vmadalin/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:., java.vm.info=mixed mode, java.vendor=JetBrains s.r.o., java.vm.version=17.0.9+0-17.0.9b1000.46-11084592, io.netty.processId=53943, java.rmi.server.hostname=127.0.0.1, sun.io.unicode.encoding=UnicodeBig, java.rmi.server.disableHttp=true, idea.max.content.load.filesize=20000, library.jansi.path=/Users/vmadalin/Desktop/MyApplication3/.gradle/native/jansi/1.18/osx, javax.swing.JTree.excludeAccessibleChildrenFromClosedNodes=true, io.netty.machineId=28:f0:76:ff:fe:16:65:0e, socksNonProxyHosts=local|*.local|169.254/16|*.169.254/16, java.class.version=61.0, idea.platform.prefix=Idea}

• After:

{java.specification.version=17, sun.jnu.encoding=UTF-8, sun.arch.data.model=64, java.vendor.url=https://openjdk.java.net/, sun.boot.library.path=/Users/vmadalin/Develop/studio-main/prebuilts/studio/jdk/jdk17/mac-arm64/Contents/Home/lib, sun.java.command=org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.2, jdk.debug=release, java.specification.vendor=Oracle Corporation, java.version.date=2023-10-17, java.home=/Users/vmadalin/Develop/studio-main/prebuilts/studio/jdk/jdk17/mac-arm64/Contents/Home, file.separator=/, java.vm.compressedOopsMode=Zero based, line.separator=
, java.vm.specification.vendor=Oracle Corporation, java.specification.name=Java Platform API Specification, jbr.virtualization.information=No virtualization detected, sun.management.compiler=HotSpot 64-Bit Tiered Compilers, java.runtime.version=17.0.9+0-17.0.9b1000.46-11084592, user.name=vmadalin, file.encoding=UTF-8, java.io.tmpdir=/var/folders/cr/qt756jc149zbg6q6wrlmj8s400zw33/T/, idea.version=2023.2.5, java.version=17.0.9, java.vm.specification.name=Java Virtual Machine Specification, native.encoding=US-ASCII, java.library.path=/Users/vmadalin/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:., java.vendor=JetBrains s.r.o., sun.io.unicode.encoding=UnicodeBig, library.jansi.path=/Users/vmadalin/Desktop/MyApplication3/.gradle/native/jansi/1.18/osx, socksNonProxyHosts=local|*.local|169.254/16|*.169.254/16, idea.active=true, java.class.path=/Users/vmadalin/Desktop/MyApplication3/.gradle/wrapper/dists/gradle-8.2-bin/bbg7u40eoinfdyxsxr3z4i7ta/gradle-8.2/lib/gradle-launcher-8.2.jar, java.vm.vendor=JetBrains s.r.o., user.variant=, user.timezone=Europe/London, java.vm.specification.version=17, os.name=Mac OS X, user.country=001, sun.java.launcher=SUN_STANDARD, http.nonProxyHosts=local|*.local|169.254/16|*.169.254/16, sun.cpu.endian=little, user.home=/Users/vmadalin, user.language=en, ftp.nonProxyHosts=local|*.local|169.254/16|*.169.254/16, path.separator=:, os.version=14.1.1, java.runtime.name=OpenJDK Runtime Environment, java.vm.name=OpenJDK 64-Bit Server VM, java.vendor.url.bug=https://bugreport.java.com/bugreport/, user.dir=/Users/vmadalin/IdeaProjects/untitled4, os.arch=aarch64, java.vm.info=mixed mode, java.vm.version=17.0.9+0-17.0.9b1000.46-11084592, java.class.version=61.0}

Having said that, I'm going to mark this ticket as fixed since those changes are going to land at certain point in AS J.