Room multimap LEFT JOIN nullability [201946438]

Fixed

Bug

Status Update

No update yet.

Description

aa...@gmail.com

created issue #1

Oct 4, 2021 02:36PM

Artifact used : Room Version used: 2.4.0-alpha05 Devices/Android versions reproduced on: Emulator

This is more of a feature request, but trying out the new multimap feature I'm having issues with LEFT JOIN queries.

Take this example from the release notes (One-to-Many relationship):

@Query("SELECT * FROM Artist JOIN Album ON Artist.id = Album.artistId")
fun getArtistAndAlbums(): Map<Artist, List<Album>>

Let's say we want all artists, regardless if they have any albums. So we change the query to use a LEFT JOIN:

@Query("SELECT * FROM Artist LEFT JOIN Album ON Artist.id = Album.artistId")
fun getArtistAndAlbums(): Map<Artist, List<Album>>

This won't work if we have an Artist without albums, if Album doesn't have any nullable fields. Because the current implementation will always try and generate an Album object.

Is it possible to let Room return an empty list of 'Albums' in that case? Or Map<Artist, List<Album>?>?

Thanks for your time!

Comments

au...@google.com <au...@google.com> Oct 6, 2021 08:29PM

Assigned to da...@google.com.

el...@google.com <el...@google.com> #2Oct 6, 2021 09:42PM

Reassigned to el...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 1b9ae441be4de3443b138e789c85722bba29c356
Author: Clara F <clarafok@google.com>
Date: Mon Mar 14 15:26:56 2022

[GH] Add room-paging-guava module to Room

Create module for integrating Guava into Room Paging

Test: n/a
Bug: 203666906

This is an imported pull request from

https://github.com/androidx/androidx/pull/337.

Resolves #337

Relnote: "Added a new artifact, room-paging-guava, for ListenableFuturePagingSource in
room-paging."

Github-Pr-Head-Sha: f62df108d6d5dd765c43b1e75472ddd0a097f9de
GitOrigin-RevId: 8c86aaa8e3a856614cbdccabe07c0d658efb0407
Change-Id: Ie14a1beef5d3b7ba07f3acc3fdd1f7bfc6fd1b9e

A room/room-paging-guava/src/androidTest/AndroidManifest.xml
A room/room-paging-guava/api/public_plus_experimental_current.txt
M settings.gradle
M docs-tip-of-tree/build.gradle
A room/room-paging-guava/api/restricted_current.txt
A room/room-paging-guava/api/res-current.txt
A room/room-paging-guava/src/main/AndroidManifest.xml
A room/room-paging-guava/api/current.txt
A room/room-paging-guava/build.gradle

https://android-review.googlesource.com/2025245

aa...@gmail.com <aa...@gmail.com> #3Oct 11, 2021 10:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit eb60980fbbeb3a9d824e721969a54db902c44857
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:08:03 2022

[GH] Add room-paging-rxjava3 module to Room

Test: n/a
Bug: 203666906
Relnote: Integrating rxjava3 support in Room Paging

This is an imported pull request from

https://github.com/androidx/androidx/pull/339.

Resolves #339
Github-Pr-Head-Sha: 274be4dcfc6f40861b476638c9671503e28129d4
GitOrigin-RevId: f081e641921b7dd64f1bba5800b4395074f902e1

Change-Id: I00d8884025aa4263a96dc509ccb8e303b53beeb8

M settings.gradle
A room/room-paging-rxjava3/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava3/api/restricted_current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava3/api/current.txt
A room/room-paging-rxjava3/build.gradle
A room/room-paging-rxjava3/src/main/AndroidManifest.xml
A room/room-paging-rxjava3/api/public_plus_experimental_current.txt
A room/room-paging-rxjava3/api/res-current.txt

https://android-review.googlesource.com/2027363

el...@google.com <el...@google.com> Nov 4, 2021 12:12AM

Marked as fixed.

ap...@google.com <ap...@google.com> #4Nov 4, 2021 12:13AM

Project: platform/frameworks/support
Branch: androidx-main

commit 41a1d4f8677c57db934d37bb0cd8db9d3f3aae6c
Author: Clara F <clarafok@google.com>
Date: Tue Mar 15 19:10:36 2022

[GH] Add room-paging-rxjava2 module to Room

Test: n/a
Bug: 203666906
Relnote: "Added new artifact room-paging-rxjava2 for rxjava2 support in Room Paging"

This is an imported pull request from

https://github.com/androidx/androidx/pull/338.

Resolves #338
Github-Pr-Head-Sha: f8c5c6f04217e43bbc4a78b9715deb920b830fa3
GitOrigin-RevId: 1dbf1e202286c42fc34c89a808d8c421fa1303af

Change-Id: I88f076392f1917c2fec52d3bd58d91e73b12a53b

A room/room-paging-rxjava2/api/current.txt
A room/room-paging-rxjava2/api/restricted_current.txt
M settings.gradle
A room/room-paging-rxjava2/api/res-current.txt
M docs-tip-of-tree/build.gradle
A room/room-paging-rxjava2/src/main/AndroidManifest.xml
A room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/androidTest/AndroidManifest.xml
A room/room-paging-rxjava2/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2027364

mr...@crossway.org <mr...@crossway.org> #5Dec 2, 2021 08:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2f45502b3d448965f0e52067e8b39108708d1faf
Author: clarafok <clarafok@google.com>
Date: Mon Apr 11 15:50:07 2022

Implement LimitOffsetListenableFuturePagingSource

An abstract implementation of ListenableFuturePagingSource to be
implemented by Room. Supports Guava operations through ListenableFuture.

Test: ./gradlew room:room-paging-guava:cC
Bug: 203666906

Change-Id: I3ec746a072d28e856018d03aeb08931a8d42fa93

A room/room-paging-guava/src/main/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSource.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
A room/room-paging-guava/src/androidTest/kotlin/androidx/room/paging/guava/LimitOffsetListenableFuturePagingSourceTest.kt
M room/room-paging/build.gradle
M room/room-paging-guava/build.gradle
M room/room-paging/src/main/kotlin/androidx/room/paging/util/RoomPagingUtil.kt

https://android-review.googlesource.com/2037356

mr...@crossway.org <mr...@crossway.org> #6Dec 2, 2021 09:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date: Thu Apr 28 17:05:24 2022

Hook up room-paging-guava to room-compiler

Test: ./gradlew :room:room-compiler:test
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/integration-tests/kotlintestapp/build.gradle
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-paging-guava/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java

https://android-review.googlesource.com/2067883