Fixed
Status Update
Comments
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 0ceecba883de1438896a21bd94193ad925b1ba76
Author: repo sync -c -j8 <shiufai@google.com>
Date: Mon Mar 29 15:38:46 2021
Ensure Session's lifecycle observer can be added first before Screens.
Bug: 183696617
Relnote: Fixes an issue where `ON_DESTORY` on a `Session` is observed after a `Screen`'s `ON_DESTROY`
Test: ./gradlew :car:app:app:test
Change-Id: I52e01fe22e4e6dc8130735ebae49a1575928ee5a
M car/app/app/src/main/java/androidx/car/app/CarAppService.java
M car/app/app/src/main/java/androidx/car/app/Session.java
M car/app/app/src/test/java/androidx/car/app/CarAppServiceTest.java
https://android-review.googlesource.com/1656245
Branch: androidx-main
commit 0ceecba883de1438896a21bd94193ad925b1ba76
Author: repo sync -c -j8 <shiufai@google.com>
Date: Mon Mar 29 15:38:46 2021
Ensure Session's lifecycle observer can be added first before Screens.
Bug: 183696617
Relnote: Fixes an issue where `ON_DESTORY` on a `Session` is observed after a `Screen`'s `ON_DESTROY`
Test: ./gradlew :car:app:app:test
Change-Id: I52e01fe22e4e6dc8130735ebae49a1575928ee5a
M car/app/app/src/main/java/androidx/car/app/CarAppService.java
M car/app/app/src/main/java/androidx/car/app/Session.java
M car/app/app/src/test/java/androidx/car/app/CarAppServiceTest.java
Description
Component used: SavedState
Version used: 1.1.0
When unconditionally calls even if there are no components that were registered to save their state.
SavedStateRegistry
is asked toperformSave
, itputBundle
This means that in cases like Fragments, where the Fragment itself has a
SavedStateRegistry
and the fragment's view has its ownSavedStateRegistry
, the overall saved state is increased doubly so (at what seems like a cost of 0.2KB per fragment).While not a significant part of the total saved state, this can add up with deep stacks.