Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
So there does seem to be a bug in Navigation that causes this to fail.
When it navigates with popUpTo and removes SecondFragment, that removal in fragment is set for a frame later and before it is actually removed the navigate call in the onViewCreated of SecondFragment enqueues another call to add it back. But we still need to destroy SecondDetailFragment which ends up marking the NavBackStackEntry associated with SecondFragment as complete before navigation has received the call from the fragment that it has been added back. So by the time it hits this check, the SecondFragment is in the correct state, but Navigation has no way of referencing it so it assumes that it is not associated with an entry.
But this is not the way this type of situation should be implemented. Instead of having the destinations as part of the NavGraph, they should:
- be managed by the childFragmentManager of
SecondFragment. So instead of going back toSecondFragmentjust to go somewhere else, each of the fragments take the entire content ofSecondFragmentand are swapped out. - for some sort of a/b testing, set different graphs in the Activity. The graphs would keep the same
SecondFragmentid, but swap out the names and then you choose the correct graph based on the condition.
Description
Component used: SavedState
Version used: 1.1.0
When
SavedStateRegistryis asked toperformSave, itputBundleThis means that in cases like Fragments, where the Fragment itself has a
SavedStateRegistryand the fragment's view has its ownSavedStateRegistry, the overall saved state is increased doubly so (at what seems like a cost of 0.2KB per fragment).While not a significant part of the total saved state, this can add up with deep stacks.