Room should also provide the LF and RX variants of PagingSource [203666906]

Fixed

Feature Request

Status Update

No update yet.

Description

du...@google.com

created issue #1

Oct 20, 2021 04:41PM

Add new artifacts for room-paging-rx2/3 and -guava.

Comments

du...@google.com <du...@google.com> Mar 14, 2022 10:08PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Mar 22, 2022 05:19PM

For Kotlin 2.0 and KSP 2.0 the Cannot change attributes of configuration ':composeApp:debugFrameworkIosX64' after it has been locked for mutation really seems like a KSP issue. You should file a bug in their repository with a sample app if possible.

If you downgrade to Kotlin 1.9 then things 'should' work, there are example apps out there with such configuration, like the following one: https://github.com/realityexpander/KMP_Room/tree/main

ap...@google.com <ap...@google.com> #3Mar 23, 2022 09:01PM

Yes this does seem like a KSP issue however it only starts happening when room is added to the project. As the template project compiles just fine.

Will try to use the example provided by you to check if it fixes the issue.

ap...@google.com <ap...@google.com> #4Mar 24, 2022 04:53PM

Note that this issue happens when applying the Compose, KSP and Room Plugin together in Kotlin 2.0.x, the workaround for now is to not use the Room Gradle Plugin and instead specify the schema location vis KSP arguments:

// In the build.gradle
ksp {
    arg("room.schemaLocation", "${projectDir}/schemas")
}

cl...@google.com <cl...@google.com> Apr 12, 2022 06:38PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #5Apr 14, 2022 05:26PM

Hi, I encountered a similar problem and was able to resolve it by updating the dependencies

room = "2.7.0-alpha08"
ksp = "2.0.20-1.0.25"

compose-plugin = "1.6.11"
kotlin = "2.0.20"

ap...@google.com <ap...@google.com> #6May 6, 2022 01:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 76e8c1ef8e3f90ecb1376ec0d0dc418990b7e515
Author: Clara Fok <clarafok@google.com>
Date: Thu Apr 28 17:05:24 2022

Hook up room-paging-guava to room-compiler

Test: ./gradlew :room:room-compiler:test
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: Iaa2e7b542b4398f2e364c0b68896c046589e9a09

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/ListenableFuturePagingSourceQueryResultBinderProvider.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M room/integration-tests/kotlintestapp/build.gradle
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/MultiTypedPagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-paging-guava/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/ItemStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetListenableFuturePagingSource.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/PagingSourceQueryResultBinderProvider.kt
M testutils/testutils-common/src/main/java/androidx/testutils/FilteringExecutor.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
A room/room-compiler/src/test/data/common/input/ListenableFuturePagingSource.java

https://android-review.googlesource.com/2067883

ap...@google.com <ap...@google.com> #7May 12, 2022 11:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit a5a856d88a480cbb1d4364f6b3d64ff450411cfd
Author: clarafok <clarafok@google.com>
Date: Wed May 11 13:52:19 2022

Implement room-paging-rxjava3 LimitOffsetRxPagingSource

Test: ./gradlew room:room-paging-rxjava3:cC
Bug: 203666906
Change-Id: I0127af74e4ec38c0570f56a5783ec2157f9bb9fc

A room/room-paging-rxjava3/src/main/java/androidx/room/paging/rxjava3/LimitOffsetRxPagingSource.kt
A room/room-paging-rxjava3/src/androidTest/kotlin/androidx/room/paging/rxjava3/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava3/build.gradle

https://android-review.googlesource.com/2094107

ap...@google.com <ap...@google.com> #8May 13, 2022 05:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit c7b01e966accae484bb1dd081e3fa5f3f38047fc
Author: clarafok <clarafok@google.com>
Date: Thu May 12 15:28:45 2022

Hook up rxjava3 LimitOffsetRxPagingSource to room-compiler

Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Bug: 203666906
Change-Id: I57099d83a8c845263c5031990de3124971ac2363

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
A room/room-compiler/src/test/data/common/input/Rx3PagingSource.java
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx3PagingSource.java
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava3PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx3PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2097220

ap...@google.com <ap...@google.com> #9May 13, 2022 11:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit c4782c289e754747e1a98a28e2700836d78d7578
Author: clarafok <clarafok@google.com>
Date: Fri May 13 14:12:02 2022

Implement rxjava2 LimitOffsetRxPagingSource

Test: ./gradlew room:room-paging-rxjava2:cC
Bug: 203666906
Change-Id: Iefd883d45b18b032bb3a29d51209fc7de169c1aa

A room/room-paging-rxjava2/src/androidTest/kotlin/androidx/room/paging/rxjava2/LimitOffsetRxPagingSourceTest.kt
M room/room-paging-rxjava2/build.gradle
A room/room-paging-rxjava2/src/main/java/androidx/room/paging/rxjava2/LimitOffsetRxPagingSource.kt

https://android-review.googlesource.com/2098470

ap...@google.com <ap...@google.com> #10May 16, 2022 06:22PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit d1ba57918465b84aa9564074df68d3136a4f8fcd
Author: clarafok <clarafok@google.com>
Date: Fri May 13 16:09:09 2022

Hook up room-paging-rxjava2 to room-compiler

Test: ./gradlew room:room-compiler:test
Test: ./gradlew room:integration-tests:room-testapp-kotlin:cC
Fixes: 203666906
Change-Id: Ic8f07f14491ece38b1296ca71c761511218a65a9

M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/testutil/PagingEntityDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/room-compiler/src/test/data/common/input/Rx2PagingSource.java
A room/room-compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxJava2PagingSourceQueryResultBinderProvider.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
A room/room-compiler/src/test/data/common/input/LimitOffsetRx2PagingSource.java
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/Rx2PagingSourceTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt

https://android-review.googlesource.com/2098475