[AVD] Device fold behavior is frustrating [203793073]

Fixed

Feature Request

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Oct 22, 2021 07:43PM

DESCRIBE THE ISSUE IN DETAIL:

When using a folded (virtual) device, there's a fold icon on the toolbar. Tapping it will give you a fold and unfold icon to tap on, which will fold or unfold the device, respectively. In addition, (and this is where the user experience is frustrating) tapping the fold icon will also open the settings window. This is unnecessary and forces me to close the window each time, without making any changes in it (since all the settings I need are in the toolbar.)

STEPS TO REPRODUCE:
1. Create an 8" foldable AVD
2. Start the 8" foldable AVD
3. Tap the fold icon on the toolbar

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

------------------

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply
all required information.

------------------

Studio Build: 2020.3.1 Patch 3
Version of Gradle Plugin: n/a
Version of Gradle: n/a
Version of Java: n/a
OS: Windows 11 Pro 21H2 22000.258
Android Emulator Version: 30.9.5

2021-10-22 15-39-47.mkv

3.4 MB

Download

Comments

st...@google.com <st...@google.com> Oct 25, 2021 05:29PM

Assigned to an...@google.com.

aa...@google.com <aa...@google.com> Nov 24, 2021 09:18PM

Reassigned to ad...@google.com.

ad...@google.com <ad...@google.com> Mar 18, 2022 08:42PM

Reassigned to yb...@google.com.

bo...@google.com <bo...@google.com> May 11, 2022 06:41PM

Reassigned to hu...@google.com.

is...@google.com <is...@google.com> Oct 8, 2022 08:25AM

Status: New

bo...@google.com <bo...@google.com> Apr 4, 2023 04:09PM

Assigned to bo...@google.com.

bo...@google.com <bo...@google.com> Jun 22, 2023 10:51PM

Marked as fixed.

ca...@google.com <ca...@google.com> #2Sep 27, 2023 11:26PM

Navigation is built with Support Library Fragments so has no access to the FragmentFactory itself. I think we can make some minor changes to FragmentNavigator to make it easy for developers who are using Navigation 1.0 and Fragments 1.1.0 together to call through to their FragmentFactory.

Once Navigation switches to AndroidX (post 1.0), we'll use FragmentFactory directly.

studio64_wtItrWsw0I.mp4

598 KB

Download

ha...@gmail.com <ha...@gmail.com> #3Sep 27, 2023 11:29PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1b215f0d93828286782776b9a12d2387097947f9
Author: Ian Lake <ilake@google.com>
Date: Sun Nov 25 21:45:56 2018

Move Fragment creation to FragmentNavigator

Provide an instantiateFragment() method on
FragmentNavigator which serves as the
centralized place to instantiate new
Fragment instances for FragmentNavigator.

Besides moving this business logic out of
the dumb POJO FragmentNavigator.Destination,
this also provides a future extension point
for integrating in FragmentFactory.

Test: existing tests passes, testapp still works
BUG: 119054429
Change-Id: If60471a704ef77bc35b30838e152a31cde8bc235

M navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilderTest.kt
M navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilder.kt
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/835682

https://goto.google.com/android-sha1/1b215f0d93828286782776b9a12d2387097947f9