[Question] Expected behaviour when using TextView.setTextFuture [211231958]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Dec 20, 2021 10:20AM

Component used: Emoji2 Version used: 1.0.0, 1.0.1 Devices/Android versions reproduced on: API 30 Emulator with Google apis

What is the expected behaviour when using TextView.setTextFuture with text which contains emojis?

At the moment we're seeing plain text that contains emojis be replaced with EmojiSpans which are not compatible with TextView.setTextFuture.

Thread: main, Exception: java.lang.IllegalArgumentException: MetricAffectingSpan can not be set to PrecomputedText.
at androidx.core.text.PrecomputedTextCompat.setSpan(PrecomputedTextCompat.java:5)
at androidx.emoji2.text.EmojiCompat$CompatInternal19.process(EmojiCompat.java:51)
at androidx.emoji2.text.EmojiCompat.process(EmojiCompat.java:12)
at androidx.emoji2.viewsintegration.EmojiInputFilter.filter(EmojiInputFilter.java:8)
at android.widget.TextView.setText(TextView.java:4996)
at android.widget.TextView.setText(TextView.java:4962)
at android.widget.TextView.setText(TextView.java:4937)
at androidx.core.widget.TextViewCompat.setPrecomputedText(TextViewCompat.java:8)
at androidx.appcompat.widget.AppCompatTextView.consumeTextFutureAndSetBlocking(AppCompatTextView.java:3)
at androidx.appcompat.widget.AppCompatTextView.onMeasure(AppCompatTextView.java:1)

Our workaround is to process all text and check for instances of MetricAffectingSpan, if an instance is found we replace setTextFuture with setText

Comments

ig...@irl.com <ig...@irl.com> #2Dec 23, 2021 08:57AM

This is with the latest CameraX 1.1.0-beta03.

se...@google.com <se...@google.com> #3Jan 4, 2022 08:33PM

Reassigned to se...@google.com.

Thanks for reporting the issue. We will look into the bug and update here soon.

se...@google.com <se...@google.com> #4Mar 14, 2022 10:47PM

We will catch this exception while clarify what is going wrong in the meantime.

Hi Shuzen
We've got this public issue from developers where querying CameraCharacteristics.CONTROL_ZOOM_RATIO_RANGE seems to cause crash on some cheap devices in India.
Is this because these cheap devices do not pass CTS ?

ap...@google.com <ap...@google.com> #5Mar 17, 2022 12:10AM

Marked as fixed.

Is it possible to get a bugreport from those devices?

x3...@gmail.com <x3...@gmail.com> #6Jun 27, 2022 03:41PM

One of our project members can potentially get their hands on one of these devices but we currently don't have access to one. It's probably a lot easier for you folks to get one since we can't really afford to buy phones.

Ideally you could get some of these cheap Indian/Chinese phones for the CameraX device lab.

This Jio device is Google certified but in my experience most non-Pixel phones are pretty far from genuinely passing the CTS and have a lot of failures that aren't just flaky tests. I'm not sure how they get their devices certified but apparently there are waivers. Google doesn't do the certification but rather third parties do, and it's possible they're simply cutting corners or acting in a corrupt way. Usually there are a lot of failing CTS Camera tests. It doesn't help that a lot of those CTS Camera tests are super flaky without a high quality device and a proper testing setup with proper lightning, etc. They can still fail from flakiness even with that setup. Probably why they can so easily skip meeting these requirements, since the certification companies are used to flaky / failing tests and aren't really doing their job properly.

se...@google.com <se...@google.com> #7Jun 27, 2022 03:50PM

We have a project member in India who could buy one of these phones and since they're so cheap (around $80 or something) I could cover that but in general I don't really want to be buying phones we don't really need.

kc...@gmail.com <kc...@gmail.com> #8Nov 10, 2023 07:05PM

Hi ,

Thanks for the informations. You are right, it's possible that the devices are not genuinely passing the CTS.
Regardless, we will fix this in CameraX. (Thanks for letting us know BTW)
We will also try to get one of these device to test if there are other issues.

Scott

kc...@gmail.com <kc...@gmail.com> #9Nov 10, 2023 07:06PM

This crash looks similar to the one in b/216667482. We might want to do a similar workaround here.