Deep linking with multiple nested nav graphs doesn't correctly create the full backstack [214383060]

Fixed

Bug

Status Update

No update yet.

Description

el...@atomicmedia.co.uk

created issue #1

Jan 13, 2022 06:12PM

Component used: Navigation
Version used: 2.4.0-rc01
Devices/Android versions reproduced on:
Pixel 6 / Android 12

In the example project I have the following nested nav graph structure:

nav_graph{ startDestination=home
home {...}
list { startDestination=leaderboard
leaderboard
exampleNestedGraph { startDestination=exampleFragment
exampleFragment - deepLink="

example.com/user/{userName}"
userProfile - deepLink="

example.com/user/{userName}/details"
}
}
form {...}
}

Following the deep link:

example.com/user/Profile%202/details deep links to the userProfile Fragment as expected.

Then clicking back pops to the exampleFragment

Expected: Clicking back again takes the user to the leaderboard fragment, then clicking back a final time takes the user back to the home fragment.

Actual: Clicking back takes the user to the home fragment, skipping the leaderboard fragment.

I've also updated the bottomNavView_DeepLink_HandlesIntent_BackGoesToList test to test this case

It looks like this was introduced with

https://cs.android.com/androidx/platform/frameworks/support/+/9fc6ccd6e1759d75a8b72f49cedd359e87ba2f99

screen-20220113-175001.mp4

19 MB

Download

NavigationAdvancedSample.zip

366 KB

Download

Comments

jb...@google.com <jb...@google.com> Jan 21, 2022 01:23AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jan 25, 2022 09:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e005db789e4c6b6c75fb8ca03a0c4e326868fb91
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 02 14:20:41 2020

Move nav_default animation out of animation sets

All of the nav_default animations are simple fades and do not need to be
inside of a animation set. Moving them out also ensures that if they are
placed in an additional set (i.e. like the new fragment state manager
does to listen for when the animation finishes) they will not flash.

Bug: 167430145
Test: Tested in sample app
Change-Id: I071e922a52301863ba2461ff05b60bb64566430c

M navigation/navigation-ui/src/main/res/anim/nav_default_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_exit_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_exit_anim.xml

https://android-review.googlesource.com/1418719

jb...@google.com <jb...@google.com> #3Jan 25, 2022 09:20PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1e9ed84322fddd9228df1f96bc8cb76748e0a4fe
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 11 15:58:27 2020

Add nav default animator resources

Animators are recommeneded over Animations for doing effects in fragment
and Navigation. We need to make default animator resources for
Navigation.

Test: Tested in sample apps
Bug: 167430145
Change-Id: I904d78268d8b8574c799ae1b0f5887e518fdb5f6

M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/navigation-ui/src/main/res-public/values/public_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_exit_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_exit_anim.xml

https://android-review.googlesource.com/1424849

wb...@gmail.com <wb...@gmail.com> #4Feb 2, 2022 09:13AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9c1b0badcfb5fa6d11c1ec64c224c6be08b9211d
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 11 16:18:20 2020

Fix resource tracking for navigation UI

We need to move the public navigation UI resources from the legacy
res-public director to the supported values/public.xml file to ensure
that the resources are being properly tracked.

This change also marks the default nav animations are deprecated in
favor of animators.

Test: Tested in sample apps
Bug: 167430145
Change-Id: Ife64d85b280d6ed1161efe503885f807066b710c

M navigation/navigation-ui/api/res-current.txt
D navigation/navigation-ui/src/main/res-public/values/public_anim.xml
A navigation/navigation-ui/src/main/res/values/public.xml

https://android-review.googlesource.com/1419330

jb...@google.com <jb...@google.com> #5Feb 2, 2022 04:59PM

This is fixed and will be available in the Navigation 2.3.1 release.

wb...@gmail.com <wb...@gmail.com> #6Feb 3, 2022 07:40AM

Project: platform/frameworks/support
Branch: snap-temp-L34200000699848945

commit 9a352b5633b8042fdb9e3faede5b2ed09105c4f2
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 11 15:58:27 2020

Add nav default animator resources

Animators are recommeneded over Animations for doing effects in fragment
and Navigation. We need to make default animator resources for
Navigation.

Test: Tested in sample apps
Bug: 167430145
Change-Id: I904d78268d8b8574c799ae1b0f5887e518fdb5f6
(cherry picked from commit 1e9ed84322fddd9228df1f96bc8cb76748e0a4fe)

M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/navigation-ui/src/main/res-public/values/public_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_exit_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_exit_anim.xml

https://android-review.googlesource.com/1436744

Issue 214383060