Deep linking with multiple nested nav graphs doesn't correctly create the full backstack [214383060]

Fixed

Bug

Status Update

No update yet.

Description

el...@atomicmedia.co.uk

created issue #1

Jan 13, 2022 06:12PM

Component used: Navigation
Version used: 2.4.0-rc01
Devices/Android versions reproduced on:
Pixel 6 / Android 12

In the example project I have the following nested nav graph structure:

nav_graph{ startDestination=home
home {...}
list { startDestination=leaderboard
leaderboard
exampleNestedGraph { startDestination=exampleFragment
exampleFragment - deepLink="

example.com/user/{userName}"
userProfile - deepLink="

example.com/user/{userName}/details"
}
}
form {...}
}

Following the deep link:

example.com/user/Profile%202/details deep links to the userProfile Fragment as expected.

Then clicking back pops to the exampleFragment

Expected: Clicking back again takes the user to the leaderboard fragment, then clicking back a final time takes the user back to the home fragment.

Actual: Clicking back takes the user to the home fragment, skipping the leaderboard fragment.

I've also updated the bottomNavView_DeepLink_HandlesIntent_BackGoesToList test to test this case

It looks like this was introduced with

https://cs.android.com/androidx/platform/frameworks/support/+/9fc6ccd6e1759d75a8b72f49cedd359e87ba2f99

screen-20220113-175001.mp4

19 MB

Download

NavigationAdvancedSample.zip

366 KB

Download

Comments

jb...@google.com <jb...@google.com> Jan 21, 2022 01:23AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jan 25, 2022 09:19PM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

jb...@google.com <jb...@google.com> #3Jan 25, 2022 09:20PM

Marked as fixed.

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

wb...@gmail.com <wb...@gmail.com> #4Feb 2, 2022 09:13AM

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

jb...@google.com <jb...@google.com> #5Feb 2, 2022 04:59PM

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

wb...@gmail.com <wb...@gmail.com> #6Feb 3, 2022 07:40AM

This has been fixed and will be available in navigation 2.6.0-alpha08

Issue 214383060