Fixed
Status Update
Comments
as...@google.com <as...@google.com>
ca...@google.com <ca...@google.com> #2
Duplicate of internal issue
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 45a1bc4a15b5b10d0635d79fb55df2aced5a2a4a
Author: Alan Viverette <alanv@google.com>
Date: Thu May 14 18:06:25 2020
Only apply DayNight changes to Activity-hosted delegates
Dialogs can't receive configuration change callbacks, so there's no point
in updating their configurations. They'll have to be destroyed and re-
created by their host activities. Also, dialogs were eating the changes.
Fixes: 155379937
Test: NightModeForegroundDialogTestCase and appcompat test suite
Change-Id: Ifa18d9d42268ec8821223942dc6c817ecabbed7f
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeDialogFragment.java
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeForegroundDialogTestCase.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java
it...@gmail.com <it...@gmail.com> #3
I think, sActiveDelegates
meant "live" delegates. Anyway, now there's a mess :(
private static final ArraySet<WeakReference<AppCompatDelegate>> sActivityDelegates;
private static final Object sActivityDelegatesLock;
static void addActiveDelegate(@NonNull AppCompatDelegate delegate);
static void removeActivityDelegate(@NonNull AppCompatDelegate delegate);
private static void removeDelegateFromActives(@NonNull AppCompatDelegate toRemove);
private static void applyDayNightToActiveDelegates();
Source:
it...@gmail.com <it...@gmail.com> #5
Rc02 is work for me, thanks for your work!
ca...@google.com <ca...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 9904f9d7ff46b7c8b186f43453cb4e573c30b201
Author: Vadim Caen <caen@google.com>
Date: Wed Jan 19 17:21:39 2022
Remove PREVIEW_SDK_INT check
Bug: 188897399
Bug: 214835299
Test: SplashScreenTests
Change-Id: I756a8167c407ee8a0a5da883aa60d024f5931455
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt
https://android-review.googlesource.com/1954209
Branch: androidx-main
commit 9904f9d7ff46b7c8b186f43453cb4e573c30b201
Author: Vadim Caen <caen@google.com>
Date: Wed Jan 19 17:21:39 2022
Remove PREVIEW_SDK_INT check
Bug: 188897399
Bug: 214835299
Test: SplashScreenTests
Change-Id: I756a8167c407ee8a0a5da883aa60d024f5931455
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt
Description
androidx.core:core-splashscreen
1.0.0-beta01
Theme.SplashScreen
False
Pixel 4a (5G) (Android 11)
A small number of users are affected by this crash (report via
Crahlytics
) & it seems to be very device-specific (mentioned above).Stacktrace:
The
handleSeamlessEnd
extension method: