SplashScreen - lateinit property platformView has not been initialized [214835299]

Fixed

Bug

core-splashscreen

Status Update

No update yet.

Description

it...@gmail.com

created issue #1

Jan 18, 2022 07:51AM

Artifact used: androidx.core:core-splashscreen
Version used: 1.0.0-beta01
Theme used: Theme.SplashScreen
Crash Reproducible: False
Devices/Android versions reproduced on: Pixel 4a (5G) (Android 11)

A small number of users are affected by this crash (report via Crahlytics) & it seems to be very device-specific (mentioned above).

Stacktrace:

Caused by je.l: lateinit property platformView has not been initialized
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getPlatformView(SplashScreenViewProvider.kt:119)
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getSplashScreenView(SplashScreenViewProvider.kt:125)
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getSplashScreenView(SplashScreenViewProvider.kt:117)
       at androidx.core.splashscreen.SplashScreenViewProvider.getView(SplashScreenViewProvider.java:62)
       at androidx.core.splashscreen.SplashScreen$Impl.setOnExitAnimationListener(SplashScreen.kt:308)
       at androidx.core.splashscreen.SplashScreen.setOnExitAnimationListener(SplashScreen.java:185)
       at com.domain.app.utils.extensions.MiscKt.handleSeamlessEnd(MiscKt.java:207)
       at com.domain.app.ui.activities.main.WhiplashActivity.onCreate(WhiplashActivity.kt:48)
       at android.app.Activity.performCreate(Activity.java:8036)
       at android.app.Activity.performCreate(Activity.java:8016)
       at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3581)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3765)
       at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:102)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2193)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:201)
       at android.os.Looper.loop(Looper.java:288)
       at android.app.ActivityThread.main(ActivityThread.java:7796)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:974)

The handleSeamlessEnd extension method:

fun SplashScreen.handleSeamlessEnd() {
    setOnExitAnimationListener {
        it.iconView.animate()
            .alpha(1f)
            .setDuration(250L)
            .setListener(object : Animator.AnimatorListener {
                override fun onAnimationEnd(animator: Animator?) { it.remove() }
                override fun onAnimationStart(animator: Animator?) {}
                override fun onAnimationCancel(animator: Animator?) {}
                override fun onAnimationRepeat(animator: Animator?) {}
            })
    }
}

Comments

as...@google.com <as...@google.com> Jan 18, 2022 06:17PM

Assigned to ca...@google.com.

ca...@google.com <ca...@google.com> #2Jan 19, 2022 04:13PM

Hi, thanks for report!

Could you attach a bit more information about the heap at this point (e.g. a heap dump) if the leak is not reproducible in trivial project?

it...@gmail.com <it...@gmail.com> #3Jan 20, 2022 06:41AM

Attached!

ca...@google.com <ca...@google.com> #4Jan 20, 2022 10:09AM

I looked into the heap dump, seems like we are not disposing certain snapshots. Current snapshot id seems to be around 42k, but we have 108, 116 and 14123 in invalid SnapshotIdSet for current global snapshot. It is hard to figure out what caused it without repro though, as those snapshots seem to be already collected by GC.

it...@gmail.com <it...@gmail.com> #5Jan 20, 2022 02:26PM

I managed to repro it after a bunch of debugging. The bad news is that it's caused when using Coil within a LazyColumn, so that library is doing something that's causing you to leak snapshots... somehow.

Repro:

Add implementation io.coil-kt:coil-compose:2.1.0 to build.gradle
Add the following composable:

@Composable fun Leak() {
    val lazyListState = rememberLazyListState()
    val items by remember { mutableStateOf(List(10000) { it }) }

    LazyColumn(state = lazyListState) {
        items(items) {
            Box(Modifier.fillMaxWidth()) {
                AsyncImage(
                    model = "https://i.picsum.photos/id/104/200/200.jpg?hmac=3XxEVXVjwoI45-6sum_iMwNZ52GT-SJacVWr4fh4hqI",
                    contentDescription = null
                )
            }
        }
    }
}

Scroll
Memory 📈

ca...@google.com <ca...@google.com> Jan 26, 2022 12:41PM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Feb 1, 2022 04:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit e82b3518094e5451dd4697f31a412c10075b28c5
Author: Andrei Shikov <ashikov@google.com>
Date: Wed Jul 20 23:43:58 2022

Dispose nested snapshots created from transparent snapshots

Adds a flag to transparent snapshots to "manage" wrapped snapshots which forces dispose of the wrapped snapshot whenever transparent one is disposed.
This flag is only enabled for the snapshots taken inside transparent snapshots, fixing memory leaks in certain conditions.

Fixes a minor bug where transparent snapshot wasn't receiving reads from nested snapshots as well.

Fixes: 239603305
Test: SnapshotTests#testNestedWithinTransparentSnapshotDisposedCorrectly

Change-Id: I62eddd279c8cf44b032d852d646c9ba21ad08a39

M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/Snapshot.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/snapshots/SnapshotTests.kt

https://android-review.googlesource.com/2160780