SplashScreen - lateinit property platformView has not been initialized [214835299]

Fixed

Bug

core-splashscreen

Status Update

No update yet.

Description

it...@gmail.com

created issue #1

Jan 18, 2022 07:51AM

Artifact used: androidx.core:core-splashscreen
Version used: 1.0.0-beta01
Theme used: Theme.SplashScreen
Crash Reproducible: False
Devices/Android versions reproduced on: Pixel 4a (5G) (Android 11)

A small number of users are affected by this crash (report via Crahlytics) & it seems to be very device-specific (mentioned above).

Stacktrace:

Caused by je.l: lateinit property platformView has not been initialized
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getPlatformView(SplashScreenViewProvider.kt:119)
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getSplashScreenView(SplashScreenViewProvider.kt:125)
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getSplashScreenView(SplashScreenViewProvider.kt:117)
       at androidx.core.splashscreen.SplashScreenViewProvider.getView(SplashScreenViewProvider.java:62)
       at androidx.core.splashscreen.SplashScreen$Impl.setOnExitAnimationListener(SplashScreen.kt:308)
       at androidx.core.splashscreen.SplashScreen.setOnExitAnimationListener(SplashScreen.java:185)
       at com.domain.app.utils.extensions.MiscKt.handleSeamlessEnd(MiscKt.java:207)
       at com.domain.app.ui.activities.main.WhiplashActivity.onCreate(WhiplashActivity.kt:48)
       at android.app.Activity.performCreate(Activity.java:8036)
       at android.app.Activity.performCreate(Activity.java:8016)
       at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3581)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3765)
       at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:102)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2193)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:201)
       at android.os.Looper.loop(Looper.java:288)
       at android.app.ActivityThread.main(ActivityThread.java:7796)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:974)

The handleSeamlessEnd extension method:

fun SplashScreen.handleSeamlessEnd() {
    setOnExitAnimationListener {
        it.iconView.animate()
            .alpha(1f)
            .setDuration(250L)
            .setListener(object : Animator.AnimatorListener {
                override fun onAnimationEnd(animator: Animator?) { it.remove() }
                override fun onAnimationStart(animator: Animator?) {}
                override fun onAnimationCancel(animator: Animator?) {}
                override fun onAnimationRepeat(animator: Animator?) {}
            })
    }
}

Comments

as...@google.com <as...@google.com> Jan 18, 2022 06:17PM

Assigned to ca...@google.com.

ca...@google.com <ca...@google.com> #2Jan 19, 2022 04:13PM

Only the `argType="reference"` accepts resource IDs (and returns an int that you'd pass to getContext().getString()), so it is working as intended that a "string" type is exactly what you put into your XML. It was important that the build time code gen and the runtime behavior always matches and that was not possible in the general cases - see edge cases such as

https://issuetracker.google.com/issues/111736515 for some background.

Please star

https://issuetracker.google.com/issues/36994900 to track progress towards allowing placeholders in XML files, which would be the recommended way of filling in placeholders at compile time.

it...@gmail.com <it...@gmail.com> #3Jan 20, 2022 06:41AM

Ok thanks, I understand now, I wasn't aware of argType="reference". Anyway I think it is a bit strange that behavior is different if we navigate using safe args gen code (navController.navigate(WebPageFragmentDirections.actionGlobalHomeFragment())) and code without safe args (navController.navigate(R.id.homeFragment)) if the navigation xml file is the same.

ca...@google.com <ca...@google.com> #4Jan 20, 2022 10:09AM

Yes, I think we can make it more explicit that only reference types can have references to other resources.

it...@gmail.com <it...@gmail.com> #5Jan 20, 2022 02:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bb456e84a524d4e5cd241a6a839a1062297b9cf4
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 31 15:46:55 2019

Enforce "reference" types for reference default values

In order to ensure that inflation of a navigation
graph results in the same arguments as Safe Args,
we now enforce usage of the "reference" type for any
argument that has a defaultValue that references
another resource (i.e., @string/app_name, etc).

This makes it much more obvious that the default value
in Safe Args is in the form of R.string.app_name and
any provided override for that should also be in the
form of R.string.some_value.

In these cases, it is expected that developers either
1) Use the ids directly (for example, passing an
R.string to a method that takes a resource id)
2) Specifically call context.getString() with the
resource id they retrieve from their NavArgs instance.

Test: updated NavInflaterTest
Change-Id: I06b8c9a0d1420821b8c0064c22f176788da43d7a
Fixes: 123551990

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
A navigation/runtime/src/androidTest/res/navigation/nav_invalid_argument_arg_type.xml
A navigation/runtime/src/androidTest/res/navigation/nav_invalid_argument_default_value.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java

https://android-review.googlesource.com/891680

https://goto.google.com/android-sha1/bb456e84a524d4e5cd241a6a839a1062297b9cf4

ca...@google.com <ca...@google.com> Jan 26, 2022 12:41PM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Feb 1, 2022 04:57PM

Navigation now enforces use of the "reference" type if you have a defaultValue referencing another resource. This ensures that Safe Args and Navigation's runtime behavior are always in sync.

Please star

https://issuetracker.google.com/issues/36994900 to track allowing build time placeholders in XML files.