SplashScreen - lateinit property platformView has not been initialized [214835299]

Fixed

Bug

core-splashscreen

Status Update

No update yet.

Description

it...@gmail.com

created issue #1

Jan 18, 2022 07:51AM

Artifact used: androidx.core:core-splashscreen
Version used: 1.0.0-beta01
Theme used: Theme.SplashScreen
Crash Reproducible: False
Devices/Android versions reproduced on: Pixel 4a (5G) (Android 11)

A small number of users are affected by this crash (report via Crahlytics) & it seems to be very device-specific (mentioned above).

Stacktrace:

Caused by je.l: lateinit property platformView has not been initialized
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getPlatformView(SplashScreenViewProvider.kt:119)
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getSplashScreenView(SplashScreenViewProvider.kt:125)
       at androidx.core.splashscreen.SplashScreenViewProvider$ViewImpl31.getSplashScreenView(SplashScreenViewProvider.kt:117)
       at androidx.core.splashscreen.SplashScreenViewProvider.getView(SplashScreenViewProvider.java:62)
       at androidx.core.splashscreen.SplashScreen$Impl.setOnExitAnimationListener(SplashScreen.kt:308)
       at androidx.core.splashscreen.SplashScreen.setOnExitAnimationListener(SplashScreen.java:185)
       at com.domain.app.utils.extensions.MiscKt.handleSeamlessEnd(MiscKt.java:207)
       at com.domain.app.ui.activities.main.WhiplashActivity.onCreate(WhiplashActivity.kt:48)
       at android.app.Activity.performCreate(Activity.java:8036)
       at android.app.Activity.performCreate(Activity.java:8016)
       at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329)
       at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3581)
       at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3765)
       at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:102)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2193)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loopOnce(Looper.java:201)
       at android.os.Looper.loop(Looper.java:288)
       at android.app.ActivityThread.main(ActivityThread.java:7796)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:974)

The handleSeamlessEnd extension method:

fun SplashScreen.handleSeamlessEnd() {
    setOnExitAnimationListener {
        it.iconView.animate()
            .alpha(1f)
            .setDuration(250L)
            .setListener(object : Animator.AnimatorListener {
                override fun onAnimationEnd(animator: Animator?) { it.remove() }
                override fun onAnimationStart(animator: Animator?) {}
                override fun onAnimationCancel(animator: Animator?) {}
                override fun onAnimationRepeat(animator: Animator?) {}
            })
    }
}

Comments

as...@google.com <as...@google.com> Jan 18, 2022 06:17PM

Assigned to ca...@google.com.

ca...@google.com <ca...@google.com> #2Jan 19, 2022 04:13PM

Wow, it seems like a very important bug to fix.

Doing some investigations...

It works fine with CoreTextField as well as BaseTextField.

it...@gmail.com <it...@gmail.com> #3Jan 20, 2022 06:41AM

Seems to be a duplicate of b/163834907

ca...@google.com <ca...@google.com> #4Jan 20, 2022 10:09AM

It works fine with Material TextFields (both filled and outline) if you use TextFieldValue based overloads.

It doesn't work when you use String based overloads however (both Outline and Filled). I believe this is related to the one-frame lag as we host TextFieldValue internally and proxy only string.

it...@gmail.com <it...@gmail.com> #5Jan 20, 2022 02:26PM

Chatted with Anastasia.

We have this code

// "value: String" comes as a param in TextField
TextFieldImpl(
        type = TextFieldType.Outlined,
        value = textFieldValue,
        onValueChange = {
            selection = it.selection
            composition = it.composition
            if (value != it.text) {
                onValueChange(it.text)
            }
        },

and this value is always "" for me, as it's captured my lambda when lambda was created and this lambda is saved and reused by CoreTextField.

Anyway, two things we can do:

Remove this if and invoke onValueChange everytime, even on the selection change (which we don't care about). This will allow us to workaround quickly and not to let it slip through.
Find and implement the proper fix in CoreTextField

Let me know what you think

ca...@google.com <ca...@google.com> Jan 26, 2022 12:41PM

Marked as fixed.

ap...@google.com <ap...@google.com> #6Feb 1, 2022 04:57PM

Updated the details here b/163834907.