Fixed
Status Update
No update yet.
Comments
al...@google.com
al...@google.com
Sounds easy enough! Bumping :activity:activity dependency to head revision to pick up the new class...
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 395307d4f6336ab0174ad290e8d24703fb22bcdc
Author: Alan Viverette <alanv@google.com>
Date: Tue Feb 08 15:12:24 2022
Make AppCompatDialog extend ComponentDialog and clean up nullability
Only fixes missing nullability where the platform defines it. Does not
infer nullability for overrides of un-annotated platform APIs.
Adds constraint to prevent version mismatch between viewmodel and -ktx.
AppCompat now transitively depends on kotlin-stdlib. SO IT BEGINS!
Relnote: """AppCompatDialog now extends ComponentDialog for compatibility
with OnBackPressedDispatcher."""
Test: AppCompatDialogTest
Fixes: 217620781
Change-Id: Id9b9103a07564ea6d8ebbd4c0285a41ffae0b6d1
M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/api/current.txt
M appcompat/appcompat/api/public_plus_experimental_current.txt
M samples/SupportPreferenceDemos/build.gradle
M appcompat/appcompat/build.gradle
A appcompat/appcompat/api/current.ignore
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialog.java
A appcompat/appcompat/api/restricted_current.ignore
https://android-review.googlesource.com/1976988
Branch: androidx-main
commit 395307d4f6336ab0174ad290e8d24703fb22bcdc
Author: Alan Viverette <alanv@google.com>
Date: Tue Feb 08 15:12:24 2022
Make AppCompatDialog extend ComponentDialog and clean up nullability
Only fixes missing nullability where the platform defines it. Does not
infer nullability for overrides of un-annotated platform APIs.
Adds constraint to prevent version mismatch between viewmodel and -ktx.
AppCompat now transitively depends on kotlin-stdlib. SO IT BEGINS!
Relnote: """AppCompatDialog now extends ComponentDialog for compatibility
with OnBackPressedDispatcher."""
Test: AppCompatDialogTest
Fixes: 217620781
Change-Id: Id9b9103a07564ea6d8ebbd4c0285a41ffae0b6d1
M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/api/current.txt
M appcompat/appcompat/api/public_plus_experimental_current.txt
M samples/SupportPreferenceDemos/build.gradle
M appcompat/appcompat/build.gradle
A appcompat/appcompat/api/current.ignore
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDialog.java
A appcompat/appcompat/api/restricted_current.ignore
Description
ComponentDialogwas added inDialogthat interacts correctly with theOnBackPressedDispatcher. We should replace theDialogextended byAppCompatDialogwithComponentDialog.