[MemoryLeak] Memory leak in MediaBrowserService [220795151]

Fixed

Bug

[AOSP] assigned

adexe s nau

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 22, 2022 08:50PM

We have been reporting this issue for a long time and it has always been closed by classifying it as Fixed. But we haven't been told when the version will be ready for us to test.

Leak Canary detects a memory leak in the implementation of MediaBrowserService within our MusicService just by launching, starting a playback and quitting the app.

When we look at heap dumps, Leak Canary discovers a leak where a MediaBrowserService stays in memory when you open and exit the app. The following is the Leak Canary report:

┬───
│ GC Root: Global variable in native code
│
├─ android.service.media.MediaBrowserService$ServiceBinder instance
│ Leaking: UNKNOWN
│ Retaining 266.7 kB in 824 objects
│ this$0 instance of androidx.media.
│ MediaBrowserServiceCompat$MediaBrowserServiceImplApi26$MediaBrowserServiceA
│ pi26
│ ↓ MediaBrowserService$ServiceBinder.this$0
│ ~~~~~~
├─ androidx.media.
│ MediaBrowserServiceCompat$MediaBrowserServiceImplApi26$MediaBrowserServiceApi
│ 26 instance
│ Leaking: YES (Service not held by ActivityThread)
│ Retaining 266.2 kB in 823 objects
│ mBase instance of com.audiomack.playback.MusicService
│ ↓ ContextWrapper.mBase
╰→ com.audiomack.playback.MusicService instance
Leaking: YES (ObjectWatcher was watching this because com.audiomack.
playback.MusicService received Service#onDestroy() callback and Service
not held by ActivityThread)
Retaining 264.9 kB in 811 objects
key = efafad84-39d3-43fd-b6a8-d2c75c00b36b
watchDurationMillis = 4948
retainedDurationMillis = -84
mApplication instance of com.audiomack.MainApplication
mBase instance of android.app.ContextImpl

METADATA

Build.VERSION.SDK_INT: 30
Build.MANUFACTURER: Google
LeakCanary version: 2.7
App process name: com.audiomack
Count of retained yet cleared: 18 KeyedWeakReference instances
Stats: LruCache[maxSize=3000,hits=11503,misses=247414,hitRate=4%]
RandomAccess[bytes=19500730,reads=247414,travel=236375246960,range=59839840,size
=69944156]
Heap dump reason: 32 retained objects, app is not visible
Analysis duration: 18391 ms

Comments

vi...@google.com <vi...@google.com> #2Feb 23, 2022 06:25AM

Assigned to vi...@google.com.

there are some image for help

bo...@gmail.com <bo...@gmail.com> #3Feb 28, 2022 12:50PM

hello?

iv...@mixhalo.com <iv...@mixhalo.com> #4May 2, 2022 07:34PM

I have the exact same leak in my MediaBrowserServiceCompat implementation. Any progress on a solution?

vi...@google.com <vi...@google.com> #5May 5, 2022 02:34PM

Marked as fixed.

The issue has been fixed and it will be available in a future Android release.

an...@arctouch.com <an...@arctouch.com> #6Jul 22, 2022 03:19PM

Is the fix going to be released in a new version of androidx.media library which contains the MediaBrowserServiceCompat class or is it i the OS level and depend on an OS release?

[Deleted User] <[Deleted User]> #7Jul 22, 2022 10:02PM

It will be available with next Android OS release.

iv...@mixhalo.com <iv...@mixhalo.com> #8Jul 25, 2022 04:40PM

Can we know if this bug will be fixed in Android 13, specifically?

Because a predecessor for this bug stated more than a year ago that the fix would be available "in a future release" and it didn't come with Android 12 last Autumn.

ub...@gmail.com <ub...@gmail.com> #9Mar 20, 2023 04:23PM

Issue still present even in Android 14 DP2.

ub...@gmail.com <ub...@gmail.com> #10Apr 21, 2023 03:56PM

Even a pure Media3 MediaSessionService has similar issues: https://github.com/androidx/media/issues/346

ub...@gmail.com <ub...@gmail.com> #11Apr 25, 2023 05:13PM

Just want to summarize some hopefully helpful information for affected app devs:

According to a Github comment from a Googler, this specific issue here should be fixed on API 33, but not earlier versions : https://github.com/androidx/media/issues/70#issuecomment-1521877693

MediaBrowserServiceCompat still leaks for me, because of this other issue, which was just reopened: https://issuetracker.google.com/issues/37137738

There is an effort underway to get Media3's MediaSessionService to stop leaking: https://github.com/androidx/media/issues/346#issuecomment-1522136478