Update the back stack remember lint rule to place the entry in the calculation [227382831]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 29, 2022 10:52PM

Having just a remember { } around calls to getBackStackEntry(route) causes new entries with the same id to use the old remember scope which can cause crashes. We should instead be telling devs to use remember(entry) { } using the entry from the composable function lambda scope as the input to the remember calculation. This way, whenever the entry object changes, we also recompose the remember and we never get a stale entry.

Comments

ap...@google.com <ap...@google.com> #2Apr 22, 2022 03:07AM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ap...@google.com <ap...@google.com> #3Apr 22, 2022 03:07AM

yea i'll take it.

jb...@google.com <jb...@google.com> #4Apr 25, 2022 04:30PM

Marked as fixed.

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

Issue 227382831

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Apr 22, 2022 03:07AM

ap...@google.com <ap...@google.com> #3Apr 22, 2022 03:07AM

jb...@google.com <jb...@google.com> #4Apr 25, 2022 04:30PM

Add comment

Issue metadata