You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed. [228865698]

Fixed

Bug

Status Update

No update yet.

Description

b9...@gmail.com

created issue #1

Apr 12, 2022 10:17AM

Version used: 2.5.0-alpha06

After upgraded Lifecycle to 2.5.0-alpha06, the nested NavHost navigation will crash.

open app, starting with "ok" tab.
tap "hello" tab, which has NavHost own.
tab "would" tab, app crash.

p.s. I keep the old version dependencies in build.gradle, you could try the working version.

java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
        at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:202)
        at androidx.lifecycle.ViewModelProvider.<init>(ViewModelProvider.kt:130)
        at androidx.lifecycle.SavedStateHandleSupport.getSavedStateHandlesVM(SavedStateHandleSupport.kt:109)
        at androidx.lifecycle.SavedStateHandlesProvider$viewModel$2.invoke(SavedStateHandleSupport.kt:134)
        at androidx.lifecycle.SavedStateHandlesProvider$viewModel$2.invoke(SavedStateHandleSupport.kt:133)
        at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
        at androidx.lifecycle.SavedStateHandlesProvider.getViewModel(SavedStateHandleSupport.kt:133)
        at androidx.lifecycle.SavedStateHandlesProvider.saveState(SavedStateHandleSupport.kt:146)
        at androidx.savedstate.SavedStateRegistry.performSave(SavedStateRegistry.java:262)
        at androidx.savedstate.SavedStateRegistryController.performSave(SavedStateRegistryController.kt:81)
        at androidx.navigation.NavBackStackEntry.saveState(NavBackStackEntry.kt:236)
        at androidx.navigation.NavBackStackEntryState.<init>(NavBackStackEntryState.kt:37)
        at androidx.navigation.NavController.saveState(NavController.kt:2032)
        at androidx.navigation.compose.NavHostControllerKt$NavControllerSaver$1.invoke(NavHostController.kt:81)
        at androidx.navigation.compose.NavHostControllerKt$NavControllerSaver$1.invoke(NavHostController.kt:80)
        at androidx.compose.runtime.saveable.SaverKt$Saver$1.save(Saver.kt:66)
        at androidx.compose.runtime.saveable.RememberSaveableKt$rememberSaveable$1$valueProvider$1.invoke(RememberSaveable.kt:100)
        at androidx.compose.runtime.saveable.SaveableStateRegistryImpl.performSave(SaveableStateRegistry.kt:136)
        at androidx.compose.runtime.saveable.SaveableStateHolderImpl$RegistryHolder.saveTo(SaveableStateHolder.kt:125)
        at androidx.compose.runtime.saveable.SaveableStateHolderImpl$SaveableStateProvider$1$1$invoke$$inlined$onDispose$1.dispose(Effects.kt:484)
        at androidx.compose.runtime.DisposableEffectImpl.onForgotten(Effects.kt:85)
        at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers(Composition.kt:985)
        at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:767)
        at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:785)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:526)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:454)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:775)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

MyApplication.zip

113 KB

Download

Comments

il...@google.com <il...@google.com> Apr 13, 2022 11:47PM

Assigned to il...@google.com.

ap...@google.com <ap...@google.com> #2Apr 14, 2022 03:56AM

Can you include a sample project that crashes in release mode?

b9...@gmail.com <b9...@gmail.com> #3Apr 14, 2022 07:11AM

For us this is only happening in places where LifecycleEventEffect is used. Example stacktrace:

Fatal Exception: java.lang.IllegalStateException
CompositionLocal LocalLifecycleOwner not present
androidx.lifecycle.compose.LocalLifecycleOwnerKt$LocalLifecycleOwner$1$1.invoke (LocalLifecycleOwner.android.kt:63)
androidx.lifecycle.compose.LocalLifecycleOwnerKt$LocalLifecycleOwner$1$1.invoke (LocalLifecycleOwner.android.kt:62)
kotlin.SynchronizedLazyImpl.getValue (LazyJVM.kt:74)
androidx.compose.runtime.LazyValueHolder.getCurrent (LazyValueHolder.java:29)
androidx.compose.runtime.LazyValueHolder.getValue (LazyValueHolder.java:31)
androidx.compose.runtime.CompositionLocalMapKt.read (CompositionLocalMap.kt:90)
androidx.compose.runtime.ComposerImpl.consume (Composer.kt:2135)
androidx.lifecycle.compose.LifecycleEffectKt.LifecycleEventEffect (LifecycleEffect.kt:748)
com.freeletics.feature.profile.ProfileUiKt$ProfileUi$1.invoke (ProfileUi.kt:62)

This is also on Lifecycle 2.8.2 with Compose 1.6.

il...@google.com <il...@google.com> #4Apr 14, 2022 04:26PM

Marked as fixed.

Here is a sample project

https://github.com/nilsjr/Koncept

Checkout repository
Build release apk with ./gradlew :app:assembleRelease -PenableReleaseSigning=true
App starts without crash
Comment or remove line 14 in https://github.com/nilsjr/Koncept/blob/develop/app/proguard-rules.pro
Build release apk with ./gradlew :app:assembleRelease -PenableReleaseSigning=true
App crashing on start

FATAL EXCEPTION: main (Ask Gemini)
  Process: de.nilsdruyen.koncept, PID: 5880
  java.lang.IllegalStateException: CompositionLocal LocalLifecycleOwner not present
  ...

mc...@gmail.com <mc...@gmail.com> #5May 5, 2022 07:09PM

comment#4:

Thank you for sharing the sample project. I can confirm that I was able to reproduce the issue, and that your workaround works. I will investigate the problem further.

tr...@gmail.com <tr...@gmail.com> #6May 5, 2022 07:34PM

It appears that the custom ProGuard rule was not working as intended across all projects.

However, using public static *** getLocalLifecycleOwner(); (with the wildcard type ***) seems to work consistently in the sample project and our internal experiments:

-if public class androidx.compose.ui.platform.AndroidCompositionLocals_androidKt {
    public static *** getLocalLifecycleOwner();
}
-keep public class androidx.compose.ui.platform.AndroidCompositionLocals_androidKt {
    public static *** getLocalLifecycleOwner();
}

We are investigating further, and we will be working on a fix for the issue.

il...@google.com <il...@google.com> #7May 5, 2022 09:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 79f5644cb937d950318c3c5ef2aca70ab1413119
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jun 14 16:34:11 2024

Fix Lifecycle 2.8 custom ProGuard rule

* The custom ProGuard rule was not working as intended across all projects.
* Replacing by `public static *** getLocalLifecycleOwner();` (with the wildcard type `***`) seems to work consistently in all projects.

Fixes:

b/346808608

Test: manual
Change-Id: I4cfdecc0bbfc0be02d66efcee2c63bb5b025dca2

M lifecycle/lifecycle-runtime-compose/proguard-rules.pro

https://android-review.googlesource.com/3133056

za...@groundcrewdev.com <za...@groundcrewdev.com> #8Oct 5, 2022 07:48PM

Could you please make an immediate patch release as 2.8.2 crashes with the above exception?

jb...@google.com <jb...@google.com> #9Oct 5, 2022 07:56PM

comment#8:

These changes are scheduled to be included in our upcoming hot-fix release, version 2.8.3.

za...@groundcrewdev.com <za...@groundcrewdev.com> #10Oct 5, 2022 08:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-runtime-compose:2.8.3
androidx.lifecycle:lifecycle-runtime-compose-android:2.8.3
androidx.lifecycle:lifecycle-runtime-compose-desktop:2.8.3

il...@google.com <il...@google.com> #11Oct 5, 2022 08:16PM

It seems that Lifecycle 2.8.3 is not available on Google's Maven repository: https://maven.google.com/web/index.html#androidx.lifecycle:lifecycle-runtime-compose Any idea when it will be deployed?

li...@gmail.com <li...@gmail.com> #12Jul 29, 2023 12:58PM

comment#11:

There was a mix-up, and the Lifecycle 2.8.3 artifacts won't be available until Monday. Sorry for the false alarm.

[Deleted User] <[Deleted User]> #13Aug 1, 2023 11:32AM

Seems to be good now. Thanks!

sa...@bluevine.com <sa...@bluevine.com> #14Aug 2, 2023 02:34PM

Lifecycle 2.8.3 is now available on maven.google.com.

ra...@gmail.com <ra...@gmail.com> #15Aug 24, 2023 04:39AM

I'm still getting "java.lang.IllegalStateException: CompositionLocal LocalLifecycleOwner not present" with 2.8.3 in release builds (with obfuscation enabled). Adding

-keep class androidx.compose.ui.platform.AndroidCompositionLocals_androidKt { *; }

to my ProGuard rules fixes the issue. Any advice?

In my setup I have an app that's using the lifecycle dependencies directly, but some other dependencies of mine also include the same (and these libraries are obfuscated too) - not sure if this makes a difference.

jb...@google.com <jb...@google.com> #16Aug 24, 2023 02:26PM

comment#15:

I'm unable to offer advice since I can't replicate the issue you're experiencing -- but based on your message, it appears Lifecycle "should" be working correctly.

Would you please create a separated issue and include a sample project that reproduces the problem you're encountering?

re...@gmail.com <re...@gmail.com> #17Feb 20, 2024 09:15AM