You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed. [228865698]

Fixed

Bug

Status Update

No update yet.

Description

b9...@gmail.com

created issue #1

Apr 12, 2022 10:17AM

Version used: 2.5.0-alpha06

After upgraded Lifecycle to 2.5.0-alpha06, the nested NavHost navigation will crash.

open app, starting with "ok" tab.
tap "hello" tab, which has NavHost own.
tab "would" tab, app crash.

p.s. I keep the old version dependencies in build.gradle, you could try the working version.

java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
        at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:202)
        at androidx.lifecycle.ViewModelProvider.<init>(ViewModelProvider.kt:130)
        at androidx.lifecycle.SavedStateHandleSupport.getSavedStateHandlesVM(SavedStateHandleSupport.kt:109)
        at androidx.lifecycle.SavedStateHandlesProvider$viewModel$2.invoke(SavedStateHandleSupport.kt:134)
        at androidx.lifecycle.SavedStateHandlesProvider$viewModel$2.invoke(SavedStateHandleSupport.kt:133)
        at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
        at androidx.lifecycle.SavedStateHandlesProvider.getViewModel(SavedStateHandleSupport.kt:133)
        at androidx.lifecycle.SavedStateHandlesProvider.saveState(SavedStateHandleSupport.kt:146)
        at androidx.savedstate.SavedStateRegistry.performSave(SavedStateRegistry.java:262)
        at androidx.savedstate.SavedStateRegistryController.performSave(SavedStateRegistryController.kt:81)
        at androidx.navigation.NavBackStackEntry.saveState(NavBackStackEntry.kt:236)
        at androidx.navigation.NavBackStackEntryState.<init>(NavBackStackEntryState.kt:37)
        at androidx.navigation.NavController.saveState(NavController.kt:2032)
        at androidx.navigation.compose.NavHostControllerKt$NavControllerSaver$1.invoke(NavHostController.kt:81)
        at androidx.navigation.compose.NavHostControllerKt$NavControllerSaver$1.invoke(NavHostController.kt:80)
        at androidx.compose.runtime.saveable.SaverKt$Saver$1.save(Saver.kt:66)
        at androidx.compose.runtime.saveable.RememberSaveableKt$rememberSaveable$1$valueProvider$1.invoke(RememberSaveable.kt:100)
        at androidx.compose.runtime.saveable.SaveableStateRegistryImpl.performSave(SaveableStateRegistry.kt:136)
        at androidx.compose.runtime.saveable.SaveableStateHolderImpl$RegistryHolder.saveTo(SaveableStateHolder.kt:125)
        at androidx.compose.runtime.saveable.SaveableStateHolderImpl$SaveableStateProvider$1$1$invoke$$inlined$onDispose$1.dispose(Effects.kt:484)
        at androidx.compose.runtime.DisposableEffectImpl.onForgotten(Effects.kt:85)
        at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers(Composition.kt:985)
        at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:767)
        at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:785)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:526)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:454)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:775)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

MyApplication.zip

113 KB

Download

Comments

il...@google.com <il...@google.com> Apr 13, 2022 11:47PM

Assigned to il...@google.com.

ap...@google.com <ap...@google.com> #2Apr 14, 2022 03:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit 66494e2d6810347e6a3b41ec3f2665e598f108f0
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 14 00:14:24 2022

Ensure that SavedStateHandle restores upon initial creation

runOnNextRecreation() only runs on the next time
the lifecycle reaches CREATED, not the first time.

By using a LifecycleObserver directly, we ensure that
each Lifecycle move causes a performRestore() to
consistently happen.

Test: existing tests pass, sample app works
BUG: 228865698
Relnote: "Fixed an issue where nesting one `NavHost` within
another `NavHost` in a non-primary bottom navigation tab
would lead to an `IllegalStateException` when using
multiple back stacks."

Change-Id: I11bd5173f035ae1da7922b4142fcedc0f3b54ff6

M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt

https://android-review.googlesource.com/2064518

b9...@gmail.com <b9...@gmail.com> #3Apr 14, 2022 07:11AM

Thanks for quick fix! Works well with latest snapshot.

il...@google.com <il...@google.com> #4Apr 14, 2022 04:26PM

Marked as fixed.

Thanks for confirming! The fix will be in the next release of Lifecycle (2.5.0-beta01).

mc...@gmail.com <mc...@gmail.com> #5May 5, 2022 07:09PM

2.4.1 also has same issue

using jetpack compose / bottom navigation with NavHost

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

tr...@gmail.com <tr...@gmail.com> #6May 5, 2022 07:34PM

I am seeing a high occurance rate with 2.5.0-beta01 as well.

il...@google.com <il...@google.com> #7May 5, 2022 09:55PM

Re comment#5 and comment#6 - please file a new bug with a sample project that reproduces your issue. That would help rule out it being a duplicate of this issue where your remember around getBackStackEntry needs to be updated.

za...@groundcrewdev.com <za...@groundcrewdev.com> #8Oct 5, 2022 07:48PM

Hi, I recently came across this crash in my current project and I discovered that it happens when a Textfield was tapped and in focus, then the app was backgrounded. This would occur with all of the Textfields in the app.

We are using Compose version: 1.2.0-rc03
and jetpack lifecycle version: 2.4.1

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

jb...@google.com <jb...@google.com> #9Oct 5, 2022 07:56PM

Please file a new bug with a minimal sample project that reproduces your error.

za...@groundcrewdev.com <za...@groundcrewdev.com> #10Oct 5, 2022 08:11PM

Okay, we will get a sample project up soon. One thing I forgot to mention in the initial comment is that this crash occurs when we use backQueue.clear() to clear the back stack. We were able to come up with a solution/workaround by using popUpTo() as a way to clear the back stack, and after implementing that solution we saw no crashes when backgrounding the app while a textfield was in focus.

il...@google.com <il...@google.com> #11Oct 5, 2022 08:16PM

Re comment#10 - backQueue is not part of the public API surface and never has been. Calling anything on that is always, always, always the wrong thing to do.

li...@gmail.com <li...@gmail.com> #12Jul 29, 2023 12:58PM

Any updates? This issue is persistent for almost 6 months and its getting crazier.

g....@tnet.ge <g....@tnet.ge> #13Aug 1, 2023 11:32AM

Solution is provided here >

https://github.com/google/accompanist/issues/1487#issuecomment-1660115297

sa...@bluevine.com <sa...@bluevine.com> #14Aug 2, 2023 02:34PM

This is still happened

ra...@gmail.com <ra...@gmail.com> #15Aug 24, 2023 04:39AM

It's still happening with navigation-compose 2.7.0 and lifecycle 2.6.1

jb...@google.com <jb...@google.com> #16Aug 24, 2023 02:26PM

Try 2.7.1

re...@gmail.com <re...@gmail.com> #17Feb 20, 2024 09:15AM

Still happening on navigation-compose v2.7.7 / lifecycle v2.7.0. Any updates / prospect? Workaround maybe?