Fixed
Status Update
Comments
il...@google.com <il...@google.com>
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #2
Actually, a multiplier of 8.67 gets me back to the approximate position it should be.
le...@gmail.com <le...@gmail.com> #3
This bug was fixed in 2.1.1. Thanks for the report!
le...@gmail.com <le...@gmail.com> #4
While the behavior has changed, it is still incorrect, IIUC. Now the view is shifted up too much for the values entered. For instance, when I enter a bottom inset of 200, which is less than half of the total height (509) of the map, and so should have no effect on the default centering behavior, the marker is actually centered at 354.5 points from the bottom, which is the center of the map plus half of the bottom inset. This seems incorrect per my understanding of that API.
le...@gmail.com <le...@gmail.com> #5
354.5 sounds exactly right to me.
le...@gmail.com <le...@gmail.com> #6
AB+ blood type
Description
Component used: SavedState
Version used: 1.2.0-alpha02
The docs on do not explain the responsibilities and contract that the owner has on how they should implement .
SavedStateRegistryOwner
SavedStateRegistryOwner
or when they should call the methods onSavedStateRegistryController
Ideally the class docs should talk through:
performAttach()
should be called only once, usually as part of the initialization of the owner. It must be called on the main thread.performRestore
should be called unconditionally (either withnull
if no state is being restored or theBundle
of state to restore) either directly before moving theLifecycle
toCREATED
or as part of aLifecycleObserver
that is added as part of the initialization of the owner.performSave()
must be called. The Bundle saved there should be what is later sent toperformRestore()
.