Fixed
Status Update
No update yet.
Comments
il...@google.com
cl...@google.com
ap...@google.com
Found the issue, ugh
Noticed that when I do the following:
transaction.addToBackStack(null)
When adding a Fragment with ViewPager2, the above issue occurs, although, idk if it's becaugh of gcFragments() anymore.
As soon as I un-comment that line, the issue disappears.
Noticed that when I do the following:
transaction.addToBackStack(null)
When adding a Fragment with ViewPager2, the above issue occurs, although, idk if it's becaugh of gcFragments() anymore.
As soon as I un-comment that line, the issue disappears.
le...@gmail.com
Is the Sample application, to reproduce, move back really fast between page 2 -> 1 and vice versa (they are bottom buttons) a couple times.
Wait a couple seconds and page 1 (the black page) should turn white meaning the Fragment has been removed.
As soon as you comment line 40 on MainActivity, and attempt again, the error does not persist
le...@gmail.com
Woops, sorry, If you guys had the previous ViewPagerCrash test app, I forgot to push (was exhasuted after debugging) I pushed one more time for the latest reproducible code
le...@gmail.com
We'll have a look, thanks for reporting and repro steps / sample app. Stay tuned for updates on this issue.
le...@gmail.com
Got to debug this now. Your sample indeed showcases an issue, so thanks for reporting and for the sample!
`transaction.addToBackStack(null)` adds the Fragment replacement transaction to the back stack, so you can go back to the previous state with the back button. Is that what you were looking to achieve? You said it works without it, which might help in the meantime.
Would you mind describing the use-case, so I better understand what you're trying to achieve? E.g. in the example, by switching between buttons 1 and 2 at some point you achieve multiple stack entries going back to the ViewPager2 Fragment.
`transaction.addToBackStack(null)` adds the Fragment replacement transaction to the back stack, so you can go back to the previous state with the back button. Is that what you were looking to achieve? You said it works without it, which might help in the meantime.
Would you mind describing the use-case, so I better understand what you're trying to achieve? E.g. in the example, by switching between buttons 1 and 2 at some point you achieve multiple stack entries going back to the ViewPager2 Fragment.
Description
Component used: SavedState
Version used: 1.2.0-alpha02
The
SavedStateRegistryOwnerSavedStateRegistryOwneror when they should call the methods onSavedStateRegistryControllerIdeally the class docs should talk through:
performAttach()should be called only once, usually as part of the initialization of the owner. It must be called on the main thread.performRestoreshould be called unconditionally (either withnullif no state is being restored or theBundleof state to restore) either directly before moving theLifecycletoCREATEDor as part of aLifecycleObserverthat is added as part of the initialization of the owner.performSave()must be called. The Bundle saved there should be what is later sent toperformRestore().