SavedStateRegistryOwner should describe the implementing classes' responsibilities [228887344]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Apr 11, 2022 10:47PM

Component used: SavedState

Version used: 1.2.0-alpha02

The docs on SavedStateRegistryOwner do not explain the responsibilities and contract that the owner has on how they should implement SavedStateRegistryOwner or when they should call the methods on SavedStateRegistryController.

Ideally the class docs should talk through:

That performAttach() should be called only once, usually as part of the initialization of the owner. It must be called on the main thread.
That performRestore should be called unconditionally (either with null if no state is being restored or the Bundle of state to restore) either directly before moving the Lifecycle to CREATED or as part of a LifecycleObserver that is added as part of the initialization of the owner.
When the state of the owner is saved, performSave() must be called. The Bundle saved there should be what is later sent to performRestore().

Comments

il...@google.com <il...@google.com> Apr 14, 2022 04:58PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> Apr 14, 2022 04:59PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #2Apr 19, 2022 10:44PM

Marked as fixed.

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

le...@gmail.com <le...@gmail.com> #3Oct 21, 2022 02:20AM

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

le...@gmail.com <le...@gmail.com> #4Oct 21, 2022 02:21AM

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

le...@gmail.com <le...@gmail.com> #5Oct 21, 2022 02:22AM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

le...@gmail.com <le...@gmail.com> #6Oct 21, 2022 02:22AM

Accompanist now supports this with Navigation Material.