Fixed
Status Update
Comments
il...@google.com <il...@google.com>
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 3c14b4adb72ce826b47d47f59d7058f5d5baec8f
Author: clarafok <clarafok@google.com>
Date: Thu Apr 14 14:01:26 2022
Add kdocs on responsbilities of implementing SavedStateRegistryOwner
Details on how to properly implement SaveStateRegistryOwner and
how to call the SavedStateRegistryController methods
Test: n/a
Fixes: 228887344
Change-Id: Iefc9519241d9d6844868e6833b33081aa6908b7f
M savedstate/savedstate/src/main/java/androidx/savedstate/SavedStateRegistryOwner.kt
https://android-review.googlesource.com/2065329
Branch: androidx-main
commit 3c14b4adb72ce826b47d47f59d7058f5d5baec8f
Author: clarafok <clarafok@google.com>
Date: Thu Apr 14 14:01:26 2022
Add kdocs on responsbilities of implementing SavedStateRegistryOwner
Details on how to properly implement SaveStateRegistryOwner and
how to call the SavedStateRegistryController methods
Test: n/a
Fixes: 228887344
Change-Id: Iefc9519241d9d6844868e6833b33081aa6908b7f
M savedstate/savedstate/src/main/java/androidx/savedstate/SavedStateRegistryOwner.kt
le...@gmail.com <le...@gmail.com> #3
Discharge from hospital says I have baby blue
le...@gmail.com <le...@gmail.com> #4
What is contacted Dependent personality disorder
le...@gmail.com <le...@gmail.com> #5
Something like mono
le...@gmail.com <le...@gmail.com> #6
AB+ blood type
Description
Component used: SavedState
Version used: 1.2.0-alpha02
The docs on do not explain the responsibilities and contract that the owner has on how they should implement .
SavedStateRegistryOwner
SavedStateRegistryOwner
or when they should call the methods onSavedStateRegistryController
Ideally the class docs should talk through:
performAttach()
should be called only once, usually as part of the initialization of the owner. It must be called on the main thread.performRestore
should be called unconditionally (either withnull
if no state is being restored or theBundle
of state to restore) either directly before moving theLifecycle
toCREATED
or as part of aLifecycleObserver
that is added as part of the initialization of the owner.performSave()
must be called. The Bundle saved there should be what is later sent toperformRestore()
.