unhandled Camera2 exception triggered inside CameraX primarily on Jio JioPhone Next but also some other devices [231701345]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

May 7, 2022 11:58AM

We're receiving these crash reports for our app on the Play Store (https://play.google.com/store/apps/details?id=app.grapheneos.camera.play). I'm unsure why it's happening, but perhaps you can get one of these devices and reproduce it. Ideally, CameraX could at least start catching this exception and turning it into an error surfaced to the app.

Jio JioPhone Next (Qualcomm QM215)
Samsung Galaxy A02s (Qualcomm SDM450)
Vivo V2039 (Qualcomm SDM439)

We're mostly seeing these crashes from the Jio JioPhone Next which is a very widely used, very cheap device in India. The crash traceback is nearly identical across the around 5 device models where we've seen it with only minor variations in Camera2 implementation line numbers. All of the impacted devices are Android 11.

java.lang.AssertionError: 
  at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal (MarshalQueryableRange.java:95)
  at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal (MarshalQueryableRange.java:37)
  at android.hardware.camera2.impl.CameraMetadataNative.getBase (CameraMetadataNative.java:584)
  at android.hardware.camera2.impl.CameraMetadataNative.get (CameraMetadataNative.java:444)
  at android.hardware.camera2.impl.CameraMetadataNative.get (CameraMetadataNative.java:413)
  at android.hardware.camera2.CameraCharacteristics.get (CameraCharacteristics.java:258)
  at androidx.camera.camera2.internal.compat.CameraCharacteristicsBaseImpl.get (CameraCharacteristicsBaseImpl.java)
  at androidx.camera.camera2.internal.compat.CameraCharacteristicsCompat.get (CameraCharacteristicsCompat.java)
  at androidx.camera.camera2.internal.ZoomControl.isAndroidRZoomSupported (ZoomControl.java)
  at androidx.camera.camera2.internal.ZoomControl.createZoomImpl (ZoomControl.java)
  at androidx.camera.camera2.internal.ZoomControl.<init> (ZoomControl.java:17)
  at androidx.camera.camera2.internal.Camera2CameraControlImpl.<init> (Camera2CameraControlImpl.java)
  at androidx.camera.camera2.internal.Camera2CameraImpl.<init> (Camera2CameraImpl.java)
  at androidx.camera.camera2.internal.Camera2CameraFactory.getCamera (Camera2CameraFactory.java)
  at androidx.camera.core.impl.CameraRepository.init (CameraRepository.java:49)
  at androidx.camera.core.CameraX.lambda$initAndRetryRecursively$2 (CameraX.java)
  at androidx.camera.camera2.internal.compat.CameraCaptureSessionCompat$CaptureCallbackExecutorWrapper$$InternalSyntheticLambda$8$44f3b3505978b6ed93f62d918bccdd3aaac62bd10e5c81e454c5e6523140bd24$0.run$bridge (CameraCaptureSessionCompat.java)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
  at java.lang.Thread.run (Thread.java:923)
Caused by: java.lang.reflect.InvocationTargetException: 
  at java.lang.reflect.Constructor.newInstance0 (Native Method)
  at java.lang.reflect.Constructor.newInstance (Constructor.java:343)
  at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal (MarshalQueryableRange.java:87)
  at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal (MarshalQueryableRange.java:37)
  at android.hardware.camera2.impl.CameraMetadataNative.getBase (CameraMetadataNative.java:584)
  at android.hardware.camera2.impl.CameraMetadataNative.get (CameraMetadataNative.java:444)
  at android.hardware.camera2.impl.CameraMetadataNative.get (CameraMetadataNative.java:413)
  at android.hardware.camera2.CameraCharacteristics.get (CameraCharacteristics.java:258)
  at androidx.camera.camera2.internal.compat.CameraCharacteristicsBaseImpl.get (CameraCharacteristicsBaseImpl.java)
  at androidx.camera.camera2.internal.compat.CameraCharacteristicsCompat.get (CameraCharacteristicsCompat.java)
  at androidx.camera.camera2.internal.ZoomControl.isAndroidRZoomSupported (ZoomControl.java)
  at androidx.camera.camera2.internal.ZoomControl.createZoomImpl (ZoomControl.java)
  at androidx.camera.camera2.internal.ZoomControl.<init> (ZoomControl.java:17)
  at androidx.camera.camera2.internal.Camera2CameraControlImpl.<init> (Camera2CameraControlImpl.java)
  at androidx.camera.camera2.internal.Camera2CameraImpl.<init> (Camera2CameraImpl.java)
  at androidx.camera.camera2.internal.Camera2CameraFactory.getCamera (Camera2CameraFactory.java)
  at androidx.camera.core.impl.CameraRepository.init (CameraRepository.java:49)
  at androidx.camera.core.CameraX.lambda$initAndRetryRecursively$2 (CameraX.java)
  at androidx.camera.camera2.internal.compat.CameraCaptureSessionCompat$CaptureCallbackExecutorWrapper$$InternalSyntheticLambda$8$44f3b3505978b6ed93f62d918bccdd3aaac62bd10e5c81e454c5e6523140bd24$0.run$bridge (CameraCaptureSessionCompat.java)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
  at java.lang.Thread.run (Thread.java:923)
Caused by: java.lang.IllegalArgumentException: 
  at android.util.Range.<init> (Range.java:59)
  at java.lang.reflect.Constructor.newInstance0 (Native Method)
  at java.lang.reflect.Constructor.newInstance (Constructor.java:343)
  at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal (MarshalQueryableRange.java:87)
  at android.hardware.camera2.marshal.impl.MarshalQueryableRange$MarshalerRange.unmarshal (MarshalQueryableRange.java:37)
  at android.hardware.camera2.impl.CameraMetadataNative.getBase (CameraMetadataNative.java:584)
  at android.hardware.camera2.impl.CameraMetadataNative.get (CameraMetadataNative.java:444)
  at android.hardware.camera2.impl.CameraMetadataNative.get (CameraMetadataNative.java:413)
  at android.hardware.camera2.CameraCharacteristics.get (CameraCharacteristics.java:258)
  at androidx.camera.camera2.internal.compat.CameraCharacteristicsBaseImpl.get (CameraCharacteristicsBaseImpl.java)
  at androidx.camera.camera2.internal.compat.CameraCharacteristicsCompat.get (CameraCharacteristicsCompat.java)
  at androidx.camera.camera2.internal.ZoomControl.isAndroidRZoomSupported (ZoomControl.java)
  at androidx.camera.camera2.internal.ZoomControl.createZoomImpl (ZoomControl.java)
  at androidx.camera.camera2.internal.ZoomControl.<init> (ZoomControl.java:17)
  at androidx.camera.camera2.internal.Camera2CameraControlImpl.<init> (Camera2CameraControlImpl.java)
  at androidx.camera.camera2.internal.Camera2CameraImpl.<init> (Camera2CameraImpl.java)
  at androidx.camera.camera2.internal.Camera2CameraFactory.getCamera (Camera2CameraFactory.java)
  at androidx.camera.core.impl.CameraRepository.init (CameraRepository.java:49)
  at androidx.camera.core.CameraX.lambda$initAndRetryRecursively$2 (CameraX.java)
  at androidx.camera.camera2.internal.compat.CameraCaptureSessionCompat$CaptureCallbackExecutorWrapper$$InternalSyntheticLambda$8$44f3b3505978b6ed93f62d918bccdd3aaac62bd10e5c81e454c5e6523140bd24$0.run$bridge (CameraCaptureSessionCompat.java)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
  at java.lang.Thread.run (Thread.java:923)

Comments

da...@gmail.com <da...@gmail.com> #2May 7, 2022 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 23f1ec688f947830ccb1b80ea05bcf918a49259c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Aug 08 11:24:53 2024

Support linuxArm64 JNI in sqlite-bundled

Bug: 358045505
Test: Manual, validated natives/linux_arm64/libsqliteJni.so is in jar file.
Change-Id: I4ad58258e6379b621e25bde24d565db47e7186ea

M sqlite/sqlite-bundled/build.gradle

https://android-review.googlesource.com/3213736

wu...@google.com <wu...@google.com> #3May 9, 2022 02:53AM

It works perfectly! Thanks for the quick response!

sc...@google.com <sc...@google.com> #4May 9, 2022 03:31AM

Reassigned to mi...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.sqlite:sqlite-bundled:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-android:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-iosarm64:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha07
androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha07

sh...@google.com <sh...@google.com> #5May 9, 2022 05:03PM

Is it possible to get a bugreport from those devices?

da...@gmail.com <da...@gmail.com> #6May 9, 2022 05:17PM

One of our project members can potentially get their hands on one of these devices but we currently don't have access to one. It's probably a lot easier for you folks to get one since we can't really afford to buy phones.

Ideally you could get some of these cheap Indian/Chinese phones for the CameraX device lab.

This Jio device is Google certified but in my experience most non-Pixel phones are pretty far from genuinely passing the CTS and have a lot of failures that aren't just flaky tests. I'm not sure how they get their devices certified but apparently there are waivers. Google doesn't do the certification but rather third parties do, and it's possible they're simply cutting corners or acting in a corrupt way. Usually there are a lot of failing CTS Camera tests. It doesn't help that a lot of those CTS Camera tests are super flaky without a high quality device and a proper testing setup with proper lightning, etc. They can still fail from flakiness even with that setup. Probably why they can so easily skip meeting these requirements, since the certification companies are used to flaky / failing tests and aren't really doing their job properly.

da...@gmail.com <da...@gmail.com> #7May 9, 2022 05:18PM

We have a project member in India who could buy one of these phones and since they're so cheap (around $80 or something) I could cover that but in general I don't really want to be buying phones we don't really need.

sc...@google.com <sc...@google.com> #8May 10, 2022 04:26AM

Hi ,

Thanks for the informations. You are right, it's possible that the devices are not genuinely passing the CTS.
Regardless, we will fix this in CameraX. (Thanks for letting us know BTW)
We will also try to get one of these device to test if there are other issues.

Scott

tr...@google.com <tr...@google.com> #9May 12, 2022 01:32AM

This crash looks similar to the one in b/216667482. We might want to do a similar workaround here.

sc...@google.com <sc...@google.com> #10May 12, 2022 03:25AM

It seems there are two approaches
1) Fix it generally
2) Have a quirk for this, only enable the fix when device has this quirk.

The problem with the quirk is that it is too easy to miss some other devices that have this issue too.
Having a general fallback that works reasonably can fix the issue for all problematic devices.
(In these two cases, they are both reasonable to return false if the key access failed)

But I do think it has benefits to have a quirk so that we know exactly what workaround we handled in CameraX.

Maybe , we can have a type of quirk or workaround that we apply generally for all devices ?

WDYT?

mi...@google.com <mi...@google.com> #11May 12, 2022 04:00AM

I had similar considerations while adding the try-catch code (aosp/2092403). I want to have a quirk to document the workaround we made, but it would be a little weird that the quirk should always return true on the device quirk check. I was wondering if it is possible to have another type of quirk, e.g. a function with comment in quirk format.

ap...@google.com <ap...@google.com> #12May 18, 2022 04:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit 874ef5abba7929d0110fd54392ae9d8ee91003f0
Author: mingdatsai <mingdatsai@google.com>
Date: Mon May 09 20:32:42 2022

Catch CameraCharacteristicsBaseImpl exceptions

Some devices may throw AssertionError, which is not the expected
behavior, when failed to get CameraCharacteristic. When that happens,
we catch the error and return null to workaround it.

Bug: 231701345
Test: ZoomControlTest, ZoomControlDeviceTest &
Camera2CameraControlImplDeviceTest

Change-Id: Ia248ae5580b9d4a0949f4448ccbafcedd1ba7b9b

M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/ZoomControlTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/ZoomControl.java
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/internal/Camera2CameraControlImplDeviceTest.java
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/internal/ZoomControlDeviceTest.java

https://android-review.googlesource.com/2092403

mi...@google.com <mi...@google.com> #13May 18, 2022 04:59AM

Marked as fixed.

We have tested both Android 11 and Android 12 versions on JioPhone Next and couldn't reproduce the bug. I'm guessing it might have be fixed in an earlier device update. The code to handle the AsserionError has been merged, and will be included in a following release.

da...@gmail.com <da...@gmail.com> #14May 18, 2022 05:27AM

That makes sense since we're not seeing enough of the errors for it to be impacting all of them. Play Store doesn't provide more than the major version though and we don't have any of our own crash reporting.

mi...@google.com <mi...@google.com> #15May 18, 2022 07:55AM

Thanks for the information, it seems match with the guess.

ju...@google.com <ju...@google.com> #16Dec 7, 2022 06:36PM