Slider cause app crash when density change [231707291]

Fixed

Bug

Status Update

No update yet.

Description

ra...@gmail.com

created issue #1

May 7, 2022 02:24PM

Jetpack Compose version: 1.2.0-alpha07 Jetpack Compose component used: material3

Use Slider with zero width constrants, then change the density, the Slider might causes app crash:

java.lang.IllegalArgumentException: Padding must be non-negative
        at androidx.compose.foundation.layout.PaddingModifier.<init>(Padding.kt:346)
        at androidx.compose.foundation.layout.PaddingModifier.<init>(Unknown Source:0)
        at androidx.compose.foundation.layout.PaddingKt.padding-qDBjuR0(Padding.kt:56)
        at androidx.compose.foundation.layout.PaddingKt.padding-qDBjuR0$default(Padding.kt:50)
        at androidx.compose.material3.SliderKt.SliderThumb-i-S6nvU(Slider.kt:385)
        at androidx.compose.material3.SliderKt.SliderImpl(Slider.kt:371)
        at androidx.compose.material3.SliderKt.access$SliderImpl(Slider.kt:1)
        at androidx.compose.material3.SliderKt$Slider$3.invoke(Slider.kt:207)
        at androidx.compose.material3.SliderKt$Slider$3.invoke(Slider.kt:155)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
        at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:127)
        at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:127)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:157)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2287)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2547)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3076)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3054)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:252)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3054)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3020)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:722)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:876)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:107)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:485)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:454)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:964)
        at android.view.Choreographer.doCallbacks(Choreographer.java:790)
        at android.view.Choreographer.doFrame(Choreographer.java:721)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Here is a simple code to reproduce that:

val currentDensity = LocalDensity.current
            var densityMultiplier by remember {
                mutableStateOf(1f)
            }
            CompositionLocalProvider(
                LocalDensity provides Density(currentDensity.density * densityMultiplier)
            ) {
                Box(modifier = Modifier.requiredWidth(0.dp)) {
                    Slider(
                        value = densityMultiplier,
                        onValueChange = { densityMultiplier = it }
                    )
                }
            }

Just drag the slider, it will crash very soon

Comments

ra...@gmail.com <ra...@gmail.com> #2May 7, 2022 02:31PM

Is there any updates? This is a big problem!

sg...@google.com <sg...@google.com> May 7, 2022 06:51PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #3May 9, 2022 03:19PM

Status: Won't Fix (Intended Behavior)

Hi there - could you provide more context on the issue & a sample project to reproduce? Database locked exceptions are quite difficult to pinpoint without a repro project. Thanks!

ra...@gmail.com <ra...@gmail.com> #4May 9, 2022 11:58PM

Hi. It is reproduceable on some users by using this code:

suspend fun <R> MyDatabase.workaroundWithTransaction(block: suspend TransactionScope<R>.() -> R) {
    useWriterConnection {
        it.immediateTransaction(block)
    }

    // TODO: Temporally fix https://issuetracker.google.com/issues/340606803#comment2
    // Manually triggers invalidation
    invalidationTracker.refreshAsync()
}

ra...@gmail.com <ra...@gmail.com> #5May 10, 2022 12:14AM

Maybe it is about this? https://android-review.googlesource.com/c/platform/frameworks/support/+/3114928

I am not sure.

ma...@google.com <ma...@google.com> #6May 10, 2022 07:16PM

Status: Assigned (reopened)

Hi. Please merge the pull request. This is big problem!

ra...@gmail.com <ra...@gmail.com> #7May 10, 2022 11:45PM

Hi. Is there any updates on this problem?

ap...@google.com <ap...@google.com> #8May 10, 2022 11:54PM

Marked as fixed.

Hi, I updated my version to alpha12 but still have these crashes. Please release a fix asap.