Slider cause app crash when density change [231707291]

Fixed

Bug

Status Update

No update yet.

Description

ra...@gmail.com

created issue #1

May 7, 2022 02:24PM

Jetpack Compose version: 1.2.0-alpha07 Jetpack Compose component used: material3

Use Slider with zero width constrants, then change the density, the Slider might causes app crash:

java.lang.IllegalArgumentException: Padding must be non-negative
        at androidx.compose.foundation.layout.PaddingModifier.<init>(Padding.kt:346)
        at androidx.compose.foundation.layout.PaddingModifier.<init>(Unknown Source:0)
        at androidx.compose.foundation.layout.PaddingKt.padding-qDBjuR0(Padding.kt:56)
        at androidx.compose.foundation.layout.PaddingKt.padding-qDBjuR0$default(Padding.kt:50)
        at androidx.compose.material3.SliderKt.SliderThumb-i-S6nvU(Slider.kt:385)
        at androidx.compose.material3.SliderKt.SliderImpl(Slider.kt:371)
        at androidx.compose.material3.SliderKt.access$SliderImpl(Slider.kt:1)
        at androidx.compose.material3.SliderKt$Slider$3.invoke(Slider.kt:207)
        at androidx.compose.material3.SliderKt$Slider$3.invoke(Slider.kt:155)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
        at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:127)
        at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:127)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:157)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2287)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2547)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3076)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3054)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:252)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3054)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3020)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:722)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:876)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:107)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:485)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:454)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:964)
        at android.view.Choreographer.doCallbacks(Choreographer.java:790)
        at android.view.Choreographer.doFrame(Choreographer.java:721)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Here is a simple code to reproduce that:

val currentDensity = LocalDensity.current
            var densityMultiplier by remember {
                mutableStateOf(1f)
            }
            CompositionLocalProvider(
                LocalDensity provides Density(currentDensity.density * densityMultiplier)
            ) {
                Box(modifier = Modifier.requiredWidth(0.dp)) {
                    Slider(
                        value = densityMultiplier,
                        onValueChange = { densityMultiplier = it }
                    )
                }
            }

Just drag the slider, it will crash very soon

Comments

ra...@gmail.com <ra...@gmail.com> #2May 7, 2022 02:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f85de8f1f4a1f025bcd6ae566c9ce3b4c8f1f06c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Jan 24 16:28:34 2019

Use fully qualified ClassName for action method return names.

Using complete ClassName for action return types helps child direction
classes correctly generate their inherited action method. More precisely
it allows for deep nested direction classes to correctly import the
inner NavDirection class generated in a grandfather direction class.

Bug: 123347762
Test: ./gradlew navigation:navigation-safe-args-gradle-plugin:test \
navigation:navigation-safe-args-generator:test

Change-Id: I62a0b10b33bfe496d930782a7ef0d7269a75df96

M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/nested_overridden_action_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_nested_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project/src/main/res/navigation/nav_nested_test.xml

https://android-review.googlesource.com/885199

https://goto.google.com/android-sha1/f85de8f1f4a1f025bcd6ae566c9ce3b4c8f1f06c

sg...@google.com <sg...@google.com> May 7, 2022 06:51PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #3May 9, 2022 03:19PM

Status: Won't Fix (Intended Behavior)

This has been fixed internally and will be available in the next release.

Note that the Kotlin Safe Args plugin (using apply plugin: 'androidx.navigation.safeargs.kotlin') is not affected by this bug, so if you're in a Kotlin only project, consider switching to that as a workaround.

Note that when fixing this issue, we did find another issue, filed as

https://issuetracker.google.com/issues/123374541 that *does* affect the Kotlin code gen specifically when using a argument name with the same name as the enum class you've set as the default value (in your example app, the android:name="ToolbarType"). Feel free to star that issue to track progress on that issue and note the workaround listed there).

ra...@gmail.com <ra...@gmail.com> #4May 9, 2022 11:58PM

yes, i am using Modifier.weight for Slider, i don't know why it crash on OnePlus phone

ra...@gmail.com <ra...@gmail.com> #5May 10, 2022 12:14AM

Here is a example code of my slider controller

Row(Modifier.fillMaxWidth()) {
// Some icon buttons here

Slider(
    modifier = Modifier.weight(1f)
   //...
}

// Other icon buttons here
}

When exiting the horizontal screen state or entering the picture-in-picture mode, the above exception will be caused, and it only happens on OnePlus phone

ma...@google.com <ma...@google.com> #6May 10, 2022 07:16PM

Status: Assigned (reopened)

Thanks I'll add a fix for parents with width 0.dp maybe it something that only happens briefly and then it measures something reasonable. Can you share the exact model/OS?

ra...@gmail.com <ra...@gmail.com> #7May 10, 2022 11:45PM

OnePlus 7/OnePlus 8

I don't have any specific phone to test,it's the feedback from my users. After the simulator test, I guess it's the change of density?

At present, I use BoxWithConstraints to wrap the Slider. And check the maximum width of the constraint, and it will only be displayed when the maximum width is above 40dp, which temporarily fixes the exception.

ap...@google.com <ap...@google.com> #8May 10, 2022 11:54PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 76f24353f136570d95e80840a44d6faf67383971
Author: Mariano Martin <marianomartin@google.com>
Date: Tue May 10 16:01:23 2022

Allow slider parent to have 0 width

Fix: 231707291
Test: added slider_zero_width
Change-Id: Idb144788fd8e45dd651d211c8093fc53be39a0d1

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/SliderTest.kt

https://android-review.googlesource.com/2094765