App crashes when using Layout Inspector to inspect Compose screen [235526153]

Fixed

Bug

Status Update

No update yet.

Description

ed...@x.com

created issue #1

Jun 10, 2022 02:07AM

Build: AI-213.7172.25.2211.8624637, 202205202352,

AI-213.7172.25.2211.8624637, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.4, screens 3024.0x1964.0, 5120.0x2880.0; Retina

AS: Electric Eel | 2022.1.1 Canary 3 Kotlin plugin: 213-1.6.21-release-for-android-studio-AS6777.52 Android Gradle Plugin: (plugin information not found) Gradle: 7.4.2 Gradle JDK: version 11.0.15 NDK: from local.properties: (not specified), latest from SDK: (not found) CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

Compose 1.2.0-beta01

                         E  java.lang.ClassCastException: androidx.compose.foundation.BorderCache cannot be cast to androidx.compose.ui.platform.ViewRootForInspector
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree$SubCompositionRoots.remember(LayoutInspectorTree.kt:751)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.markUnwanted(LayoutInspectorTree.kt:613)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.parse(LayoutInspectorTree.kt:464)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.convert(LayoutInspectorTree.kt:390)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.access$convert(LayoutInspectorTree.kt:102)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree$convert$group$1.invoke(LayoutInspectorTree.kt:375)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree$convert$group$1.invoke(LayoutInspectorTree.kt:375)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:111)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.CompositionCallStack.convert(SlotTree.kt:103)
                         E      at androidx.compose.ui.inspection.data.SlotTreeKt.asLazyTree(SlotTree.kt:524)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.convert(LayoutInspectorTree.kt:375)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.convert(LayoutInspectorTree.kt:266)
                         E      at androidx.compose.ui.inspection.inspector.LayoutInspectorTree.convert(LayoutInspectorTree.kt:141)
                         E      at androidx.compose.ui.inspection.compose.AndroidComposeViewWrapper.<init>(AndroidComposeViewWrapper.kt:116)
                         E      at androidx.compose.ui.inspection.compose.AndroidComposeViewWrapper$Companion.tryCreateFor(AndroidComposeViewWrapper.kt:88)
                         E      at androidx.compose.ui.inspection.ComposeLayoutInspector.getAndroidComposeViews(ComposeLayoutInspector.kt:381)
                         E      at androidx.compose.ui.inspection.ComposeLayoutInspector.access$getAndroidComposeViews(ComposeLayoutInspector.kt:68)
                         E      at androidx.compose.ui.inspection.ComposeLayoutInspector$getComposableNodes$data$1.invoke(ComposeLayoutInspector.kt:329)
                         E      at androidx.compose.ui.inspection.ComposeLayoutInspector$getComposableNodes$data$1.invoke(ComposeLayoutInspector.kt:326)
                         E      at androidx.compose.ui.inspection.util.ThreadUtils.runOnMainThread$lambda-0(ThreadUtils.kt:47)
                         E      at androidx.compose.ui.inspection.util.ThreadUtils.lambda$KCDFJVJaPoSc4QBEsn7LNXYhyn4(Unknown Source:0)
                         E      at androidx.compose.ui.inspection.util.-$$Lambda$ThreadUtils$KCDFJVJaPoSc4QBEsn7LNXYhyn4.run(Unknown Source:4)
                         E      at android.os.Handler.handleCallback(Handler.java:938)
                         E      at android.os.Handler.dispatchMessage(Handler.java:99)
                         E      at android.os.Looper.loopOnce(Looper.java:201)
                         E      at android.os.Looper.loop(Looper.java:288)
                         E      at android.app.ActivityThread.main(ActivityThread.java:7870)
                         E      at java.lang.reflect.Method.invoke(Native Method)
                         E      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                         E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Comments

bo...@google.com <bo...@google.com> Jun 13, 2022 05:16PM

Assigned to an...@google.com.

jl...@google.com <jl...@google.com> Jun 14, 2022 03:40PM

Reassigned to jl...@google.com.

jl...@google.com <jl...@google.com> #2Jul 20, 2022 11:07PM

Tentatively, the annotation should be something use-case-specific like @OutlinedNewApi that allows alternative build systems (e.g. not R8/D8) to make their own decisions. We'll provide a default Proguard configuration for R8, but it's not guaranteed this will work as intended -- outlining is automatic in newer versions, but it may be disabled.

jl...@google.com <jl...@google.com> #3Jul 21, 2022 11:26PM

Accepted by jl...@google.com.

Just as an FYI, this was enabled in AGP 2 years ago (AGP 7.3 as far as I remember), ag/18426192, so for AGP users it might fine to just remove the rule for @DoNotInline. I like the @OutlinedNewApi to make it clear what this is for other consumers to handle it as they see fit.

jl...@google.com <jl...@google.com> #4Jul 22, 2022 11:51PM

Marked as fixed.

This article from Morten Krogh-Jespersen suggests it wasn't (perma-)enabled by default until AGP 8.1, which is only <redacted>% of users.

Given the failure mode can include run-time crashes, that's not an acceptable level of usage.

jl...@google.com <jl...@google.com> #5Oct 31, 2022 03:25PM

I think you can still include a top-level proguard.txt, and it will be used by versions that do not support the com.android.tools format. E.g. Kotlin Coroutines library does this

Issue 235526153