Fixed
Status Update
Comments
bo...@google.com <bo...@google.com>
jl...@google.com <jl...@google.com>
jl...@google.com <jl...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 39bec9053dc95b74897bad9f17531c5ee505a3c1
Author: Nader Jawad <njawad@google.com>
Date: Mon Jun 24 16:10:48 2019
Created factory method for BlendMode Color Filter
Separated PaintCompat helper methods to enable creation of
a color filter with a provided color and BlendModeCompat parameter.
This factory will create either a BlendModeColorFilter or a
PorterDuffColorFilter based on capabilities of the given API level.
A BlendModeColorFilterCompat API is not feasible as the underlying
framework primitives are package private, so a static factory is
created instead.
Moved mapping logic out of PaintCompat into BlendModeUtils to be shared
between ColorFilterCompat and PaintCompat
Test: Updated PaintTest to leverage underlying ColorFilterCompat and
BlendModeUtils APIs
Bug: 135943149
Change-Id: Ifd99f8b406744e4e165d268d75fe650e89917e0b
M core/core-ktx/api/1.2.0-alpha03.txt
M core/core-ktx/api/current.txt
M core/core-ktx/src/main/java/androidx/core/graphics/Paint.kt
M core/core/api/1.2.0-alpha03.txt
M core/core/api/current.txt
A core/core/src/androidTest/java/androidx/core/graphics/BlendModeColorFilterCompatTest.java
M core/core/src/androidTest/java/androidx/core/graphics/PaintTest.java
A core/core/src/main/java/androidx/core/graphics/BlendModeColorFilterCompat.java
M core/core/src/main/java/androidx/core/graphics/BlendModeCompat.java
A core/core/src/main/java/androidx/core/graphics/BlendModeUtils.java
M core/core/src/main/java/androidx/core/graphics/PaintCompat.java
https://android-review.googlesource.com/987260
https://goto.google.com/android-sha1/39bec9053dc95b74897bad9f17531c5ee505a3c1
Branch: androidx-master-dev
commit 39bec9053dc95b74897bad9f17531c5ee505a3c1
Author: Nader Jawad <njawad@google.com>
Date: Mon Jun 24 16:10:48 2019
Created factory method for BlendMode Color Filter
Separated PaintCompat helper methods to enable creation of
a color filter with a provided color and BlendModeCompat parameter.
This factory will create either a BlendModeColorFilter or a
PorterDuffColorFilter based on capabilities of the given API level.
A BlendModeColorFilterCompat API is not feasible as the underlying
framework primitives are package private, so a static factory is
created instead.
Moved mapping logic out of PaintCompat into BlendModeUtils to be shared
between ColorFilterCompat and PaintCompat
Test: Updated PaintTest to leverage underlying ColorFilterCompat and
BlendModeUtils APIs
Bug: 135943149
Change-Id: Ifd99f8b406744e4e165d268d75fe650e89917e0b
M core/core-ktx/api/1.2.0-alpha03.txt
M core/core-ktx/api/current.txt
M core/core-ktx/src/main/java/androidx/core/graphics/Paint.kt
M core/core/api/1.2.0-alpha03.txt
M core/core/api/current.txt
A core/core/src/androidTest/java/androidx/core/graphics/BlendModeColorFilterCompatTest.java
M core/core/src/androidTest/java/androidx/core/graphics/PaintTest.java
A core/core/src/main/java/androidx/core/graphics/BlendModeColorFilterCompat.java
M core/core/src/main/java/androidx/core/graphics/BlendModeCompat.java
A core/core/src/main/java/androidx/core/graphics/BlendModeUtils.java
M core/core/src/main/java/androidx/core/graphics/PaintCompat.java
jl...@google.com <jl...@google.com> #3
I found the problem.
I still don't have a test that show the original problem.
But I can simulate the situation and see a similar failure.
jl...@google.com <jl...@google.com> #4
This fix will be included in the compose 1.3.0-alpha03 release
jl...@google.com <jl...@google.com> #5
This is also fixed in compose 1.2.1
Description
Build: AI-213.7172.25.2211.8624637, 202205202352,
AI-213.7172.25.2211.8624637, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.4, screens 3024.0x1964.0, 5120.0x2880.0; Retina
AS: Electric Eel | 2022.1.1 Canary 3 Kotlin plugin: 213-1.6.21-release-for-android-studio-AS6777.52 Android Gradle Plugin: (plugin information not found) Gradle: 7.4.2 Gradle JDK: version 11.0.15 NDK: from local.properties: (not specified), latest from SDK: (not found) CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
Compose 1.2.0-beta01