Derived states updates don't cause recomposition [236618362]

Fixed

Bug

Status Update

No update yet.

Description

as...@google.com

created issue #1

Jun 20, 2022 03:44PM

Jetpack Compose version: 1.2.0-rc01

Derived states updates don't cause recomposition in some cases after updating to 1.2.0-rc01.

Steps to repro:

Checkout commit before https://github.com/google/horologist/commit/03e7051eda58430e1e5138daafcaed8beca85bf1
Open Nav sample in the repo
Observe time text on top of the screen is not moving

Comments

ap...@google.com <ap...@google.com> #2Jun 21, 2022 06:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4945dfa31180f343697de5810b99ec80a48dc386
Author: Andrei Shikov <ashikov@google.com>
Date: Mon Jun 20 16:09:06 2022

Prevent removing derived state from composition when it is read in other scopes

Derived state observations were previously unconditionally removed from the recompose scope and composition together, which broke other scopes which might be still observing derived state.

This change only removes derived state instances if it is no longer observed by other scopes.

Fixes: 236618362
Test: CompositionAndDerivedStateTests#observingDerivedStateInMultipleScopes
Change-Id: I92e7c8702efecb33bea3ea3effe9ec47e2a6ae5b

M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/CompositionAndDerivedStateTests.kt

https://android-review.googlesource.com/2131915

na...@google.com <na...@google.com> #3Oct 24, 2022 01:37PM

The following release(s) address this bug:

androidx.compose.runtime:runtime:1.3.0

Issue 236618362

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jun 21, 2022 06:21PM

na...@google.com <na...@google.com> #3Oct 24, 2022 01:37PM

Add comment

Issue metadata