Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 82941c128d8ef57e36a739fcfacdf006e94d1a4a
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Thu Oct 15 17:31:58 2020
[GH] Don't cache fragment classes across different class loaders
## Proposed Changes
- Don't cache fragment classes across different class loaders inside `FragmentFactory`.
## Testing
Test: Added tests to verify the change
## Issues Fixed
Fixes: 113886460
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/87 .
Resolves #87
Github-Pr-Head-Sha: e5f5916840904cab91884e3f525fde4a71d5a7dc
GitOrigin-RevId: babb5e1aedec7d815aa38a50ebca89d6c3e93f00
Change-Id: I07d5541a45ccadcf7159854818000455e245d118
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentFactory.java
A fragment/fragment/src/test/java/androidx/fragment/app/FragmentFactoryTest.kt
https://android-review.googlesource.com/1462523
Branch: androidx-master-dev
commit 82941c128d8ef57e36a739fcfacdf006e94d1a4a
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Thu Oct 15 17:31:58 2020
[GH] Don't cache fragment classes across different class loaders
## Proposed Changes
- Don't cache fragment classes across different class loaders inside `FragmentFactory`.
## Testing
Test: Added tests to verify the change
## Issues Fixed
Fixes: 113886460
This is an imported pull request from
Resolves #87
Github-Pr-Head-Sha: e5f5916840904cab91884e3f525fde4a71d5a7dc
GitOrigin-RevId: babb5e1aedec7d815aa38a50ebca89d6c3e93f00
Change-Id: I07d5541a45ccadcf7159854818000455e245d118
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentFactory.java
A fragment/fragment/src/test/java/androidx/fragment/app/FragmentFactoryTest.kt
Description
Component used: Fragment
Version used: 1.5.0
Devices/Android versions reproduced on: N/A lint only
In newer versions of lint (seemingly 30.4.x, but possibly 30.3.x), there was an API change that breaks the DialogFragmentCallbacksDetector lint.
(node.sourcePsi as? KtClassOrObject)) is backward compatible. It would be great if this could be backported to a patch release for 1.5.x.