AnimatedContent sets incorrect target animation on interrupt [238662479]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jul 11, 2022 08:05PM

Jetpack Compose version: 1.2.0-rc03
Jetpack Compose component used: AnimatedContent
Android Studio Build: 2022.1.1. Canary 7
Kotlin version: 1.7.1

When using AnimatedContent to animate between two contents, if you interrupt during the animation and attempt to return to the previous state, the target gets the wrong animation.

Given:

var count by remember { mutableStateOf(0) }
AnimatedContent(targetState = count, transitionSpec = {
  if (targetState == 0) {
    fadeIn(tween(2000)) with slideOut(
      tween(2000),
      targetOffset = { fullSize -> IntOffset(0, fullSize.height / 2) }) + fadeOut( 
      tween(2000))
  } else {
    fadeIn(tween(2000)) with fadeOut(tween(2000))
  }
}) { state ->
  if (state == 0) {
    Box(modifier = Modifier
      .fillMaxSize()
      .background(Color.Green)
      .clickable { count++ }
    )
  } else if (state == 1) {
    Box(modifier = Modifier
      .fillMaxSize()
      .background(Color.Red)
    )
    BackHandler { count-- }
  }
}

When starting from the green screen, starting animation to the red screen and interrupting that animation to return to green the green animation incorrectly does a slideIn() transition after the interrupt.

Expected:
The Green screen should always be fading. When we go from green to red it should be fading out. When returning back to green, because it is the targetState it should get the entering animation, which is a fadeIn() and the Red screen should be fading out.

Observed:
On interruption, the Green screen gets the exit transition, which in this case is the slideOut() and reverses it so it ends up doing a slideIn() and the Red screen fades out.

Since the targetState is always the final state of the AnimatedContent, it should always receive whatever enter transition in passed into the transitionSpec.

Comments

ti...@google.com <ti...@google.com> #2Jul 11, 2022 10:18PM

Reassigned to ti...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ti...@gmail.com <ti...@gmail.com> #3Aug 11, 2022 06:09PM

I'm having an issue with Compose navigation-animation which might be caused by this.

I have two screens: List and Details.

List screen uses default transitions.

Details screen uses the following transitions:

enterTransition = {
    slideIntoContainer(
        AnimatedContentScope.SlideDirection.Up,
        animationSpec = tween(400)
    )
},
popExitTransition = {
    slideOutOfContainer(
        AnimatedContentScope.SlideDirection.Down,
        animationSpec = tween(200)
    )
},

The video is showing the bug vs expected. It's hard to describe: after clicking the back button before the transition to the Details screen was completed, the List screen moves up a little.

Message last modified on Aug 11, 2022 06:12PM

compose-navigation-animation-bug.mp4

7 MB

Download

ap...@google.com <ap...@google.com> #4Sep 30, 2022 06:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7e3b52b20e73c397019f474ab15eb8ea64a872d3
Author: Doris Liu <tianliu@google.com>
Date: Thu Sep 29 18:06:42 2022

Fix incorrect interruption animation in AnimatedContent

Bug: 238662479

Test: included
Change-Id: I86bb98800070f4584e30a1d0a4edec274b0c7e5c

A compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/visualinspection/AnimatedContentWithInterruptions.kt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/AnimatedContentTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedContent.kt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimationDemos.kt

https://android-review.googlesource.com/2239235

ti...@google.com <ti...@google.com> Sep 30, 2022 06:43PM

Marked as fixed.

na...@google.com <na...@google.com> #5Oct 24, 2022 01:37PM

The following release(s) address this bug:

androidx.compose.animation:animation:1.4.0-alpha01

[Deleted User] <[Deleted User]> #6Nov 25, 2022 11:35AM

Why is this not released as a hotfix so stable users can get the bug fix right away?

pe...@gmail.com <pe...@gmail.com> #7Nov 27, 2022 10:58AM

He is mine just saying his time is my time