AnimatedContent sets incorrect target animation on interrupt [238662479]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jul 11, 2022 08:05PM

Jetpack Compose version: 1.2.0-rc03
Jetpack Compose component used: AnimatedContent
Android Studio Build: 2022.1.1. Canary 7
Kotlin version: 1.7.1

When using AnimatedContent to animate between two contents, if you interrupt during the animation and attempt to return to the previous state, the target gets the wrong animation.

Given:

var count by remember { mutableStateOf(0) }
AnimatedContent(targetState = count, transitionSpec = {
  if (targetState == 0) {
    fadeIn(tween(2000)) with slideOut(
      tween(2000),
      targetOffset = { fullSize -> IntOffset(0, fullSize.height / 2) }) + fadeOut( 
      tween(2000))
  } else {
    fadeIn(tween(2000)) with fadeOut(tween(2000))
  }
}) { state ->
  if (state == 0) {
    Box(modifier = Modifier
      .fillMaxSize()
      .background(Color.Green)
      .clickable { count++ }
    )
  } else if (state == 1) {
    Box(modifier = Modifier
      .fillMaxSize()
      .background(Color.Red)
    )
    BackHandler { count-- }
  }
}

When starting from the green screen, starting animation to the red screen and interrupting that animation to return to green the green animation incorrectly does a slideIn() transition after the interrupt.

Expected:
The Green screen should always be fading. When we go from green to red it should be fading out. When returning back to green, because it is the targetState it should get the entering animation, which is a fadeIn() and the Red screen should be fading out.

Observed:
On interruption, the Green screen gets the exit transition, which in this case is the slideOut() and reverses it so it ends up doing a slideIn() and the Red screen fades out.

Since the targetState is always the final state of the AnimatedContent, it should always receive whatever enter transition in passed into the transitionSpec.

Comments

ti...@google.com <ti...@google.com> #2Jul 11, 2022 10:18PM

Reassigned to ti...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ti...@gmail.com <ti...@gmail.com> #3Aug 11, 2022 06:09PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Message last modified on Aug 11, 2022 06:12PM

compose-navigation-animation-bug.mp4

7 MB

Download

ap...@google.com <ap...@google.com> #4Sep 30, 2022 06:41PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ti...@google.com <ti...@google.com> Sep 30, 2022 06:43PM

Marked as fixed.

na...@google.com <na...@google.com> #5Oct 24, 2022 01:37PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

[Deleted User] <[Deleted User]> #6Nov 25, 2022 11:35AM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

pe...@gmail.com <pe...@gmail.com> #7Nov 27, 2022 10:58AM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!