Status Update
No update yet.
Comments
ap...@google.com
There are a few more changes to DataStoreImpl's logic which makes a reevaluation necessary.
Now with Yigit's changes, datastore's
A ReadException is not automatically handled and stays in cache until a updateData call which revisits handleUpdate call proceeds to
ap...@google.com
can we create a test failure for this? I'm not fully sure what is going wrong here, it is a bit hard to track w/o a repro case.
ap...@google.com
can we create a test failure for this?
Sure I'm working on the code changes.
In the meantime I think this bug might makes the errors e.g. in
ap...@google.com
Branch: androidx-main
commit 383a67d0e5a9b35e394b212db35bdee892b167fb
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Wed Feb 21 17:04:40 2024
Add tests to verify that CorruptionException is not properly handled after DataStore's first disk read. If the internal state is [ReadException], it will not recover for the rest of the lifecycle.
Fix in the follow up change.
Bug: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Ie77900b5c2cb8fb8e55d4c40364491dea9250784
M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt
ap...@google.com
Branch: androidx-main
commit 70085fee2af278bb8c3e45e1acfcf3f4cbb05c5a
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Thu Feb 22 15:08:34 2024
DataStore handles CorruptionException for all reads and writes.
Before this change, DataStore didn't handle the CorruptionException for both the reads and writes after initialization.
Fixes: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Icb07b140017b62a905d3626f82aeb993f636c053
M datastore/datastore-core/src/commonMain/kotlin/androidx/datastore/core/DataStoreImpl.kt
M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.datastore:datastore-core:1.1.0-beta02androidx.datastore:datastore-core-android:1.1.0-beta02androidx.datastore:datastore-core-iosarm64:1.1.0-beta02androidx.datastore:datastore-core-iossimulatorarm64:1.1.0-beta02androidx.datastore:datastore-core-iosx64:1.1.0-beta02androidx.datastore:datastore-core-jvm:1.1.0-beta02androidx.datastore:datastore-core-linuxx64:1.1.0-beta02androidx.datastore:datastore-core-macosarm64:1.1.0-beta02androidx.datastore:datastore-core-macosx64:1.1.0-beta02
ap...@google.com
Branch: androidx-main
commit 684e629ec17072ea31aae485492b4fd2b10043f6
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Aug 30 18:47:45 2022
Converting SupportSQLiteDatabase from *.java to *.kt.
Test: N/A
Bug: 240707042
Relnote: Converting SupportSQLiteDatabase from *.java to *.kt.
Change-Id: I251619c5d7a0869b89fe23217abd768c295f5e1f
M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperFactoryTest.kt
M sqlite/sqlite-ktx/build.gradle
M sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.kt
M sqlite/sqlite-ktx/src/main/java/androidx/sqlite/db/SupportSQLiteDatabaseExt.kt
A sqlite/sqlite/api/current.ignore
A sqlite/sqlite/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M sqlite/integration-tests/inspection-sqldelight-testapp/build.gradle
M sqlite/sqlite-inspection/build.gradle
M sqlite/sqlite/api/current.txt
M sqlite/integration-tests/inspection-room-testapp/build.gradle
M room/room-ktx/src/test/java/androidx/room/MigrationTest.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.kt
M sqlite/sqlite-framework/build.gradle
M sqlite/sqlite/api/public_plus_experimental_current.txt
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
M sqlite/sqlite/build.gradle
M sqlite/sqlite/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt
ap...@google.com
Branch: androidx-main
commit 89bfc918a0bfe3237470262b75fd4a71c4048a1e
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Aug 30 18:07:34 2022
Initial code check-in for renaming SupportSQLiteDatabase from *.java to *.kt.
Test: N/A
Bug: 240707042
Relnote: Initial code check-in for renaming SupportSQLiteDatabase from *.java to *.kt.
Change-Id: I5627dba94bad99b1110778cd3e770c1f2a996294
M sqlite/sqlite/src/main/java/androidx/sqlite/db/SupportSQLiteDatabase.kt
el...@google.com
na...@google.com
This bug was linked in a change in the following release(s):
androidx.room:room-ktx:2.5.0-beta01androidx.room:room-runtime:2.5.0-beta01androidx.sqlite:sqlite:2.3.0-beta01androidx.sqlite:sqlite-framework:2.3.0-beta01androidx.sqlite:sqlite-ktx:2.3.0-beta01androidx.work:work-gcm:2.8.0-beta01androidx.work:work-multiprocess:2.8.0-beta01androidx.work:work-runtime:2.8.0-beta01androidx.work:work-runtime-ktx:2.8.0-beta01androidx.work:work-testing:2.8.0-beta01
Description
This involves converting the following sub-directories in the following order: sqlite sqlite-framework sqlite-ktx integration-tests