Create constraints between lifecycle artifacts [242871265]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Aug 17, 2022 05:23PM

Component used: Lifecycle

Version used: 2.6.0-alpha01

Until feature requests such as b/146802533 are released, Gradle does not do any enforcement that Lifecycle artifacts are of the same version (i.e., you could mix and match lifecycle-common:2.6.0-alpha01 with lifecycle-runtime:2.5.1).

Gradle supports constraints, which ensure that upgrading a transitive dependency will also upgrade other dependencies.

We should manually add two way constraints, similarly to what was done for Paging in b/235256201, to the various lifecycle artifacts, which will help Gradle enforce the same version policy we intend.

The pairs of artifacts we should add constraints to should match the dependencies we have right now, which should mean the list looks something like:

lifecycle-common and lifecycle-common-java8
lifecycle-common and lifecycle-runtime
lifecycle-runtime and lifecycle-runtime-ktx
lifecycle-runtime and lifecycle-runtime-compose
lifecycle-runtime and lifecycle-runtime-testing
lifecycle-livedata-core and lifecycle-livedata-core-ktx
lifecycle-livedata-core and lifecycle-livedata
lifecycle-livedata and lifecycle-livedata-ktx
lifecycle-reactivestreams and lifecycle-reactivestreams-ktx
lifecycle-viewmodel and lifecycle-viewmodel-ktx
lifecycle-viewmodel and lifecycle-viewmodel-savedstate
lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose

Comments

ap...@google.com <ap...@google.com> #2Aug 20, 2022 05:23AM

the abovementioned issue is reproducible on "1.0.0-beta02" version

ap...@google.com <ap...@google.com> #3Aug 20, 2022 07:25AM

Hi, thanks for reporting. We'll have a look. In the meantime, you can probably move padding, to page layout?

ap...@google.com <ap...@google.com> #4Aug 20, 2022 07:25AM

I intentionally set the padding to ViewPager2 to allow offscreen pages to be partially visible

ap...@google.com <ap...@google.com> #5Aug 20, 2022 07:25AM

Sorry didn't realise that from your GIF. Any chance you could share a minimum sample app with us so we can investigate?

In the meantime, could you try this as a workaround and let us know if it fixes the issue:
`val rv = viewpager2.getChildAt(0) as RecyclerView` and set padding and android:clipToPadding on it directly (and nothing on ViewPager2)
?

ap...@google.com <ap...@google.com> #6Aug 20, 2022 07:25AM

I've tried your solution:

Tried to set left and right padding of the underlying recyclerView, like so:
(pager.getChildAt(0) as RecyclerView).apply {
//hijacking padding from pager
setPadding(
pager.paddingLeft, //resolves to 53
pager.paddingTop,
pager.paddingRight, //resolves to 53
pager.paddingBottom
)
//reseting padding on pager
pager.setPadding(0, pager.paddingTop, 0, pager.paddingBottom)
clipToPadding = false
}

got this exception:

E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.easecentral.ease.debug, PID: 23890
java.lang.IllegalStateException: Page can only be offset by a positive amount, not by -53
at androidx.viewpager2.widget.ScrollEventAdapter.updateScrollEventValues(ScrollEventAdapter.java:260)
at androidx.viewpager2.widget.ScrollEventAdapter.onScrolled(ScrollEventAdapter.java:168)
at androidx.recyclerview.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:5152)
at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4212)
at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3843)
at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4385)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at androidx.viewpager2.widget.ViewPager2.onLayout(ViewPager2.java:511)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1915)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.widget.ScrollView.onLayout(ScrollView.java:1552)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
at com.android.internal.policy.DecorView.onLayout(DecorView.java:753)
at android.view.View.layout(View.java:20672)
at android.view.ViewGroup.layout(ViewGroup.java:6194)
at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2792)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2319)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1460)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7183)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:949)
at android.view.Choreographer.doCallbacks(Choreographer.java:761)
at android.view.Choreographer.doFrame(Choreographer.java:696)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
at android.os.Handler.handleCallback(Handler.java:873)
E/AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

I'll try to provide some minimum sample app, but can't promise anything right now, as I'm swarmed with other projects

ap...@google.com <ap...@google.com> #7Aug 22, 2022 06:12PM

That's our internal checks kicking-in. For now I can only offer a workaround of disabling overscroll, which I recognise is not ideal.

We'll have a look at some point - sample app will help.

Thanks again for reporting!

ap...@google.com <ap...@google.com> #8Aug 22, 2022 06:12PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 450e0c3c50cb320b0f6222626034455a48aca54b
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Aug 13 10:18:41 2019

Take RV padding and item decorations into account

RecyclerView's padding and item decorations shift the position of the
current page when idle. The padding also shrinks the page size.

Bug: 139012032
Test: ./gradlew viewpager2:cC

Change-Id: Ia03646db95bb8d392408bce4d22430981c3f9171

M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/PaddingMarginDecorationTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1101299

https://goto.google.com/android-sha1/450e0c3c50cb320b0f6222626034455a48aca54b

ap...@google.com <ap...@google.com> #9Aug 23, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6faf0d9fbabf6b59465ed135b4b44100bb2b3806
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Aug 14 16:33:05 2019

Always snap to center between padding

Even when clipToPadding is false, the center of RecyclerView is still
the middle of the rectangle described on the inside of the padding, not
the middle of the rectangle described on the outside of the padding.

Bug: 139452422
Bug: 139012032
Test: ./gradlew recyclerview:recyclerview:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.recyclerview.widget.PagerSnapHelperTest

Change-Id: I8869f13fdd6a45b49ee3b288ff83e224faffa3c9

M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/PagerSnapHelper.java
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PaddingMarginDecorationTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/swipe/PageSwiperEspresso.java
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/swipe/PageSwiperManual.java

https://android-review.googlesource.com/1103182

https://goto.google.com/android-sha1/6faf0d9fbabf6b59465ed135b4b44100bb2b3806

ap...@google.com <ap...@google.com> #10Aug 23, 2022 07:35PM

Hi, in the upcoming release of viewpager2, you will be able to set padding on RecyclerView. Note that if you have asymmetric padding, you will also need the upcoming release of recyclerview.

Closing the bug for now, but please feel free to re-open this if the suggested releases don't fix your problem, so we can continue the investigation.

ap...@google.com <ap...@google.com> #11Aug 23, 2022 07:57PM

beta04 will allow for a workaround (set padding in the inner RecyclerView), but we will keep this open for a long-term fix

ap...@google.com <ap...@google.com> #12Aug 24, 2022 08:02PM

Who this

ap...@google.com <ap...@google.com> #13Aug 26, 2022 04:47PM

Marked as fixed.

Looping under a more general overscroll buganizer item.

ap...@google.com <ap...@google.com> #14Aug 26, 2022 04:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0598f5400a797fc9e31858e0d8a1b575ad7158a7
Author: Sanura N'Jaka <sanura@google.com>
Date: Thu Aug 18 18:28:20 2022

Add project dependency constraint between lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose

Added bi-directional project version constraint between
lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose.
If both artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle automatically
bumping up either version to meet constraint.

Test: N/A
Bug: 242871265
Change-Id: I2810d3afbe0cb8e8e387d1bc64eb3c698285d471

M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle

https://android-review.googlesource.com/2190016

na...@google.com <na...@google.com> #15Sep 12, 2022 05:51PM

This bug was linked in a change in the following release(s):

androidx.lifecycle:lifecycle-common:2.6.0-alpha02
androidx.lifecycle:lifecycle-livedata:2.6.0-alpha02
androidx.lifecycle:lifecycle-livedata-core:2.6.0-alpha02
androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.0-alpha02
androidx.lifecycle:lifecycle-livedata-ktx:2.6.0-alpha02
androidx.lifecycle:lifecycle-reactivestreams:2.6.0-alpha02
androidx.lifecycle:lifecycle-reactivestreams-ktx:2.6.0-alpha02
androidx.lifecycle:lifecycle-runtime:2.6.0-alpha02
androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha02
androidx.lifecycle:lifecycle-runtime-ktx:2.6.0-alpha02
androidx.lifecycle:lifecycle-runtime-testing:2.6.0-alpha02
androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02
androidx.lifecycle:lifecycle-viewmodel-compose:2.6.0-alpha02
androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.0-alpha02
androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.0-alpha02

da...@google.com <da...@google.com> #16Sep 28, 2022 02:38PM

This release seems to have conflicting artifacts in the classpath. When both:

androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.0-alpha02

androidx-lifecycle:lifecycle-livedata-ktx:2.6.0-alpha02

are added as dependencies, the following error pops up:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sync:sync-test:checkProdDebugAndroidTestDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
   > Duplicate class androidx.lifecycle.ViewModelLazy found in modules lifecycle-viewmodel-2.6.0-alpha02-runtime (androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02) and lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1)
     Duplicate class androidx.lifecycle.ViewTreeViewModelKt found in modules lifecycle-viewmodel-2.6.0-alpha02-runtime (androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02) and lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1)
     
     Go to the documentation to learn how to <a href="d.android.com/r/tools/classpath-sync-errors">Fix dependency resolution errors</a>.

Downgrading to 2.6.0-alpha01 fixes this.

sa...@google.com <sa...@google.com> #17Oct 17, 2022 05:23PM

As an update to the above comment from TJ, this issue has been fixed and will be available in Lifecycle 2.6.0-alpha03.

na...@google.com <na...@google.com> #18Oct 24, 2022 01:38PM

The following release(s) address this bug:

androidx.lifecycle:lifecycle-runtime:2.6.0-alpha03
androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha03
androidx.lifecycle:lifecycle-viewmodel-compose:2.6.0-alpha03
androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.0-alpha03