Fixed
Status Update
No update yet.
Comments
ap...@google.com
Please attach a sample project that reproduces your issue.
ap...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bd065925676170c8453321e970d455fac06b8d3d
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 28 15:47:16 2019
Add ProGuard rules for DrawerArrowDrawable.setProgress()
setProgress() is called via an ObjectAnimator and
therefore needs to be specifically kept when
obfuscating with ProGuard.
Test: tested in sample project attached to bug
Change-Id: I9c420ce728c5cb887d29df9f856bfd31f5bdbcdf
Fixes: 123449431
M navigation/ui/build.gradle
A navigation/ui/proguard-rules.pro
https://android-review.googlesource.com/887876
https://goto.google.com/android-sha1/bd065925676170c8453321e970d455fac06b8d3d
Branch: androidx-master-dev
commit bd065925676170c8453321e970d455fac06b8d3d
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 28 15:47:16 2019
Add ProGuard rules for DrawerArrowDrawable.setProgress()
setProgress() is called via an ObjectAnimator and
therefore needs to be specifically kept when
obfuscating with ProGuard.
Test: tested in sample project attached to bug
Change-Id: I9c420ce728c5cb887d29df9f856bfd31f5bdbcdf
Fixes: 123449431
M navigation/ui/build.gradle
A navigation/ui/proguard-rules.pro
ap...@google.com
We've added the appropriate ProGuard configuration and it'll be available in the next release.
As a workaround, you can add the following to your ProGuard configuration:
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
As a workaround, you can add the following to your ProGuard configuration:
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
ap...@google.com
Sure, thanks for the quick fix.
ap...@google.com
I had to use the androidx version for proguard rules
-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
ap...@google.com
Yep, Jetifier will automatically convert ProGuard rules packaged with libraries, but if you're adding the ProGuard files to your own project, you'll need to make sure to use the AndroidX equivalents if your project is using AndroidX.
ap...@google.com
This issue seems to be back again? ... I'm using v2.2.0-rc02 and have run into the issue. Using the proguard rule below (mentioned in #7 above) to work around the issue seems to fix it.
-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
Looking at the commit linked above that fixed the issue originally, it adds a proguard rule to fix the issue for the old support library, but not a rule for the AndroidX equivalent. #8 suggests that Jetifier will handle the AndroidX conversion, but that doesn't seem to be the case? I'm using AndroidX and Jetifier and without the specfic -keep rule above for androidx, my back arrow icon gets removed in release (minified) builds.
-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
Looking at the commit linked above that fixed the issue originally, it adds a proguard rule to fix the issue for the old support library, but not a rule for the AndroidX equivalent. #8 suggests that Jetifier will handle the AndroidX conversion, but that doesn't seem to be the case? I'm using AndroidX and Jetifier and without the specfic -keep rule above for androidx, my back arrow icon gets removed in release (minified) builds.
ap...@google.com
Re #9 - I filed
ap...@google.com
Do you have jetifier enabled by adding android.enableJetifier=true in your gradle.properties file? If so it should work fine. We opened a bug to change the rule over so that enabling jetifier is not required in a future release (
ap...@google.com
Re #11, I do have jetifier enabled, and still see the regression mentioned in #9
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 27355f7c30e816f6636928caeef29d473b896e28
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Aug 24 22:41:48 2022
Add project dependency constraint between lifecycle-viewmodel-savedstate and lifecycle-livedata-core
Added bi-directional project version constraint between
lifecycle-viewmodel-savedstate and lifecycle-livedata-core.
If both artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle automatically
bumping up either version to meet constraint.
Test: N/A
Fixes: 242871265
Change-Id: I94cc3ddd0f86033653c1477cf3f8ad8a1d93adae
M lifecycle/lifecycle-livedata-core/build.gradle
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
https://android-review.googlesource.com/2193733
Branch: androidx-main
commit 27355f7c30e816f6636928caeef29d473b896e28
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Aug 24 22:41:48 2022
Add project dependency constraint between lifecycle-viewmodel-savedstate and lifecycle-livedata-core
Added bi-directional project version constraint between
lifecycle-viewmodel-savedstate and lifecycle-livedata-core.
If both artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle automatically
bumping up either version to meet constraint.
Test: N/A
Fixes: 242871265
Change-Id: I94cc3ddd0f86033653c1477cf3f8ad8a1d93adae
M lifecycle/lifecycle-livedata-core/build.gradle
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0598f5400a797fc9e31858e0d8a1b575ad7158a7
Author: Sanura N'Jaka <sanura@google.com>
Date: Thu Aug 18 18:28:20 2022
Add project dependency constraint between lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose
Added bi-directional project version constraint between
lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose.
If both artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle automatically
bumping up either version to meet constraint.
Test: N/A
Bug: 242871265
Change-Id: I2810d3afbe0cb8e8e387d1bc64eb3c698285d471
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
https://android-review.googlesource.com/2190016
Branch: androidx-main
commit 0598f5400a797fc9e31858e0d8a1b575ad7158a7
Author: Sanura N'Jaka <sanura@google.com>
Date: Thu Aug 18 18:28:20 2022
Add project dependency constraint between lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose
Added bi-directional project version constraint between
lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose.
If both artifacts are in the dependency tree, their versions
should match. This will now be enforced by gradle automatically
bumping up either version to meet constraint.
Test: N/A
Bug: 242871265
Change-Id: I2810d3afbe0cb8e8e387d1bc64eb3c698285d471
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
na...@google.com
This bug was linked in a change in the following release(s):
androidx.lifecycle:lifecycle-common:2.6.0-alpha02androidx.lifecycle:lifecycle-livedata:2.6.0-alpha02androidx.lifecycle:lifecycle-livedata-core:2.6.0-alpha02androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.0-alpha02androidx.lifecycle:lifecycle-livedata-ktx:2.6.0-alpha02androidx.lifecycle:lifecycle-reactivestreams:2.6.0-alpha02androidx.lifecycle:lifecycle-reactivestreams-ktx:2.6.0-alpha02androidx.lifecycle:lifecycle-runtime:2.6.0-alpha02androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha02androidx.lifecycle:lifecycle-runtime-ktx:2.6.0-alpha02androidx.lifecycle:lifecycle-runtime-testing:2.6.0-alpha02androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02androidx.lifecycle:lifecycle-viewmodel-compose:2.6.0-alpha02androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.0-alpha02androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.0-alpha02
da...@google.com
This release seems to have conflicting artifacts in the classpath. When both:
androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.0-alpha02
androidx-lifecycle:lifecycle-livedata-ktx:2.6.0-alpha02
are added as dependencies, the following error pops up:
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':sync:sync-test:checkProdDebugAndroidTestDuplicateClasses'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable
> Duplicate class androidx.lifecycle.ViewModelLazy found in modules lifecycle-viewmodel-2.6.0-alpha02-runtime (androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02) and lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1)
Duplicate class androidx.lifecycle.ViewTreeViewModelKt found in modules lifecycle-viewmodel-2.6.0-alpha02-runtime (androidx.lifecycle:lifecycle-viewmodel:2.6.0-alpha02) and lifecycle-viewmodel-ktx-2.3.1-runtime (androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1)
Go to the documentation to learn how to <a href="d.android.com/r/tools/classpath-sync-errors">Fix dependency resolution errors</a>.
Downgrading to 2.6.0-alpha01 fixes this.
sa...@google.com
As an update to the above comment from TJ, this issue has been fixed and will be available in Lifecycle 2.6.0-alpha03.
na...@google.com
The following release(s) address this bug:
androidx.lifecycle:lifecycle-runtime:2.6.0-alpha03androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha03androidx.lifecycle:lifecycle-viewmodel-compose:2.6.0-alpha03androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.0-alpha03
Description
Component used: Lifecycle
Version used: 2.6.0-alpha01
Until feature requests such as
lifecycle-common:2.6.0-alpha01withlifecycle-runtime:2.5.1).Gradle supports
We should manually add two way constraints, similarly to what was done for Paging in
The pairs of artifacts we should add constraints to should match the dependencies we have right now, which should mean the list looks something like: