Create constraints between lifecycle artifacts [242871265]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Aug 17, 2022 05:23PM

Component used: Lifecycle

Version used: 2.6.0-alpha01

Until feature requests such as b/146802533 are released, Gradle does not do any enforcement that Lifecycle artifacts are of the same version (i.e., you could mix and match lifecycle-common:2.6.0-alpha01 with lifecycle-runtime:2.5.1).

Gradle supports constraints, which ensure that upgrading a transitive dependency will also upgrade other dependencies.

We should manually add two way constraints, similarly to what was done for Paging in b/235256201, to the various lifecycle artifacts, which will help Gradle enforce the same version policy we intend.

The pairs of artifacts we should add constraints to should match the dependencies we have right now, which should mean the list looks something like:

lifecycle-common and lifecycle-common-java8
lifecycle-common and lifecycle-runtime
lifecycle-runtime and lifecycle-runtime-ktx
lifecycle-runtime and lifecycle-runtime-compose
lifecycle-runtime and lifecycle-runtime-testing
lifecycle-livedata-core and lifecycle-livedata-core-ktx
lifecycle-livedata-core and lifecycle-livedata
lifecycle-livedata and lifecycle-livedata-ktx
lifecycle-reactivestreams and lifecycle-reactivestreams-ktx
lifecycle-viewmodel and lifecycle-viewmodel-ktx
lifecycle-viewmodel and lifecycle-viewmodel-savedstate
lifecycle-viewmodel-savedstate and lifecycle-viewmodel-compose

Comments

ap...@google.com <ap...@google.com> #2Aug 20, 2022 05:23AM

Project: platform/frameworks/support
Branch: androidx-main

commit 66494e2d6810347e6a3b41ec3f2665e598f108f0
Author: Ian Lake <ilake@google.com>
Date: Thu Apr 14 00:14:24 2022

Ensure that SavedStateHandle restores upon initial creation

runOnNextRecreation() only runs on the next time
the lifecycle reaches CREATED, not the first time.

By using a LifecycleObserver directly, we ensure that
each Lifecycle move causes a performRestore() to
consistently happen.

Test: existing tests pass, sample app works
BUG: 228865698
Relnote: "Fixed an issue where nesting one `NavHost` within
another `NavHost` in a non-primary bottom navigation tab
would lead to an `IllegalStateException` when using
multiple back stacks."

Change-Id: I11bd5173f035ae1da7922b4142fcedc0f3b54ff6

M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt

https://android-review.googlesource.com/2064518

ap...@google.com <ap...@google.com> #3Aug 20, 2022 07:25AM

Thanks for quick fix! Works well with latest snapshot.

ap...@google.com <ap...@google.com> #4Aug 20, 2022 07:25AM

Thanks for confirming! The fix will be in the next release of Lifecycle (2.5.0-beta01).

ap...@google.com <ap...@google.com> #5Aug 20, 2022 07:25AM

2.4.1 also has same issue

using jetpack compose / bottom navigation with NavHost

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

ap...@google.com <ap...@google.com> #6Aug 20, 2022 07:25AM

I am seeing a high occurance rate with 2.5.0-beta01 as well.

ap...@google.com <ap...@google.com> #7Aug 22, 2022 06:12PM

Re comment#5 and comment#6 - please file a new bug with a sample project that reproduces your issue. That would help rule out it being a duplicate of this issue where your remember around getBackStackEntry needs to be updated.

ap...@google.com <ap...@google.com> #8Aug 22, 2022 06:12PM

Hi, I recently came across this crash in my current project and I discovered that it happens when a Textfield was tapped and in focus, then the app was backgrounded. This would occur with all of the Textfields in the app.

We are using Compose version: 1.2.0-rc03
and jetpack lifecycle version: 2.4.1

Fatal Exception: java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:192)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:106)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:69)

ap...@google.com <ap...@google.com> #9Aug 23, 2022 04:43PM

Please file a new bug with a minimal sample project that reproduces your error.

ap...@google.com <ap...@google.com> #10Aug 23, 2022 07:35PM

Okay, we will get a sample project up soon. One thing I forgot to mention in the initial comment is that this crash occurs when we use backQueue.clear() to clear the back stack. We were able to come up with a solution/workaround by using popUpTo() as a way to clear the back stack, and after implementing that solution we saw no crashes when backgrounding the app while a textfield was in focus.

ap...@google.com <ap...@google.com> #11Aug 23, 2022 07:57PM

Re comment#10 - backQueue is not part of the public API surface and never has been. Calling anything on that is always, always, always the wrong thing to do.

ap...@google.com <ap...@google.com> #12Aug 24, 2022 08:02PM

Any updates? This issue is persistent for almost 6 months and its getting crazier.

ap...@google.com <ap...@google.com> #13Aug 26, 2022 04:47PM

Marked as fixed.

Solution is provided here >

https://github.com/google/accompanist/issues/1487#issuecomment-1660115297

ap...@google.com <ap...@google.com> #14Aug 26, 2022 04:47PM

This is still happened

na...@google.com <na...@google.com> #15Sep 12, 2022 05:51PM

It's still happening with navigation-compose 2.7.0 and lifecycle 2.6.1

da...@google.com <da...@google.com> #16Sep 28, 2022 02:38PM

Try 2.7.1

sa...@google.com <sa...@google.com> #17Oct 17, 2022 05:23PM

Still happening on navigation-compose v2.7.7 / lifecycle v2.7.0. Any updates / prospect? Workaround maybe?

na...@google.com <na...@google.com> #18Oct 24, 2022 01:38PM

The following release(s) address this bug:

androidx.lifecycle:lifecycle-runtime:2.6.0-alpha03
androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha03
androidx.lifecycle:lifecycle-viewmodel-compose:2.6.0-alpha03
androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.0-alpha03