Make Upsert distinguish between Unique key constraint and foreign key constraint [243039555]

Fixed

Bug

Status Update

No update yet.

Description

pi...@google.com

created issue #1

Aug 18, 2022 06:33PM

In EntityUpsertionAdapter add if-statement to check error message catch. When the message is FK violation, throw a new FK violation error. When the message is UK violation, update the database.

Comments

ap...@google.com <ap...@google.com> #2Aug 26, 2022 03:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 80c8907809c42e53332740c692b032c5d3279aa8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Thu Sep 03 11:57:35 2020

Fail fast and notify user if image capture destination is invalid

This CL verifies the image save destination is valid and can be written to before triggering the image capture pipeline. This prevents taking a picture if the capture result cannot be saved.

Bug:

b/167697553

Test: ImageSaveLocationValidatorTest.kt
Change-Id: Ic61cda8781d028162ef98ba74d12f0ff872eb211

M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
A camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java

https://android-review.googlesource.com/1419729

https://goto.google.com/android-sha1/80c8907809c42e53332740c692b032c5d3279aa8

is...@google.com <is...@google.com> Sep 20, 2022 08:58AM

Status: New

da...@google.com <da...@google.com> Sep 20, 2022 12:39PM

Marked as fixed, reassigned to da...@google.com.

na...@google.com <na...@google.com> #3Oct 5, 2022 05:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ee9fa116b553b77b17badd7cac58374c99651753
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020

Fix bug in validating file save destination for image capture

To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.

This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.

Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323

M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java

https://android-review.googlesource.com/1425243

https://goto.google.com/android-sha1/ee9fa116b553b77b17badd7cac58374c99651753

pe...@gmail.com <pe...@gmail.com> #4Jan 5, 2023 05:03PM

Project: platform/frameworks/support
Branch: snap-temp-L87300000695801067

commit 5b7a369fa062c0593e549e8fe2fc10a06617baa3
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020

Fix bug in validating file save destination for image capture

To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.

This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.

Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)

M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java

https://android-review.googlesource.com/1432092

da...@google.com <da...@google.com> #5Jan 18, 2023 02:55PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: snap-temp-L72800000695805814

commit 240338b47aaa714601dd53aa83f4430d3b950f42
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020

Fix bug in validating file save destination for image capture

To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.

This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.

Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)

M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java

https://android-review.googlesource.com/1432094

pe...@gmail.com <pe...@gmail.com> #6Jan 20, 2023 07:01PM

Project: platform/frameworks/support
Branch: snap-temp-L56300000695806117

commit 34655560b066fc448da6d1360a39b60c382a3894
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020

Fix bug in validating file save destination for image capture

To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.

This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.

Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)

M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java

https://android-review.googlesource.com/1432097

mi...@gmail.com <mi...@gmail.com> #7Jul 31, 2023 08:03AM

The following changes were cherrypicked through Coastguard
Release Track: 5973175825203200
Changes: aosp/1425243

el...@google.com <el...@google.com> #8Jul 31, 2023 12:21PM

Project: platform/frameworks/support
Branch: snap-temp-L35100000695851870

commit 05592a19dd8be2804e0c1824ed112153136d26d8
Author: husaynhakeem <husaynhakeem@google.com>
Date: Fri Sep 11 00:24:35 2020

Fix bug in validating file save destination for image capture

To validate the save destination of image capture when the outputOption contains a file, try opening a write stream to the file. If it succeeds, the file is writable and the image capture save location is valid, otherwise it's invalid.

This validation previously used File.canWrite(), this works correctly for files that are actually created (e.g. using File.createTemp()). When creating a file object with `new File(...)`, the method constantly returns false. This was causing the tests in the rotation test app (uiwidgets/rotations) to fail.

Bug: 167697553
Test: ImageSaveLocationValidatorTest.java + ImageCapture rotation tests
Change-Id: I8c5656fcc5da0c477203b3b5c8bb450be148b323
(cherry picked from commit ee9fa116b553b77b17badd7cac58374c99651753)

M camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java

https://android-review.googlesource.com/1430181

ap...@google.com <ap...@google.com> #9Aug 7, 2023 08:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 01002bedc549e0264a5f920dc554ed7dd7785cfe
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Aug 01 05:53:50 2023

Handle special case SQLite exception during upsert.

When 2067 SQLITE_CONSTRAINT_UNIQUE is thrown during an upsert, upsert should perform an update.

Bug: 243039555
Test: EntityUpsertionAdapterTest.java
Change-Id: If28499c59443f590ac456924eff03b18f1a87e4f

M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/EntityUpsertionAdapterTest.java
M room/room-runtime/src/main/java/androidx/room/EntityUpsertionAdapter.kt

https://android-review.googlesource.com/2686153

el...@google.com <el...@google.com> Aug 7, 2023 09:51PM

Marked as fixed.