Status Update
No update yet.
Comments
il...@google.com
Feel free to disable the link check as a workaround.
The Gradle equivalent is:
android {
lintOptions {
disable "DialogFragmentCallbacksDetector"
}
}
me...@gmail.com
Not all of our builds depend on androidx.fragment and if you do not use androidx.fragment and you add this disable flag, lint fails due to non-existant check DialogFragmentCallbacksDetector. If you do not plan on fixing this soon, I can try and see if we can only disable the check if we depend on androidx.fragment.
me...@gmail.com
Branch: androidx-main
commit 52b166175eabed99d14515190bfa0a7cea787004
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 16:11:44 2021
Fix OnCreateDialogIncorrectCallback lint on empty java classes
The OnCreateDialogIncorrectCallbackDetector lint rule currently checks
the first element of a list without verifying the item is actually
there. We should check if the item is null before we do anything else.
RelNote: "The `OnCreateDialogIncorrectCallbackDetector` no longer fails
on empty java classes/interfaces"
Test: java empty interface clean
Bug: 187524311
Change-Id: Iaff6c041370bd5a7c2ac8ef8c32a2e6f7a15e456
M fragment/fragment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
M fragment/fragment-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt
lb...@gmail.com
This has been fixed internally and will be available in the Fragment 1.4.0-alpha01 release.
me...@gmail.com
I am using 1.4.0-alpha01 of the Fragment Library but I am still getting this error.
il...@google.com
mi...@gmail.com
Re #6 - please file a new bug with a sample that reproduces your error.
lb...@gmail.com
ab...@gmail.com
me...@gmail.com
ab...@gmail.com
Can you update regarding any progress on this issue.
jb...@google.com
sa...@google.com
ap...@google.com
Branch: androidx-main
commit 50f098644adc703ae218b0b7e999629f516a0241
Author: sanura <sanura@google.com>
Date: Thu Mar 02 00:11:35 2023
Add check to only invalidate options menu when contributing menu items
FragmentManager previously appropriately only added
a MenuProvider when the host is a MenuHost **and**
we are at the root fragment that is providing the
menu items. This behavior should be mirrored when
removing a MenuProvider as well, so that only
components that directly contribute menu items will
invalidate the options menu.
Bug: 244336571
Test: all tests pass
Change-Id: I9404ee9fcc9ce6b80d70a93bea720fe4ccf583a0
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/OptionsMenuFragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/FragmentTestActivity.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
sa...@google.com
lb...@gmail.com
Please show what to write on gradle file.
jb...@google.com
This has been fixed internally and will be available in the Fragment 1.6.0-alpha07 release.
lb...@gmail.com
It's part of the material dependency, perhaps?
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.fragment:fragment:1.6.0-alpha07
lb...@gmail.com
lb...@gmail.com
It says "Duplicate class found".
The IDE doesn't provide any useful explanation of what is the class that is duplicated and what to do about it.
Please help.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.fragment:fragment:1.5.6
lb...@gmail.com
th...@gmail.com
@21 androidx.fragment:fragment:1.5.6 is a STABLE release. It has the fix we need. The androidx.fragment:fragment:1.6.0-alpha07 is an alpha as it says. 1.6 is "work in progress". 1.6.0 is still not a stable release. Use "alpha" only for testing
Description
Version used: 1.5.2
Devices/Android versions reproduced on: Android 12
I'm using SearchView in my Activity. If SearchView is expanded and i'm opening DialogFragment on the top of the activity and then dismissing it, SearchView is being collapsed. It must not collapse.
Seems like some bug in Fragment 1.5.0 - 1.5.2 version. In 1.4.1 version everything is working fine.
Please suggest some workarounds or how to fix this issue?