IssueTracker

Navigation is built with Support Library Fragments so has no access to the FragmentFactory itself. I think we can make some minor changes to FragmentNavigator to make it easy for developers who are using Navigation 1.0 and Fragments 1.1.0 together to call through to their FragmentFactory.

Once Navigation switches to AndroidX (post 1.0), we'll use FragmentFactory directly.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1b215f0d93828286782776b9a12d2387097947f9
Author: Ian Lake <ilake@google.com>
Date:   Sun Nov 25 21:45:56 2018

    Move Fragment creation to FragmentNavigator
   
    Provide an instantiateFragment() method on
    FragmentNavigator which serves as the
    centralized place to instantiate new
    Fragment instances for FragmentNavigator.
   
    Besides moving this business logic out of
    the dumb POJO FragmentNavigator.Destination,
    this also provides a future extension point
    for integrating in FragmentFactory.
   
    Test: existing tests passes, testapp still works
    BUG: 119054429
    Change-Id: If60471a704ef77bc35b30838e152a31cde8bc235

M       navigation/fragment/ktx/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilderTest.kt
M       navigation/fragment/ktx/src/main/java/androidx/navigation/fragment/FragmentNavigatorDestinationBuilder.kt
M       navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M       navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/835682
https://goto.google.com/android-sha1/1b215f0d93828286782776b9a12d2387097947f9

Navigation still depends on Support Library and not AndroidX, so we can't directly use FragmentFactory in FragmentNavigator.

However, in alpha08, you'll be able to subclass FragmentNavigator and override instantiateFragment(), calling into FragmentFactory if you're using AndroidX Fragment 1.1.0+. You'd also need to subclass NavHostFragment and override createFragmentNavigator() to return your custom FragmentNavigator subclass (or, if you're not using app:navGraph, you can set it via navHostFragment.navController.navigatorProvider += YourFragmentNavigator(context, navHostFragment.childFragmentManager)).

We'll keep this open until Navigation has moved to AndroidX and can directly use FragmentFactory as its default implementation of instantiateFragment().

Thanks for the workaround in alpha08!

Can't wait to use this library after the move to AndroidX.
For us is a major blocking feature and we don't want to proceed overriding all the necessary classes.

Thank you Ian and the rest of the navigation team.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 74c3760e428648d00249dc1d38865b7802f48a9a
Author: Ian Lake <ilake@google.com>
Date:   Wed Mar 13 13:11:57 2019

    Use FragmentFactory in FragmentNavigator
   
    Rely on the FragmentManager's FragmentFactory
    to instantiate Fragments created for
    FragmentNavigator.
   
    Test: new FragmentNavigatorTest
    Fixes: 119054429
    Change-Id: Icbeb2771e29cafdc52e4c4ea770ce89f739921d1

M       navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M       navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/928481
https://goto.google.com/android-sha1/74c3760e428648d00249dc1d38865b7802f48a9a

This is fixed internally - FragmentNavigator will use the FragmentFactory to create Fragments in the upcoming 2.1.0-alpha01 release.

Thank you Ian :)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3dd6d1fcdb3ffa7d4bd265a023f0ac7c94e14d19
Author: Ian Lake <ilake@google.com>
Date:   Mon Mar 18 09:36:37 2019

    Deprecate FragmentNavigator.instantiateFragment
   
    Instead of providing a custom subclass of
    FragmentNavigator, instantiation of Fragments
    should be controlled by setting a custom
    FragmentFactory, which is the default behavior
    of instantiateFragment() now.
   
    By deprecating the class, we ensure that
    developers who were overriding this method
    are informed of the changes and can change
    their code to use FragmentFactory.
   
    Test: ./gradlew checkApi
    BUG: 119054429
    Change-Id: Iff46919face98baa6dc62835ca3fc105d987d141

M       navigation/fragment/api/2.1.0-alpha01.txt
M       navigation/fragment/api/current.txt
M       navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/930120
https://goto.google.com/android-sha1/3dd6d1fcdb3ffa7d4bd265a023f0ac7c94e14d19

Facing a similar kind of issue when scrolling the fragments using a ViewPager.

https://issuetracker.google.com/issues/267677504

Can you update regarding any progress on this issue.

I wonder if the new SearchBar has this issue:
https://material.io/blog/android-stable-release-1-8-0

Project: platform/frameworks/support
Branch: androidx-main

commit 50f098644adc703ae218b0b7e999629f516a0241
Author: sanura <sanura@google.com>
Date:   Thu Mar 02 00:11:35 2023

    Add check to only invalidate options menu when contributing menu items
   
    FragmentManager previously appropriately only added
    a MenuProvider when the host is a MenuHost **and**
    we are at the root fragment that is providing the
    menu items. This behavior should be mirrored when
    removing a MenuProvider as well, so that only
    components that directly contribute menu items will
    invalidate the options menu.
   
    Bug: 244336571
    Test: all tests pass
    Change-Id: I9404ee9fcc9ce6b80d70a93bea720fe4ccf583a0

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
M       fragment/fragment/src/androidTest/java/androidx/fragment/app/OptionsMenuFragmentTest.kt
M       fragment/fragment/src/androidTest/java/androidx/fragment/app/test/FragmentTestActivity.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/2465169

@13 Fixed when? On which version of which dependency?
Please show what to write on gradle file.

@15 I've noticed I can avoid using the fragment dependency and still work fine with fragments. How come?
It's part of the material dependency, perhaps?

@17 What if I don't use this dependency (probably imported automatically by material dependency) ? Use it, still?

@17 I wanted to try what you wrote on the sample I've provided (after I remove my workaround), and for some reason it doesn't let me.
It says "Duplicate class found".
The IDE doesn't provide any useful explanation of what is the class that is duplicated and what to do about it.
Please help.

@20 Not 1.6.0-alpha07 ?

@22 So it's fixed on both. OK