Fixed
Status Update
No update yet.
Comments
ma...@mksolutions.com.br
We probably should make this work without a new API, otherwise developers would need to provide these flags, which is hard and complicated and entirely what the library should aim to simplify
For the support version of the library, we can probably make outside touches not dismiss the dialog.
We can have either
1) back button (existing)
2) potentially add a new "cancel" button
For the support version of the library, we can probably make outside touches not dismiss the dialog.
We can have either
1) back button (existing)
2) potentially add a new "cancel" button
uc...@google.com
bo...@google.com
I'm unable to reproduce this issue on Samsung S7
Can you capture a video and a bugreport on both
1) Pixel Android 9 - cannot reproduce, sensor is on the back, and dialog works for me
2) Huawei mate 20 Android 8.1.0?
My suspicion is that on the Huawei device, we're going through the FingerprintManager path on support library, and Huawei is overlaying it with their own in-display FP UI. The UI should consume touches and not propagate them, otherwise the dialog will be canceled.
Can you capture a video and a bugreport on both
1) Pixel Android 9 - cannot reproduce, sensor is on the back, and dialog works for me
2) Huawei mate 20 Android 8.1.0?
My suspicion is that on the Huawei device, we're going through the FingerprintManager path on support library, and Huawei is overlaying it with their own in-display FP UI. The UI should consume touches and not propagate them, otherwise the dialog will be canceled.
ch...@lovefurniture.ie
The issue we were seeing on Samsung drives is it is very easy to fat-finger and tap the screen because the fingerprint sensor is on the front. This was with the compat dialog. I think always setting Dialog#setCanceledOnTouchOutside(false) is a reasonable solution as you can still use the back button to cancel the dialog.
de...@google.com
The safer way seems to me like disallowing the library from being dismissed from taps outside. The back button is still there, which gives the user an escape hatch.
ma...@mksolutions.com.br
Attached wrong bug number, fixed in following commit
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2aa297a0d4a014a06766b1658b6c9438ecff30fc
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:42:48 2019
Do not allow the fingerprint dialog to be canceled due to touches outside
It's safer to disallow this, since on some devices the sensor is on the
home button, etc, where it's easier to miss. Since the support library
is supposed to simplify developer's lives, we should just default to
preventing this on all pre-P devices, rather than potentially exposing
an API for developers to toggle based on device type (too complicated).
Fixes: 125447052
Test: Touches outside no longer cancel authentication. Back button cancels
authentication still.
Change-Id: I6639b2ecdf18f82a242fffba63eeb8ca45d53dc9
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
https://android-review.googlesource.com/1087531
https://goto.google.com/android-sha1/2aa297a0d4a014a06766b1658b6c9438ecff30fc
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2aa297a0d4a014a06766b1658b6c9438ecff30fc
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:42:48 2019
Do not allow the fingerprint dialog to be canceled due to touches outside
It's safer to disallow this, since on some devices the sensor is on the
home button, etc, where it's easier to miss. Since the support library
is supposed to simplify developer's lives, we should just default to
preventing this on all pre-P devices, rather than potentially exposing
an API for developers to toggle based on device type (too complicated).
Fixes: 125447052
Test: Touches outside no longer cancel authentication. Back button cancels
authentication still.
Change-Id: I6639b2ecdf18f82a242fffba63eeb8ca45d53dc9
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
Description
Android Studio Version: Unknown
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.2.10-8420304
HAXM / KVM Version: KVM 12.0.0
Android SDK Tools: 26.1.1
Host Operating System: Ubuntu 22.04.1 LTS
CPU Manufacturer: AMD CPU
Virtualization is supported
64-bit CPU
RAM: 9887 MB
GPU:
Build Fingerprint:
AVD Details: Name: Pixel_4_API_31
CPU/ABI: x86_64
Path: /home/mauricio/.android/avd/Pixel_4_API_31.avd
Target: google_apis_playstore [Google Play] (API level 31)
Skin: 1080x2280
SD Card: 512 MB
AvdId: Pixel_4_API_31
PlayStore.enabled: true
avd.ini.displayname: Pixel 4 API 31
avd.ini.encoding: UTF-8
disk.dataPartition.size: 2G
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: yes
fastboot.forceFastBoot: no
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: emulated
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:6b5943207fe196d842659d2e43022e20
hw.device.manufacturer: Google
hw.gps: yes
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: Portrait
hw.keyboard: yes
hw.lcd.density: 440
hw.lcd.height: 2280
hw.lcd.width: 1080
hw.mainKeys: no
hw.ramSize: 1536
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images/android-31/google_apis_playstore/x86_64/
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: no
skin.dynamic: yes
skin.path.backup: _no_skin
tag.display: Google Play
vm.heapSize: 256
Steps to Reproduce Bug:
Expected Behavior:
Observed Behavior: