Status Update
Comments
vi...@google.com <vi...@google.com>
bo...@google.com <bo...@google.com>
wd...@google.com <wd...@google.com>
wd...@google.com <wd...@google.com>
bi...@gmail.com <bi...@gmail.com> #2
There are a few more changes to DataStoreImpl's logic which makes a reevaluation necessary.
Now with Yigit's changes, datastore's
A ReadException is not automatically handled and stays in cache until a updateData call which revisits handleUpdate
call proceeds to
se...@gmail.com <se...@gmail.com> #3
can we create a test failure for this? I'm not fully sure what is going wrong here, it is a bit hard to track w/o a repro case.
dt...@gmail.com <dt...@gmail.com> #4
can we create a test failure for this?
Sure I'm working on the code changes.
In the meantime I think this bug might makes the errors e.g. in
[Deleted User] <[Deleted User]> #5
Branch: androidx-main
commit 383a67d0e5a9b35e394b212db35bdee892b167fb
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Wed Feb 21 17:04:40 2024
Add tests to verify that CorruptionException is not properly handled after DataStore's first disk read. If the internal state is [ReadException], it will not recover for the rest of the lifecycle.
Fix in the follow up change.
Bug: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Ie77900b5c2cb8fb8e55d4c40364491dea9250784
M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt
ta...@gmail.com <ta...@gmail.com> #6
Branch: androidx-main
commit 70085fee2af278bb8c3e45e1acfcf3f4cbb05c5a
Author: Zhiyuan Wang <zhiyuanwang@google.com>
Date: Thu Feb 22 15:08:34 2024
DataStore handles CorruptionException for all reads and writes.
Before this change, DataStore didn't handle the CorruptionException for both the reads and writes after initialization.
Fixes: 289582516
Test: ./gradlew :datastore:datastore-core:jvmTest
Change-Id: Icb07b140017b62a905d3626f82aeb993f636c053
M datastore/datastore-core/src/commonMain/kotlin/androidx/datastore/core/DataStoreImpl.kt
M datastore/datastore-core/src/commonTest/kotlin/androidx/datastore/core/SingleProcessDataStoreTest.kt
ta...@gmail.com <ta...@gmail.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.datastore:datastore-core:1.1.0-beta02
androidx.datastore:datastore-core-android:1.1.0-beta02
androidx.datastore:datastore-core-iosarm64:1.1.0-beta02
androidx.datastore:datastore-core-iossimulatorarm64:1.1.0-beta02
androidx.datastore:datastore-core-iosx64:1.1.0-beta02
androidx.datastore:datastore-core-jvm:1.1.0-beta02
androidx.datastore:datastore-core-linuxx64:1.1.0-beta02
androidx.datastore:datastore-core-macosarm64:1.1.0-beta02
androidx.datastore:datastore-core-macosx64:1.1.0-beta02
bu...@gmail.com <bu...@gmail.com> #8
// Beta channel sdkmanager 'cmdline-tools;latest' --channel=1
// Canary channel sdkmanager 'cmdline-tools;latest' --channel=3
bu...@gmail.com <bu...@gmail.com> #9
Wifi. Ibrahim- SR it Wifi.Sohag Room-19
[Deleted User] <[Deleted User]> #10
Really
[Deleted User] <[Deleted User]> #11
Your email
Description
Android Studio Version: 2021.3.1
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.3.11-9058569
HAXM / KVM Version: HVF 12.6.0
Android SDK Tools: 26.1.1
Host Operating System: macOS 12.6
CPU Manufacturer: Other CPU:
64-bit CPU
RAM: 65536 MB
GPU:
Build Fingerprint:
AVD Details: Name: Pixel_5_API_33
CPU/ABI: arm64
Path: /Users/marikan/.android/avd/Pixel_5_API_33.avd
Target: google_apis [Google APIs] (API level 33)
Skin: 1080x2340
SD Card: 2G
AvdId: Pixel_5_API_33
PlayStore.enabled: false
avd.ini.displayname: Pixel 5 API 33
avd.ini.encoding: UTF-8
disk.dataPartition.size: 2G
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: no
fastboot.forceFastBoot: yes
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: emulated
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:3274126e0242a0d86339850416b0ce34
hw.device.manufacturer: Google
hw.gps: yes
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: Portrait
hw.keyboard: yes
hw.lcd.density: 440
hw.lcd.height: 2340
hw.lcd.width: 1080
hw.mainKeys: no
hw.ramSize: 1536
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images/android-33/google_apis/arm64-v8a/
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: yes
skin.dynamic: yes
tag.display: Google APIs
vm.heapSize: 512
Steps to Reproduce Bug:
Start emulator with "-timezone" parameter(e.g emulator -avd Pixel_5_API_33 -timezone Asia/Shanghai)
Issue is reproducible when API level of the emulator is set to 31+. When API level is 30 emulator works as expected
Expected Behavior:
Emulator starts with timezone set to provided parameter value
Observed Behavior:
Emulator ignores the parameter and starts with host devices timezone.