Status Update
Comments
km...@google.com <km...@google.com>
lo...@gmail.com <lo...@gmail.com> #2
Great
bo...@google.com <bo...@google.com>
wd...@google.com <wd...@google.com> #3
Branch: androidx-main
commit a735aaa4d06c90454de772fae5a02f6cbde210b3
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 28 22:58:23 2023
Ensure FragmentNavigator destroys intermediate entries on popUpTo
We need to make sure that when Fragment are destroyed their entries are
also always destroyed.
RelNote: "Fixes a regressions in previous release that caused the wrong
BottomNav menu item to be highlighted when using system back to go
between tabs."
Test: Added FragmentNavigatorTest
Bug: 270447657
Change-Id: I634f6047b7016bcb8b690047605a6f66b2dc1438
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
wd...@google.com <wd...@google.com> #4
This has been fixed internally and will be available in the Navigation 2.6.0-alpha07
release.
de...@google.com <de...@google.com> #5
Branch: androidx-main
commit 96cee05bdb8f61a92e4be00a52b991cfc1ed2f4e
Author: Clara Fok <clarafok@google.com>
Date: Wed Mar 01 12:28:09 2023
Add FragmentNavigator test to assert entry destroyed
Add test to assert that NavBackStackEntry is destroyed after being restored upon recreation/configuration change.
Asserts that the fix on this bug also fixes
Test: ./gradlew navigation:navigation-fragment
Bug: 270447657
Change-Id: I8874d2dfaa17e560dd2f6d9da54e435494c187d2
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
ra...@google.com <ra...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.6.0-alpha07
wd...@google.com <wd...@google.com> #7
Branch: androidx-main
commit 7cf55857f0db6bd1a1e1f95be7374ed5cf3eca58
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 15 16:59:50 2023
Fix system back after popUpTo
After you do a popUpTo inclusive while using Navigation with Fragments,
if you attempt to do a system back call, the Navigation back stack is
never updated.
The reason for this is that when fragment views are DESTROYED, we need
for the observer in the FragmentNavigator to update the state so we know
that the entry was already popped.
RelNote: "When using system back after doing a navigate with popUpTo,
the state of the NavController will pop to the correct entry."
Test: Added OnBackPressedTest
Bug: 270447657
Change-Id: I3a8ec072ba6d1655ab054cc081961825909088e6
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/OnBackPressedTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
de...@google.com <de...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.6.0-alpha08
wd...@google.com <wd...@google.com> #9
RE#9 Thanks Devki. Actually the fix is included in aosp-emu-31-release branch.
wd...@google.com <wd...@google.com> #10
Upload a new
bo...@google.com <bo...@google.com>
de...@google.com <de...@google.com>
ra...@google.com <ra...@google.com> #12
Hi Weilun, Devki,
Still seeing this issue on Emulator 31.3.15 Stable build.
Can you check if the changes are in 31.3.15 or not?
wd...@google.com <wd...@google.com> #13
RE#12 31.3.15 uses build 9456632 so it should have included the fix. Let's sync up in chat.
ra...@google.com <ra...@google.com> #14
Retried as per offline discussion with Weilun, sometimes the time adjusts automatically but sometimes it gets adjusted after interacting with AVD.
wd...@google.com <wd...@google.com> #15
I think we can close the bug as verified.
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #16
I'm still seeing this issue in Emulator 32.1.10.
wd...@google.com <wd...@google.com> #17
RE#16 Hi minyushov@, would it be possible to provide more details with what kind of host OS and what are the repro steps I can follow? Thanks!
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #18
Hi
I'm using MacBook Pro with Apple Silicon and macOS Ventura 13.0.1.
Steps are pretty straightforward:
- Power adapter is plugged in. Energy mode is set to Automatic for both 'On battery' and 'On power adapter' options.
- Run emulator.
- Keep it running until macbook automatically goes to sleep.
- Wake it up after ~10 minutes and observe the time in the emulator. It shows not the actual time but the time when macbook fell asleep.
I'm not sure that this happens all the time but often enough.
wd...@google.com <wd...@google.com> #19
RE#18 Really appreciate it. I will start testing it.
wd...@google.com <wd...@google.com> #20
#18
One more question: After step 4 Wake it up after ~10 minutes and observe the time in the emulator. It shows not the actual time but the time when macbook fell asleep.
, have you tried to move the emulator window? I think the time should be updated when you starting using the emulator.
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #21
I'm not sure that I've moved the emulator window but usually I install our app using Android Studio and see network errors due to time difference between the app and our servers. So it looks like the time isn't updated in this case.
ne...@gmail.com <ne...@gmail.com> #22
Em sex., 3 de fev. de 2023 15:08, <buganizer-system@google.com> escreveu:
wd...@google.com <wd...@google.com> #23
RE#21 Another question, are you using the emulator in a tool window? I think it might be the specific scenario which still has bug.
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #24
I'm launching the emulator in a standalone window.
wd...@google.com <wd...@google.com> #25
RE#24
Ok, I tried it myself and I could not reproduce unfortunately. With have you tried to move the emulator window? I think the time should be updated when you starting using the emulator.
being said, would it be possible for you to try it again?
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #26
Sure, will try
ne...@gmail.com <ne...@gmail.com> #27
mandaram aí por escrito
Em sex., 3 de fev. de 2023 15:59, <buganizer-system@google.com> escreveu:
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #28
Unfortunately, it happened again. Moving a window did not help.
Some additional info:
- I use a pair of external displays connected via Type-C, Bluetooth keyboard and mouse.
- Power adapter is plugged in. This way I can safely close a macbook lid and continue using it with the external displays. When macbook is sleeping I can wake it up by pressing a key on a keyboard or by clicking a mouse button.
- Today I left my workplace for 40-50 minutes. When I came back, external displays were in standby mode. After waking the macbook up, I've reproduced the issue.
wd...@google.com <wd...@google.com> #29
RE#28 I realized what went wrong. My fix didn't merge into the 32 release. It's only available in the 31 release and the dev branch. Let me resolve that issue real quick and release a new version. Thanks for your input!
mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #30
Thank you!
wd...@google.com <wd...@google.com>
wd...@google.com <wd...@google.com>
de...@google.com <de...@google.com> #31
ranjitkumar@
mp...@gmail.com <mp...@gmail.com> #32
pa...@marketrebellion.com <pa...@marketrebellion.com> #33
Host: Darwin Kernel Version 22.4.0 arm64
wd...@google.com <wd...@google.com>
wd...@google.com <wd...@google.com>
wd...@google.com <wd...@google.com> #35
The fix is available in the next canary and stable release in June.
de...@google.com <de...@google.com> #36
de...@google.com <de...@google.com> #39
si...@gmail.com <si...@gmail.com> #40
Android emulator version 33.1.4-9936625
Host: macbook pro M1 Max, macOs: 13.5.1 (22G90)
Is there anything I need to do to fix this?
si...@meta.com <si...@meta.com> #42
wd...@google.com <wd...@google.com> #43
RE#42 Thanks for the feedback on the emulator. To help us troubleshoot this issue further, we will need more information. Please share detailed reproduction steps as much as possible of the following information:
1, Run the emulator from command line with “$ANDROID_SDK_ROOT/emulator/emulator -avd <NameOfAVD> -verbose -wipe-data” and send the logs from terminal
2, Run adb bugreport and send the zip file.
ra...@google.com <ra...@google.com>
wd...@google.com <wd...@google.com>
ra...@gmail.com <ra...@gmail.com> #44
I confirm 34.1.9 has no this issue anymore
Description
Please Read:https://developer.android.com/studio/report-bugs.html#emulator-bugs
Android Studio Version: 2021.3
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 31.3.13-9189900 HAXM / KVM Version: HVF 12.6.0
Android SDK Tools: 26.1.1
Host Operating System: macOS 12.6
CPU Manufacturer: Apple CPU: Apple M1 Max
RAM: 65536 MB
GPU:
Build Fingerprint:
AVD Details: Name: Pixel_3a_API_33_arm64-v8a CPU/ABI: arm64 Path: /Users/ralfeus/.android/avd/Pixel_3a_API_33_arm64-v8a.avd Target: google_apis [Google APIs] (API level 33) Skin: 1080x2220 SD Card: 800 MB AvdId: Pixel_3a_API_33_arm64-v8a PlayStore.enabled: false avd.ini.displayname: Pixel_3a_API_33_arm64-v8a avd.ini.encoding: UTF-8 disk.dataPartition.size: 2G fastboot.chosenSnapshotFile: fastboot.forceChosenSnapshotBoot: no fastboot.forceColdBoot: no fastboot.forceFastBoot: yes hw.accelerometer: yes hw.arc: false hw.audioInput: yes hw.battery: yes hw.camera.back: emulated hw.camera.front: emulated hw.cpu.ncore: 1 hw.dPad: no hw.device.hash2: MD5:0e6953ebf01bdc6b33a2f54746629c50 hw.device.manufacturer: Google hw.device.name: pixel_3a hw.gps: yes hw.gpu.enabled: yes hw.gpu.mode: auto hw.initialOrientation: Portrait hw.keyboard: yes hw.lcd.density: 440 hw.lcd.height: 2220 hw.lcd.width: 1080 hw.mainKeys: no hw.ramSize: 1536 hw.sdCard: yes hw.sensors.orientation: yes hw.sensors.proximity: yes hw.trackBall: no image.sysdir.1: system-images/android-33/google_apis/arm64-v8a/ runtime.network.latency: none runtime.network.speed: full showDeviceFrame: no skin.dynamic: yes skin.path.backup: _no_skin tag.display: Google APIs tag.id: google_apis vm.heapSize: 256
Steps to Reproduce Bug:
Expected Behavior: Time matches one of host or real one from NTP server
Observed Behavior: Time is behind real one