Convert Activity to Kotlin [257291701]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Nov 3, 2022 06:34PM

Component used: Activity

It would be beneficial to have all of the AndroidX Activity classes rewritten in Kotlin. Besides providing better nullability guarantees, this would also help remove some of the friction in maintaining this library and evolving it over time.

Comments

ap...@google.com <ap...@google.com> #2Nov 5, 2022 02:32AM

This is a hard one. We can't easily read native crashes from that Motorola device since their system image is not public. I assume you can't reproduce this either, but if possible can you try using WorkManager 2.0.0 or 1.0.1-rc01? This would help track down the possible changes that might have introduced this issue. Thanks!

ap...@google.com <ap...@google.com> #3Nov 5, 2022 02:32AM

We actually did reproduce it, the current store version of Pocket Casts has WorkManager 2.0.0 and this bug if you want to try and test something. I will try 1.0.1-rc01 and report back.

ap...@google.com <ap...@google.com> #4Nov 6, 2022 11:58PM

Is there a difference between 1.0.1 and 2.0.1? We tried 2.0.1 and it was crashing, if there is a difference I can try 1.0.1 but I thought they were the same?

ap...@google.com <ap...@google.com> #5Nov 6, 2022 11:58PM

Can you also describe how you trigger the bug and which devices manifest the problem? Is it just running the app? Is it doing something specific?

ap...@google.com <ap...@google.com> #6Nov 7, 2022 11:05PM

We are testing on a Moto X running Android 6.0 but our play store report shows numerous motorola devices are crashing as the attached screenshots show. We just downloaded a bunch of episodes (which uses workmanager) and eventually it started crashing, it would then crash at start up every time.

ap...@google.com <ap...@google.com> #7Nov 7, 2022 11:05PM

So to answer your earlier question, 1.0.1 should be equivalent but I think there may be some small differences in Room between 1.0 and 2.0 and since this crash seems related to Room, that's why we were asking if you could check to see if you can reproduce it on 1.x.

Regarding the initial crash, do you have any logs for that?

cl...@google.com <cl...@google.com> Nov 8, 2022 01:26AM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #8Jan 25, 2023 07:17PM

This is the log I have. Hope it helps. Will test 1.0.1 for you

ap...@google.com <ap...@google.com> #9Jan 25, 2023 07:17PM

The logs are too short its just the crash and not much else before. :(

If the phone happens to be rooted and you are OK with sharing DB queries then you can enable SQL logging so we can see the queries that are occurring:
adb shell setprop log.tag.SQLiteStatements VERBOSE
adb shell stop
adb shell start

It would also be great if you can send us a bigger set of logs, or even better yet a bugreport after the crash occurs. (

https://developer.android.com/studio/debug/bug-report)

ap...@google.com <ap...@google.com> #10Jan 25, 2023 07:17PM

We can't root the phone sorry, we might be able to send a bug report though

ap...@google.com <ap...@google.com> #11Jan 25, 2023 07:17PM

We have a bug report from the crash already actually

ap...@google.com <ap...@google.com> #12Jan 27, 2023 02:17AM

We haven't been able to get the crash to happen on 1.0.1 so far

ap...@google.com <ap...@google.com> #13Jan 27, 2023 02:17AM

With a version of WorkManager that you are able to reproduce the issue, can you try adding Room 2.1.0-alpha06 as a dependency, effectively upgrading WorkManager's runtime dependency of Room?

Can you also enable WorkManager logs using setMinimumLoggingLevel(Log.DEBUG)

https://developer.android.com/topic/libraries/architecture/workmanager/advanced/custom-configuration

If you observe the crash please do take a bug report. If possible also dump dbinfo for the app's package: adb shell dumpsys dbinfo <package-name>

ap...@google.com <ap...@google.com> #14Jan 27, 2023 02:17AM

We have gone back to 2.0.0 and haven't been able to make it crash again unfortunately. Will keep trying. We are rolling out an update next week that reverts to 1.0.0 and will let you know if the crash goes away in production as well

ap...@google.com <ap...@google.com> #15Jan 27, 2023 02:17AM

I just want to distinguish between which versions you are using/experiencing this on.

1. The bug title lists 2.0.0
2. The first update lists 2.0.1-rc01
3. #14 lists 2.0.0

Can you reproduce at all with any version of WorkManager 2.x at this point? And if so, which ones work and which ones don't?

ap...@google.com <ap...@google.com> #16Jan 27, 2023 02:17AM

Our store version had 2.0.0 and is what the screenshots come from, we reproduced locally using that. We upgraded to 2.0.1rc1 and the phone was still crashing. We downgraded to 1.0.0 and the crash went away. To help with this testing we went back to 2.0.0 to try and get it to crash again but we haven't been able to get it to happen again.

ap...@google.com <ap...@google.com> #17Jan 30, 2023 09:17PM

We rolled out an update to the Play Store using WorkManager 1.0.0 and the issue has persisted unfortunately

ap...@google.com <ap...@google.com> #18Jan 30, 2023 09:17PM

Not sure it helps but this trace has a few more lines in it.

backtrace:
#00 pc 0000000000000000 <unknown>
#01 pc 0000000000025cdd /system/lib/libsqlite.so
#02 pc 0000000000025011 /system/lib/libsqlite.so
#03 pc 000000000000eb95 /system/lib/libsqlite.so
#04 pc 000000000002d60d /system/lib/libsqlite.so
#05 pc 000000000003b409 /system/lib/libsqlite.so
#06 pc 0000000000010931 /system/lib/libsqlite.so (sqlite3_step+536)
#07 pc 000000000007f175 /system/lib/libandroid_runtime.so
#08 pc 00000000018a0a33 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.nativeExecute+102)
#09 pc 00000000018a34b9 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.execute+260)
#10 pc 00000000018b3741 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransactionUnchecked+364)
#11 pc 00000000018b3ee5 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransaction+144)
#12 pc 00000000018ac61d /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteDatabase.endTransaction+72)
#13 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#14 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#15 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#16 pc 00000000001ec389 /system/lib/libart.so (_ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+200)
#17 pc 00000000001e6939 /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+492)
#18 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#19 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#20 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#21 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#22 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#23 pc 00000000003fb92b /system/lib/libart.so (MterpInvokeInterface+826)
#24 pc 000000000009c214 /system/lib/libart.so (ExecuteMterpImpl+14740)
#25 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#26 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#27 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#28 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#29 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#30 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#31 pc 00000000001cf255 /system/lib/libart.so (_ZN3art11interpreter30EnterInterpreterFromEntryPointEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameE+92)
#32 pc 00000000003f269f /system/lib/libart.so (artQuickToInterpreterBridge+706)
#33 pc 00000000000adc13 /system/lib/libart.so (art_quick_to_interpreter_bridge+34)
#34 pc 000000000064b125 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+344)
#35 pc 0000000000652b47 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+42)
#36 pc 00000000005f749d /system/framework/arm/boot.oat (java.lang.Thread.run+48)
#37 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#38 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#39 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#40 pc 0000000000314031 /system/lib/libart.so (_ZN3artL18InvokeWithArgArrayERKNS_33ScopedObjectAccessAlreadyRunnableEPNS_9ArtMethodEPNS_8ArgArrayEPNS_6JValueEPKc+56)
#41 pc 0000000000314dfd /system/lib/libart.so (_ZN3art35InvokeVirtualOrInterfaceWithJValuesERKNS_33ScopedObjectAccessAlreadyRunnableEP8_jobjectP10_jmethodIDP6jvalue+256)
#42 pc 000000000032be19 /system/lib/libart.so (_ZN3art6Thread14CreateCallbackEPv+848)
#43 pc 0000000000046eb3 /system/lib/libc.so (_ZL15__pthread_startPv+22)
#44 pc 0000000000019acd /system/lib/libc.so (__start_thread+6)

ap...@google.com <ap...@google.com> #19Jan 30, 2023 09:17PM

Unfortunately, this is still not telling us anything we can diagnose. Paired with the fact that we haven't gotten any other reports of this issue, it's not clear how we should proceed. We would need Motorola system images to proceed at this point. I can suggest one more thing: if you go back to the last version that worked fine for you and simply change your WorkManager dependency (but *not* any of the rest of your app's code changes), does it immediately exhibit the crash? Basically, I'm wondering if something else with your code is triggering or exacerbating the issue.

ap...@google.com <ap...@google.com> #20Jan 31, 2023 02:28AM

Ping to the original reporter(s).

ap...@google.com <ap...@google.com> #21Jan 31, 2023 02:28AM

Sorry I have been on leave for Easter. I think you are right about some other code change triggering this bug, will see if I can work anything out. I am at I/O next week as well if you want to have a look yourself.

ap...@google.com <ap...@google.com> #22Jan 31, 2023 07:12PM

Thanks, closing this out for now - feel free to reply if there's anything else we can assist you with on this matter.

ap...@google.com <ap...@google.com> #23Jan 31, 2023 07:12PM

This is a definite stab in the dark but do you use a ForeignKey with Room? This is the only reference I can find to similar crashes online.

https://stackoverflow.com/questions/50662521/tombstone-using-foreignkey-with-room

ap...@google.com <ap...@google.com> #24Jan 31, 2023 07:12PM

We do use foreign keys, but we've been doing that since our early alpha versions so I'm not sure that's it.

pa...@gmail.com <pa...@gmail.com> #25Mar 22, 2023 01:44PM

Fair enough, both crash reports have this sqlite3_step+536 in common. Will keep trying to work it out.

cl...@google.com <cl...@google.com> #26Mar 22, 2023 10:04PM

We seem to have narrowed this down to calling

WorkManager.initialize(applicationContext, workManagerConfig)
WorkManager.getInstance().getWorkInfosByTagLiveData(DownloadManager.WORK_MANAGER_DOWNLOAD_TAG).observeForever {}

If we wrap the second line in a coroutine to main just to delay it a cycle then the crash goes away, at least on our test device. We might roll out the fix to test it.

pa...@gmail.com <pa...@gmail.com> #27Mar 25, 2023 07:39PM

Hi, I'm glad you have some reproducible steps. It would help us a lot if you could actually boil this down to a minimal sample app that can reproduce it so you can share it with us and we can also examine what is going wrong.

cl...@google.com <cl...@google.com> #28Mar 27, 2023 06:50PM

Done! This crashes for us on the second launch, you need a large amount queued jobs for it to happen. Testing on a Moto X 2014 victara running Android 6.0.

ve...@gmail.com <ve...@gmail.com> #29Mar 28, 2023 09:09AM

We managed to get a test device, and I can reproduce it.

I see this:

05-21 10:18:50.804 352 352 D SFPerfTracer: layers: (6:13) (FocusedStackFrame (0xb8370eb8): 0:108)* (DimLayer (0xb83412c0): 9:12) (StatusBar (0xb83bbf38): 0:701) (NavigationBar (0xb8389d10): 0:550) (com.android.systemui.ImageWallpaper (0xb83b23f8): 0:234) (DimLayer (0xb83989f0): 0:45)- (DimLayer (0xb83907e0): 0:8)- (com.example.workmanagercrash/com.example.workmanagercrash.MainActivity (0xb836c948): 0:31)- (com.android.systemui/com.android.systemui.recents.RecentsActivity (0xb838d188): 0:58)- (thumbnail anim (0xb834e7a0): 0:23)- (com.google.android.googlequicksearchbox/com.google.android.launcher.GEL (0xb834e7a0): 0:13) (Application Error: com.example.workmanagercrash (0xb83989f0): 8:14)
05-21 10:18:50.804 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:50.804 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:50.805 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:50.805 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:50.805 463 463 F DEBUG : pid: 9165, tid: 9180, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:50.805 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:50.819 463 463 F DEBUG : r0 b9b04660 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:50.819 463 463 F DEBUG : r4 b9b044b8 r5 b692e118 r6 00000000 r7 b9b04f08
05-21 10:18:50.819 463 463 F DEBUG : r8 00000001 r9 b9b044b8 sl 00000000 fp 00000002
05-21 10:18:50.819 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:50.823 463 463 F DEBUG :
05-21 10:18:50.823 463 463 F DEBUG : backtrace:
05-21 10:18:50.824 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:50.824 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:50.824 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:50.824 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.062 1769 2069 V AlarmManager: sending alarm {f6ba791 type 3 *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED}
05-21 10:18:51.065 1769 1769 V AlarmManager: done {f6ba791, *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED} [3ms]
05-21 10:18:51.131 463 463 F DEBUG :
05-21 10:18:51.131 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_01
05-21 10:18:51.131 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.133 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_01 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.184 485 485 I Zygote : Process 9165 exited due to signal (11)
05-21 10:18:51.214 1769 2729 I ActivityManager: Process com.example.workmanagercrash (pid 9165) has died
05-21 10:18:51.215 1769 2729 W ActivityManager: Scheduling restart of crashed service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService in 1000ms
05-21 10:18:51.238 1769 1769 I ActivityManager: Start proc 9188:com.example.workmanagercrash/u0a106 for service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService
05-21 10:18:51.256 9188 9188 I art : Late-enabling -Xcheck:jni
05-21 10:18:51.301 9188 9188 W System : ClassLoader referenced unknown path: /data/app/com.example.workmanagercrash-1/lib/arm
05-21 10:18:51.476 9188 9202 F libc : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 9202 (WorkManager-Wor)
05-21 10:18:51.578 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:51.578 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:51.579 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:51.579 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:51.579 463 463 F DEBUG : pid: 9188, tid: 9202, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:51.580 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:51.609 463 463 F DEBUG : r0 b9b048c0 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:51.609 463 463 F DEBUG : r4 b9b04718 r5 b692e118 r6 00000000 r7 b9b05170
05-21 10:18:51.609 463 463 F DEBUG : r8 00000001 r9 b9b04718 sl 00000000 fp 00000002
05-21 10:18:51.609 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:51.615 463 463 F DEBUG :
05-21 10:18:51.615 463 463 F DEBUG : backtrace:
05-21 10:18:51.616 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:51.616 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:51.616 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:51.616 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.902 463 463 F DEBUG :
05-21 10:18:51.902 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_02
05-21 10:18:51.902 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.903 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_02 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.952 485 485 I Zygote : Process 9188 exited due to signal (11)
05-21 10:18:51.966 1769 2757 I ActivityManager: Process com.example.workmanagercrash (pid 9188) has died

il...@google.com <il...@google.com> Jul 11, 2023 05:58PM

Assigned to sa...@google.com.

il...@google.com <il...@google.com> Sep 28, 2023 10:15PM

Status: New

ap...@google.com <ap...@google.com> #30Oct 13, 2023 12:17AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 957adb282e41c2662fff6221325e6b51cd7377f9
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue May 21 14:37:00 2019

Fixes SQLite issues on some devices.

* Always beginTransaction() outside a try.
* Make sure SystemJobScheduler marks transactions as successful.

Test: Existing tests pass.
Fixes:

b/130182503

b/132697495

Change-Id: I55092537781fbfee97f4336eb7cf1a49e647d62a

M work/workmanager-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/workmanager/src/main/java/androidx/work/impl/utils/ForceStopRunnable.java

https://android-review.googlesource.com/966057

https://goto.google.com/android-sha1/957adb282e41c2662fff6221325e6b51cd7377f9

ap...@google.com <ap...@google.com> #31Oct 13, 2023 12:17AM

Will it be fixed in a maintainance release of 2.0, or will we have to wait for 2.1 next RC or release?

ap...@google.com <ap...@google.com> #32Oct 13, 2023 08:14PM

This will show up in the next 2.1.0 release.

ap...@google.com <ap...@google.com> #33Oct 13, 2023 08:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8b143a2d354ea97ac6457d9654357b891db90ba1
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 11 20:53:22 2023

Convert On*Provider interfaces to Kotlin

Ensure that the Consumer passed to each
Provider's add*Listener and remove*Listener
has the appropriate nullability.

Relnote: "The `OnMultiWindowModeChangedProvider`,
`OnNewIntentProvider`,
`OnPictureInPictureModeChangedProvider`,
`OnConfigurationChangedProvider`,
and `OnTrimMemoryProvider` interfaces have been
converted to Kotlin to ensure that the generic
parameters on the `Consumer` that their listener
methods take have the correct nullability (they
are all non-null)."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: Ib62377a0f6002806074a05126cf6a9ca8c78dcbf

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/OnMultiWindowModeChangedProvider.kt
M core/core/src/main/java/androidx/core/app/OnNewIntentProvider.kt
M core/core/src/main/java/androidx/core/app/OnPictureInPictureModeChangedProvider.kt
M core/core/src/main/java/androidx/core/content/OnConfigurationChangedProvider.kt
M core/core/src/main/java/androidx/core/content/OnTrimMemoryProvider.kt

https://android-review.googlesource.com/2782305

ap...@google.com <ap...@google.com> #34Oct 25, 2023 07:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit e4b914d4f0ce94d49d6a1fa1d19ba8864c415750
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 17 20:09:07 2023

Upgrade Core to use Lifecycle 2.6.2

As Lifecycle 2.6 has source breaking changes
for classes written in Kotlin, moving classes
(such as Core's ComponentActivity) to Kotlin
causes issues when run with maxDepVersions.

By updating Core to depend on Lifecycle 2.6.2,
we ensure that maxDepVersions won't cause
issues in subsequent upgrades.

Relnote: "Core now depends on
[Lifecycle `2.6.2`](/jetpack/androidx/releases/lifecycle#2.6.2)."
Test: ./gradlew core:core:build
BUG: 257291701

Change-Id: I2d94c8b7fc3fb3bb59547d56a5d2f06584f1b5a4

M core/core/build.gradle

https://android-review.googlesource.com/2796599

ap...@google.com <ap...@google.com> #35Oct 25, 2023 08:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6a74b4839f791578491d0007f440e395274e89ae
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 17 21:22:13 2023

Convert Core ComponentActivity to Kotlin

Switch to the new lifecycle property from
Lifecycle 2.6 as part of the Kotlin conversion
of Core's ComponentActivity.

As Kotlin warns if parameter names are different
from their super class names, we update other
classes to use savedInstanceState as the parameter
to onCreate().

Relnote: n/a
Test: ./gradlew core:core:checkApi
BUG: 257291701
Change-Id: Ib395e5da26427aa0d2831da2b7a5d1bdcb8ad22e

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/ComponentActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentFinishEarlyTest.kt
M glance/glance-wear-tiles/integration-tests/demos/src/main/java/androidx/glance/wear/tiles/demos/TilePreviewActivity.kt
M glance/glance-wear-tiles/integration-tests/template-demos/src/main/java/androidx/glance/wear/tiles/template/demos/TilePreviewActivity.kt

https://android-review.googlesource.com/2797916

ap...@google.com <ap...@google.com> #36Oct 25, 2023 08:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9ab92ca29baf2fab19bc2468e77a965890d1188a
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 17 20:41:42 2023

Rename Core ComponentActivity.java to .kt

In preparation for its conversion to Kotlin.

Test: ./gradlew core:core:build
BUG: 257291701
Change-Id: I273bb3d972cb1020b2a1c187a51770be33919d0d

M core/core/src/main/java/androidx/core/app/ComponentActivity.kt

https://android-review.googlesource.com/2797915

ap...@google.com <ap...@google.com> #37Oct 25, 2023 10:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4e57779ea244552e66b28f29a24b4a7604e80fe1
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 10 23:26:58 2023

Convert ComponentActivity to Kotlin

Rewrite ComponentActivity in Kotlin.

Test: ./gradlew activity:activity:checkApi
BUG: 257291701
Relnote: "`ComponentActivity` has been rewritten in
Kotlin."
Relnote: "Activity now depends on
[Core `1.13.0-alpha01`](/jetpack/androidx/releases/core#1.13.0-alpha01)."

Change-Id: I14f312d6879ce6c91496112fb6b171f81cdbddf2

M activity/activity/api/api_lint.ignore
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/build.gradle
M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/CameraValidationResultActivity.kt
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/ExtensionValidationResultActivity.kt
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/validation/ImageValidationActivity.kt
M camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/viewpager/ViewPager2Activity.kt
M camera/integration-tests/uiwidgetstestapp/src/main/java/androidx/camera/integration/uiwidgets/viewpager/ViewPagerActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/FragmentTestActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/NewIntentActivity.kt
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/HelpActivity.kt

https://android-review.googlesource.com/2797917

ap...@google.com <ap...@google.com> #38Oct 25, 2023 10:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit fff2ee271b53d0ca453696ba4025ba0f4fffc9b5
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 10 21:15:08 2023

Rename ComponentActivity.java to ComponentActivity.kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I72433e8a00676fa5173b6a7ee273afe7db187b4f

M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt

https://android-review.googlesource.com/2797835

ap...@google.com <ap...@google.com> #39Oct 25, 2023 11:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit 86cc08969d868fd7508c15db6f518cce9bcc28ef
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 25 20:08:59 2023

Convert ActivityResultLauncher to Kotlin

Rewrite ActivityResultLauncher in Kotlin.

The getContract() method is now an abtract Kotlin
property.

This also moves the `ActivityResultLauncher` Kotlin
extensions from `activity-ktx` back to `activity` since
we can't have two Kotlin files with the same name.

Relnote: "`ActivityResultLauncher` has been rewritten in
Kotlin. As part of that conversion, the `getContract` method
is now an abstract Kotlin property. This is a binary compatible
change, but source breaking if your implementation of
`ActivityResultLauncher` is written in Kotlin."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: Id4615d19b383b2438be6a8f68da7584394d13515

M activity/activity-compose/api/current.ignore
M activity/activity-compose/api/current.txt
M activity/activity-compose/api/restricted_current.ignore
M activity/activity-compose/api/restricted_current.txt
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/ActivityResultRegistryTest.kt
M activity/activity-compose/src/main/java/androidx/activity/compose/ActivityResultRegistry.kt
M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/result/ActivityResultLauncherTest.kt
M activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultCaller.kt
D activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultLauncher.kt
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityResultTest.kt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultLauncherTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultLauncher.kt

https://android-review.googlesource.com/2804284

ap...@google.com <ap...@google.com> #40Oct 25, 2023 11:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit e91ba67bdd4ef797487b8d757a2ac771a1cfc60a
Author: Ian Lake <ilake@google.com>
Date: Wed Oct 25 20:00:49 2023

Rename ActivityResultLauncher.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I19348e67afb8fe2f1ca9f5483e31fe8edfa29e8a

M activity/activity/src/main/java/androidx/activity/result/ActivityResultLauncher.kt

https://android-review.googlesource.com/2804283

il...@google.com <il...@google.com> Oct 26, 2023 10:46PM

Assigned to il...@google.com.

ap...@google.com <ap...@google.com> #41Oct 27, 2023 08:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit d949529d18ac83c6775c7824138b52eb544cdf1c
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 27 17:34:57 2023

Make ComponentActivity.onNewIntent take a non-null Intent

This Intent is always non-null so we should mark
it as such until the framework is updated to also
make it non-null.

Test: ./gradlew activity:activity:checkApi
BUG: 257291701
Change-Id: Ia694837203011f1c6aa611aea6c20f1b7473af1b

M activity/activity/src/androidTest/java/androidx/activity/ComponentActivityCallbacksTest.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/NewIntentActivity.kt
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitActivityDetail.kt

https://android-review.googlesource.com/2808359

ap...@google.com <ap...@google.com> #42Oct 31, 2023 04:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit dc886d9a2f535799cbf4bc6ae4ed5f98b3a8c2fb
Author: Ian Lake <ilake@google.com>
Date: Thu Oct 26 22:47:00 2023

Rename ActivityResultCaller.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I39957d5e2e01d634d6f2ff2f4b440dc8af19bb37

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCaller.kt

https://android-review.googlesource.com/2806974

ap...@google.com <ap...@google.com> #43Oct 31, 2023 04:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1ac2124d0e27761bc7f09d122d99254c69411631
Author: Ian Lake <ilake@google.com>
Date: Thu Oct 26 23:03:00 2023

Convert ActivityResultCaller to Kotlin

Rewrite ActivityResultCaller to Kotlin.

This also moves the `ActivityResultCaller` Kotlin
extensions from `activity-ktx` back to `activity` since
we can't have two Kotlin files with the same name+package.

Relnote: "`ActivityResultCaller` has been rewritten in
Kotlin."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: Ib02e49c49dbed2ce0d25ac71c8caf0325ffb8142

M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
M activity/activity-ktx/src/androidTest/AndroidManifest.xml
D activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResultCaller.kt
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/AndroidManifest.xml
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultCallerTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCaller.kt

https://android-review.googlesource.com/2805770

ap...@google.com <ap...@google.com> #44Dec 14, 2023 07:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2b9627fa602319fc8f0da026da1d6a2eb69c8fb5
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 14 00:51:20 2023

Convert ActivityResult to Kotlin

Rewrite ActivityResult in Kotlin.

This makes the resultCode and data getters into
public properties.

This also moves the ActivityResult Kotlin extensions
from activity-ktx back to activity since we can't
have two Kotlin files with the same name.

Relnote: "`ActivityResult` has been rewritten in Kotlin. The
`ActivityResult` Kotlin extensions that support destructuring
into the `resultCode` and `data` fields have been moved from
`activity-ktx` to `activity`."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: I0565a95aa4470a4cd23dcddf75df3f9dd8dca19e

M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/main/java/androidx/activity/result/ActivityResult.kt
M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResult.kt

https://android-review.googlesource.com/2875054

ap...@google.com <ap...@google.com> #45Dec 14, 2023 07:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit d0bd6c7654cc46122489507c366c307a74857c53
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 14 00:25:44 2023

Rename ActivityResult.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I2c8016d67a7d7a0ad8e1f271953cee447f876554

M activity/activity/src/main/java/androidx/activity/result/ActivityResult.kt

https://android-review.googlesource.com/2875034

ap...@google.com <ap...@google.com> #46Dec 19, 2023 12:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit 199afbbaf3a522f7f320de61b81856ae0df31150
Author: Ian Lake <ilake@google.com>
Date: Mon Dec 18 23:41:34 2023

Convert ActivityResultRegistry to Kotlin.

Rewrite ActivityResultRegistry in Kotlin.

This ensures that the nullability in the
contract passed to register is correctly passed
through to the resulting nullability on the
ActivityResultLauncher returned.

Relnote: "`ActivityResultRegistry` has been rewritten
in Kotlin. This ensures that the nullability of the
generics on the contract passed to `register` will
correctly be passed through to the
`ActivityResultLauncher` returned to you."
Test: ./gradlew activity:activity:checkApi
BUG: 257291701

Change-Id: I121f0ca842066fb73ab0e51b89720029e991407a

M activity/activity/api/current.ignore
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.ignore
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.kt

https://android-review.googlesource.com/2881572

ap...@google.com <ap...@google.com> #47Dec 19, 2023 12:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit f80d369c2b28b170a3ff00f86ae4c0d632e181d0
Author: Ian Lake <ilake@google.com>
Date: Mon Dec 18 21:42:11 2023

Rename ActivityResultRegistry.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: I1b00a8c5e948352c25c5c8907b51e78bee94adb9

M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.kt

https://android-review.googlesource.com/2881571

ap...@google.com <ap...@google.com> #48Dec 19, 2023 08:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit 320df280c1f53c234e520601a1b9cb2245b8244b
Author: Ian Lake <ilake@google.com>
Date: Tue Dec 19 19:43:15 2023

Convert ImmLeaksCleaner to Kotlin

Rewrite ImmLeaksCleaner to Kotlin.

Extract the logic of working with fields
via reflection from the actual business
logic of what fields need to be cleaned by
using a sealed class hierarchy.

Test: LeakInputMethodManagerTest still passes
BUG: 257291701
Change-Id: If281ab7e27229fbd5a0d0a488caccce59c184501

M activity/activity/src/main/java/androidx/activity/ImmLeaksCleaner.kt

https://android-review.googlesource.com/2882891

ap...@google.com <ap...@google.com> #49Dec 19, 2023 08:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit 226e08ae45ace12cd22f0b97750cd176315c3727
Author: Ian Lake <ilake@google.com>
Date: Tue Dec 19 18:55:08 2023

Rename ImmLeaksCleaner.java to .kt

As part of the Kotlin conversion process.

Test: n/a
BUG: 257291701
Change-Id: Ic1c131743fea46f9c759ae6d2730f7cf3c26a60a

M activity/activity/src/main/java/androidx/activity/ImmLeaksCleaner.kt

https://android-review.googlesource.com/2882890

ap...@google.com <ap...@google.com> #50Dec 19, 2023 10:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 150e6253b7f6943858dfddef0c4b135b373a883d
Author: Ian Lake <ilake@google.com>
Date: Tue Dec 19 21:25:16 2023

Move Kotlin extensions from activity-ktx to activity

Move all remaining Kotlin extensions from activity-ktx
back into activity now that activity is fully written
in Kotlin.

Relnote: "The Kotlin extensions of `by viewModels()` for
`ComponentActivity` and `trackPipAnimationHintView` have
been moved from `activity-ktx` to `activity`. The
`activity-ktx` artifact is now completely empty."
Test: ./gradlew checkApi
BUG: 257291701

Change-Id: I0a444140b10671bbfbb5aeab66f1a3a7e9d28061

M activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/lint-baseline.xml
D activity/activity-ktx/src/androidTest/AndroidManifest.xml
M activity/activity/api/current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/AndroidManifest.xml
M activity/activity/src/androidTest/java/androidx/activity/ActivityViewModelLazyTest.kt
M activity/activity/src/main/java/androidx/activity/ActivityViewModelLazy.kt
M activity/activity/src/main/java/androidx/activity/PipHintTracker.kt

https://android-review.googlesource.com/2882894

il...@google.com <il...@google.com> #51Dec 19, 2023 10:19PM

Marked as fixed.

All of AndroidX Activity has now been converted to Kotlin and all of activity-ktx has now been merged into activity.

The last of these changes will be available in Activity 1.9.0-alpha02.

ma...@gmail.com <ma...@gmail.com> #52May 19, 2024 01:16PM

Does this mean that there won't be any releases of activity-ktx going forward? is it safe to remove activity-ktx and just use activity?

jb...@google.com <jb...@google.com> #53May 21, 2024 02:12PM

Yes, activity-ktx is now empty and you can depend directly on activity.