Improve Compose in Fragment experience [258046948]

Fixed

Feature Request

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Nov 7, 2022 09:53PM

Using Compose within Fragments require setting a different ViewCompositionStrategy (DisposeOnViewTreeLifecycleDestroyed) so that the composition follows the fragment's view lifecycle. While we do document this behavior in https://developer.android.com/jetpack/compose/interop/interop-apis#composition-strategy it is still a common 'gotcha' that developers frequently run into as per feedback we've received from partners (b/229427938).

To prevent developers from making this mistake, we can improve the DevEx by either:

providing a lint warning when using ComposeView in a fragment (preferred - works for existing implementations)
create a subclass ComposeFragment (less preferred - requires awareness of this new component, also can be confused with fragment-in-compose use case)

Comments

il...@google.com <il...@google.com> #2May 31, 2023 11:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7b17505c2e3679330cf386efe69f1aa95b6ae9e9
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 06 14:47:42 2022

Update safeArgs to AGP 7.0.4

Updating safeArgs to depend on AGP 7.0.4.

Removing the use of reflection from the plugin since we no longer
needed.

RelNote: "Safe Args now depends on Android Gradle Plugin version 7.0.4.
This means that Navigation Safe Args will no longer be compatible with
Android Studio versions prior to 7.0."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-gradle-plugin:test
Bug: 213086135
Bug: 207670704

Change-Id: I41c88ee06ad827c61cb1bbdc5ba58b3d56155caf

M navigation/navigation-safe-args-gradle-plugin/build.gradle
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt

https://android-review.googlesource.com/1940534

ap...@google.com <ap...@google.com> #3Jan 16, 2024 11:55PM

Do you know if I can try this out in a snapshot or has it been published under a version name? (sorry, things in gerrit still confuse me so maybe its already clear that this is fixed and shipped!)

ap...@google.com <ap...@google.com> #4Jan 17, 2024 08:27PM

Yes, you can follow the snapshot instruction and try this out with build id #8054565.

jb...@google.com <jb...@google.com> #5Jan 17, 2024 08:47PM

Marked as fixed, reassigned to jb...@google.com.

@jb...@google.com comment#4

Is the snapshot I'm trying to use 2.5.0-SNAPSHOT?

na...@google.com <na...@google.com> #6Jan 24, 2024 07:53PM

Yay. I can confirm that your fix worked. Thanks! And you were able to beat out the firebase perf plugin in getting a fix released. Thank you! This unblocks my team!

Heads up what I had to do. add the maven repo to buildscript repos

buildscript {
  repositories {
    google()
    mavenCentral()
    maven("https://androidx.dev/snapshots/builds/8054565/artifacts/repository")
  }
}

then update the plugin to

classpath("androidx.navigation:navigation-safe-args-gradle-plugin:2.5.0-SNAPSHOT")

I don't know whether I should update the rest of my nav deps to 2.5.0 snapshot, but this'll do for now.

Issue 258046948