Saved state leak when using BoxWithConstraints in Lazy layout [260322832]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Nov 24, 2022 02:19PM

Jetpack Compose version: 1.3.0 & 1.4.0-alpha02

Android Studio Build: IntelliJ IDEA 2022.2.3

Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Add a BoxWithConstraints to a Lazy layout
Scroll the Lazy layout on Android 9
Check the saved state bundle

We're seeing an issue where a Lazy layout with a BoxWithConstraints in the item will add new items to the saved bundle every time the user scrolls. The entries appear to be AbsSavedState.EMPTY_STATE, but there are so many of them that the bundle fills up quickly and can cause a "TransactionTooLargeException".

I've attached a sample project demonstrating the issue. The issue only appears on Android 9, and the sample project does not exhibit the issue in either Android 8.1 or Android 10. Nor does the issue happen when swapping BoxWithConstraints with Box. Also it appears to have been introduced some point after Compose 1.2.0, as the sample also doesn't experience the issue on Android 9 when using Compose 1.2.0.

ComposeSavedStateBundleLeak.zip

445 KB

Download

Comments

ma...@google.com <ma...@google.com> Nov 28, 2022 09:43AM

Reassigned to an...@google.com.

ka...@mercari.com <ka...@mercari.com> #2Dec 9, 2022 07:14AM

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

an...@google.com <an...@google.com> #3Dec 9, 2022 11:54AM

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

ka...@mercari.com <ka...@mercari.com> #4Dec 15, 2022 10:59AM

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

Message last modified on Dec 15, 2022 11:00AM

ap...@google.com <ap...@google.com> #5Dec 16, 2022 01:34PM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

ap...@google.com <ap...@google.com> #6Dec 16, 2022 01:35PM

Accompanist now supports this with Navigation Material.

an...@google.com <an...@google.com> Dec 16, 2022 01:35PM

Marked as fixed.

ka...@mercari.com <ka...@mercari.com> #7Dec 19, 2022 03:12AM

This feature will be super useful!

st...@google.com <st...@google.com> #8Dec 19, 2022 01:19PM

Until this is implemented, could we at least get a warning notice in the documentation?

Not great to find out half way through a migration that this isn't possible.

Looks like we'll need to rework our app's navigation system (currently based on Fragments) just to support bottom sheets with a Bottom Navigation Bar at first glance. From the docs this wasn't clear.

na...@google.com <na...@google.com> #9Jan 11, 2023 08:11PM

Re comment#6 - can you explain what you are talking about? A fragment based navigation system is not going to be using Navigation Compose, which is what this issue is about and which is already available via Accompanist Navigation Material to unblock any migration to Navigation Compose from a fragment based system.

BottomSheetDialogFragment, which is what you'd use in a fragment based system, has been supported since dialog destinations were added in Navigation 2.1.0-alpha03 back in 2019.

al...@mercari.com <al...@mercari.com> #10Mar 15, 2023 03:16AM

Project: platform/frameworks/support
Branch: androidx-main

commit d65d5731e4f0dfe560b43eae886a4fabfa949b84
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 21 02:14:42 2024

Add Navigation Material from Accompanists to androidx

Now that the needed compose material API are stable, we can move the
navigation material module from Accompanists to Androidx. This means we
will have a new compose-material-navigation module that provides support
for bottomsheets.

RelNote: "Providing new Compose Material Navigation module that adds
support for Bottomsheets in Compose Material."
Test: Added tests and samples
Bug: 180247978

Change-Id: Ia93eb757a32b04dac8ab3ebd2d73207a68635b80

A compose/material/material-navigation/api/current.txt
A compose/material/material-navigation/api/res-current.txt
A compose/material/material-navigation/api/restricted_current.txt
A compose/material/material-navigation/build.gradle
A compose/material/material-navigation/samples/build.gradle
A compose/material/material-navigation/samples/src/main/java/androidx/compose/material/navigation/samples/ComposeMaterialNavigationSamples.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/BottomSheetNavigatorTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/SheetContentHostTest.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigator.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/SheetContentHost.kt
M compose/material/material/integration-tests/material-demos/build.gradle
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M docs-tip-of-tree/build.gradle
M settings.gradle

https://android-review.googlesource.com/2953937

an...@google.com <an...@google.com> #11Mar 15, 2023 12:08PM

This has been added internally and will be released as part of the compose.material library, not navigation.