Saved state leak when using BoxWithConstraints in Lazy layout [260322832]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Nov 24, 2022 02:19PM

Jetpack Compose version: 1.3.0 & 1.4.0-alpha02

Android Studio Build: IntelliJ IDEA 2022.2.3

Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Add a BoxWithConstraints to a Lazy layout
Scroll the Lazy layout on Android 9
Check the saved state bundle

We're seeing an issue where a Lazy layout with a BoxWithConstraints in the item will add new items to the saved bundle every time the user scrolls. The entries appear to be AbsSavedState.EMPTY_STATE, but there are so many of them that the bundle fills up quickly and can cause a "TransactionTooLargeException".

I've attached a sample project demonstrating the issue. The issue only appears on Android 9, and the sample project does not exhibit the issue in either Android 8.1 or Android 10. Nor does the issue happen when swapping BoxWithConstraints with Box. Also it appears to have been introduced some point after Compose 1.2.0, as the sample also doesn't experience the issue on Android 9 when using Compose 1.2.0.

ComposeSavedStateBundleLeak.zip

445 KB

Download

Comments

ma...@google.com <ma...@google.com> Nov 28, 2022 09:43AM

Reassigned to an...@google.com.

ka...@mercari.com <ka...@mercari.com> #2Dec 9, 2022 07:14AM

Thanks for trying out Room KMP! This looks like an issue with Android 9+ and armv7 and the way we compile sqlite3.c, specifically linking to the atomic library in C. We'll try to get this fix as soon as possible.

an...@google.com <an...@google.com> #3Dec 9, 2022 11:54AM

Very related: https://sqlite.org/forum/info/aa703e86823efca3, as suspected seems like a linking issue.

ka...@mercari.com <ka...@mercari.com> #4Dec 15, 2022 10:59AM

Facing the same issue here, surprisingly using the AndroidSQLiteDriver instead of the bundled one seems to work fine. So for now, others facing the crash can fix it by using the AndroidSQLiteDriver instead of the bundled one

Message last modified on Dec 15, 2022 11:00AM

ap...@google.com <ap...@google.com> #5Dec 16, 2022 01:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit cf121571aac008a756b64cda13f76ae4db3e85a6
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed May 29 11:14:42 2024

Link to Android's atomic lib in bundled SQLite

Fix Bundled SQLite loading for devices with older ARM architecture by linking to Android's atomic library instead of relying on Clang's extension (c_atomic) or GCC's built-ins as used in sqlite3.c.

Also add support for passing linker args to androidx's native compilation infra.

See also discussion in

https://sqlite.org/forum/forumpost/792d76a592608d8f

Bug: 341639198
Test: Locally tested via BundledSQLiteDriverTest in a Nexus 5 on API 23
Change-Id: Ia818b7c4f1a990a1b5e35f4c7a3c89694aee0503

M buildSrc/private/src/main/kotlin/androidx/build/clang/ClangSharedLibraryTask.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/KonanBuildService.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/MultiTargetNativeCompilation.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/NativeTargetCompilation.kt
M sqlite/sqlite-bundled/build.gradle

https://android-review.googlesource.com/3108157

ap...@google.com <ap...@google.com> #6Dec 16, 2022 01:35PM

Hello, even if I updated to version androidx.sqlite:sqlite-bundled:2.5.0-alpha04 I just received a crash on a nexus 5X with android 8.1.0 and another one on Redmi Note 11 Pro with android 13.
I'm using androidx.room:room-runtime-android:2.7.0-alpha01.

This is the log:
Fatal Exception: java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/base.apk"],nativeLibraryDirectories=[/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"
at java.lang.Runtime.loadLibrary0(Runtime.java:1011)
at java.lang.System.loadLibrary(System.java:1657)
at androidx.sqlite.driver.bundled.NativeLibraryLoader.loadLibrary(NativeLibraryLoader.android.kt:1)
at androidx.sqlite.driver.bundled.BundledSQLiteDriver.<clinit>(BundledSQLiteDriver.jvmAndroid.kt:1)

Thank you!

an...@google.com <an...@google.com> Dec 16, 2022 01:35PM

Marked as fixed.

ka...@mercari.com <ka...@mercari.com> #7Dec 19, 2022 03:12AM

Can you try using androidx.room:room-runtime-android:2.7.0-alpha04 and confirm if the issue is still present?

st...@google.com <st...@google.com> #8Dec 19, 2022 01:19PM

I will let you know, in alternative can I use AndroidSQLiteDriver instead of the bundled one just for the android implementation?

na...@google.com <na...@google.com> #9Jan 11, 2023 08:11PM

Ideally you could use AndroidSQLiteDriver but Room has a bug with the AndroidSQLiteDriver that is fixed in version 2.7.0-alpha05 that will be released in July 10 so I recommend that if you do switch to using AndroidSQLiteDriver wait for the alpha05 release.

al...@mercari.com <al...@mercari.com> #10Mar 15, 2023 03:16AM

I believe this error still exists.

I just received two errors from Crashlytics using androidx.sqlite:sqlite-bundled version 2.5.0-alpha06 and BundledSQLiteDriver for both Android and iOS.

Fatal Exception: java.lang.UnsatisfiedLinkError
dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/app/com.example.app-ACdqnxIlCwzIlzMdaeegRw==/base.apk"],nativeLibraryDirectories=[/data/app/com.example.app-ACdqnxIlCwzIlzMdaeegRw==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"

And the exception is in .setDriver(BundledSQLiteDriver())

Both crashes were from a Nexus 5X running Android 8.1.0

I would say it is the same exception as in

comment #6

an...@google.com <an...@google.com> #11Mar 15, 2023 12:08PM

Same crash on Nexus 5X running Android 8.1.0 on androidx.sqlite:sqlite-bundled version 2.5.0-alpha10 with room version 2.7.0-alpha10.