Saved state leak when using BoxWithConstraints in Lazy layout [260322832]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Nov 24, 2022 02:19PM

Jetpack Compose version: 1.3.0 & 1.4.0-alpha02

Android Studio Build: IntelliJ IDEA 2022.2.3

Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Add a BoxWithConstraints to a Lazy layout
Scroll the Lazy layout on Android 9
Check the saved state bundle

We're seeing an issue where a Lazy layout with a BoxWithConstraints in the item will add new items to the saved bundle every time the user scrolls. The entries appear to be AbsSavedState.EMPTY_STATE, but there are so many of them that the bundle fills up quickly and can cause a "TransactionTooLargeException".

I've attached a sample project demonstrating the issue. The issue only appears on Android 9, and the sample project does not exhibit the issue in either Android 8.1 or Android 10. Nor does the issue happen when swapping BoxWithConstraints with Box. Also it appears to have been introduced some point after Compose 1.2.0, as the sample also doesn't experience the issue on Android 9 when using Compose 1.2.0.

ComposeSavedStateBundleLeak.zip

445 KB

Download

Comments

ma...@google.com <ma...@google.com> Nov 28, 2022 09:43AM

Reassigned to an...@google.com.

ka...@mercari.com <ka...@mercari.com> #2Dec 9, 2022 07:14AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1381476

an...@google.com <an...@google.com> #3Dec 9, 2022 11:54AM

This has been fixed internally and will be available in the Navigation 2.4.0-alpha01 release.

ka...@mercari.com <ka...@mercari.com> #4Dec 15, 2022 10:59AM

Thank you, that's great to hear. Looking forward to it.

Message last modified on Dec 15, 2022 11:00AM

ap...@google.com <ap...@google.com> #5Dec 16, 2022 01:34PM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699825513

commit 91e0659733e097aabfb5801caccbf6f40d2f4a72
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436153

ap...@google.com <ap...@google.com> #6Dec 16, 2022 01:35PM

Project: platform/frameworks/support
Branch: snap-temp-L62000000699827533

commit 94827a2939f3a4d2c8d08e8dc93d53330de56806
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436736

an...@google.com <an...@google.com> Dec 16, 2022 01:35PM

Marked as fixed.

ka...@mercari.com <ka...@mercari.com> #7Dec 19, 2022 03:12AM

Project: platform/frameworks/support
Branch: snap-temp-L46100000699831674

commit b1fbee9fc7b04ae2cb8868774a714c134c86f865
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436740

st...@google.com <st...@google.com> #8Dec 19, 2022 01:19PM

Project: platform/frameworks/support
Branch: snap-temp-L91000000699844097

commit 81272b7a61a520f9be7803eefd58bf8143b3fd50
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436541

na...@google.com <na...@google.com> #9Jan 11, 2023 08:11PM

Project: platform/frameworks/support
Branch: snap-temp-L34200000699848945

commit 0849c43e4adbea7f96104d328f69a7c504b15ea1
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436871

al...@mercari.com <al...@mercari.com> #10Mar 15, 2023 03:16AM

Project: platform/frameworks/support
Branch: snap-temp-L04700000699849955

commit 2a048de5fbc9f21dfb785a8d015eec9c10930874
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436748

an...@google.com <an...@google.com> #11Mar 15, 2023 12:08PM

Project: platform/frameworks/support
Branch: snap-temp-L69500000699869549

commit f5f97b37c2bf85e50d6e819a0e2529f733e5c5c2
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 30 18:45:38 2020

override equals and hashCode for NavOptions

Lets implement these methods to simplify comparing NavOptions.

Equals method generated using studio.

Test: ./gradlew bOS
Bug: 161586466
Change-Id: I1beb8d06aa72ed6ad7bfe77d1f134a9793bc7e38
(cherry picked from commit 26288a9e8c3cb7ef4888ed252e2765bda7ab7d54)

M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.java

https://android-review.googlesource.com/1436413