Saved state leak when using BoxWithConstraints in Lazy layout [260322832]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Nov 24, 2022 02:19PM

Jetpack Compose version: 1.3.0 & 1.4.0-alpha02

Android Studio Build: IntelliJ IDEA 2022.2.3

Kotlin version: 1.7.10

Steps to Reproduce or Code Sample to Reproduce:

Add a BoxWithConstraints to a Lazy layout
Scroll the Lazy layout on Android 9
Check the saved state bundle

We're seeing an issue where a Lazy layout with a BoxWithConstraints in the item will add new items to the saved bundle every time the user scrolls. The entries appear to be AbsSavedState.EMPTY_STATE, but there are so many of them that the bundle fills up quickly and can cause a "TransactionTooLargeException".

I've attached a sample project demonstrating the issue. The issue only appears on Android 9, and the sample project does not exhibit the issue in either Android 8.1 or Android 10. Nor does the issue happen when swapping BoxWithConstraints with Box. Also it appears to have been introduced some point after Compose 1.2.0, as the sample also doesn't experience the issue on Android 9 when using Compose 1.2.0.

ComposeSavedStateBundleLeak.zip

445 KB

Download

Comments

ma...@google.com <ma...@google.com> Nov 28, 2022 09:43AM

Reassigned to an...@google.com.

ka...@mercari.com <ka...@mercari.com> #2Dec 9, 2022 07:14AM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

an...@google.com <an...@google.com> #3Dec 9, 2022 11:54AM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

ka...@mercari.com <ka...@mercari.com> #4Dec 15, 2022 10:59AM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

Message last modified on Dec 15, 2022 11:00AM

ap...@google.com <ap...@google.com> #5Dec 16, 2022 01:34PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

ap...@google.com <ap...@google.com> #6Dec 16, 2022 01:35PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

an...@google.com <an...@google.com> Dec 16, 2022 01:35PM

Marked as fixed.

ka...@mercari.com <ka...@mercari.com> #7Dec 19, 2022 03:12AM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

st...@google.com <st...@google.com> #8Dec 19, 2022 01:19PM

Yes, this fix is planned to be included in a future 1.7.x release.

na...@google.com <na...@google.com> #9Jan 11, 2023 08:11PM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

al...@mercari.com <al...@mercari.com> #10Mar 15, 2023 03:16AM

Issue is still existing with the same rate in 1.3.3 and similar reproduction steps. Since this ticket is already set as fixed, should we file a new bug?

an...@google.com <an...@google.com> #11Mar 15, 2023 12:08PM

Hey. Please check that you can reproduce the same issue with the latest 1.4 release and if yes please file a new bug. Thanks