Fixed
Status Update
Comments
ja...@gmail.com <ja...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 06035833f0e98b6116774b743c75c2cc7c334326
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 15:52:36 2021
Create @AppCompatShadowedAttributes
This annotation is restricted to intra-androidx library usage. When
applied to a View in AppCompat, it will direct the annotation processor
to infer shadowed attributes for the View based on what interfaces from
Core it implements, e.g.: TintableBackgroundView.
Test: N/A
Relnote: Improved AppCompat support
Bug: 188446121
Change-Id: I2d7387a017585bcea14a8d8a857b9b60930bc1c5
M resourceinspection/resourceinspection-annotation/api/restricted_current.txt
A resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
https://android-review.googlesource.com/1709335
Branch: androidx-main
commit 06035833f0e98b6116774b743c75c2cc7c334326
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 15:52:36 2021
Create @AppCompatShadowedAttributes
This annotation is restricted to intra-androidx library usage. When
applied to a View in AppCompat, it will direct the annotation processor
to infer shadowed attributes for the View based on what interfaces from
Core it implements, e.g.: TintableBackgroundView.
Test: N/A
Relnote: Improved AppCompat support
Bug: 188446121
Change-Id: I2d7387a017585bcea14a8d8a857b9b60930bc1c5
M resourceinspection/resourceinspection-annotation/api/restricted_current.txt
A resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
vi...@eitv.com.br <vi...@eitv.com.br> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 42f9ba7d4ccd46960123b403df5ca28803643059
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 17:41:24 2021
Refactor resource inspection processor model
Extract an Attribute interface to generate code for either shadowed or
annotated regular attributes.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I131f017c433ec9e44a6fb364c903467894735377
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/InspectionCompanionGeneration.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
https://android-review.googlesource.com/1709337
Branch: androidx-main
commit 42f9ba7d4ccd46960123b403df5ca28803643059
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 17:41:24 2021
Refactor resource inspection processor model
Extract an Attribute interface to generate code for either shadowed or
annotated regular attributes.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I131f017c433ec9e44a6fb364c903467894735377
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/InspectionCompanionGeneration.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
ti...@candyspace.com <ti...@candyspace.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 49d18d3f7b42f7a5675357bd51fa4ff22ac0b5d5
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 18:51:33 2021
Shadowed attributes annotation processing
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: Icf4eb2cab92ccde42daf583566f0ce7aca6d6d34
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
M resourceinspection/resourceinspection-processor/src/test/kotlin/androidx/resourceinspection/processor/ResourceInspectionProcessorTest.kt
https://android-review.googlesource.com/1709968
Branch: androidx-main
commit 49d18d3f7b42f7a5675357bd51fa4ff22ac0b5d5
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 18:51:33 2021
Shadowed attributes annotation processing
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: Icf4eb2cab92ccde42daf583566f0ce7aca6d6d34
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
M resourceinspection/resourceinspection-processor/src/test/kotlin/androidx/resourceinspection/processor/ResourceInspectionProcessorTest.kt
aq...@google.com <aq...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021
Document shadowed attribute interfaces
Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75
M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
https://android-review.googlesource.com/1711028
Branch: androidx-main
commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021
Document shadowed attribute interfaces
Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75
M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
bo...@justin.tv <bo...@justin.tv> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 17:53:29 2021
Covert test dependencies to runtime only
Compile testing needs these dependencies to be on the runtime
classpath, but they're not needed on the implementation classpath.
(All use is in source strings or code generated in the test itself.)
This keeps the implementation classpath clean.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783
M resourceinspection/resourceinspection-processor/build.gradle
https://android-review.googlesource.com/1711049
Branch: androidx-main
commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 17:53:29 2021
Covert test dependencies to runtime only
Compile testing needs these dependencies to be on the runtime
classpath, but they're not needed on the implementation classpath.
(All use is in source strings or code generated in the test itself.)
This keeps the implementation classpath clean.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783
M resourceinspection/resourceinspection-processor/build.gradle
aq...@google.com <aq...@google.com> #7
This should be available in appcompat:1.4.0-alpha02 and resourceinpsection:1.0.0-alpha02
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date: Thu May 20 16:36:24 2021
Resourece Inspection 1.0.0-alpha02
Test: N/A
Bug: 188446121
Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
https://android-review.googlesource.com/1714294
Branch: androidx-main
commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date: Thu May 20 16:36:24 2021
Resourece Inspection 1.0.0-alpha02
Test: N/A
Bug: 188446121
Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
aq...@google.com <aq...@google.com> #9
The two missing resolutions have been added in
- Let me know if I missed anything.
- Please upgrade to the next release that includes the fix.
- File a fresh bug if the issue still reproduced, but please provide more info about the patterns behind the crash, like affected API versions, affected device models and DPI.
Description
Component used: androidx.mediarouter Version used: 1.3.1 Devices/Android versions reproduced on:
When reporting bugs, please always include:
We see the following stack trace in Crashlytics, but we can't reproduce the problem locally.
mr_button_dark_static.xml
refers toic_mr_button_connected_30_dark
,ic_mr_button_disconnected_dark
, andic_mr_button_disabled_dark
.ic_mr_button_disconnected_dark
andic_mr_button_disabled_dark
both havexxhdpi
,xhdpi
,hdpi
, andmdpi
versions, butic_mr_button_connected_30_dark
only hasxxhdpi
andxhdpi
versions, so maybe this is the problem?